* [PATCH] mailbox: add control_by_sw for mt8195 @ 2021-12-10 6:11 ` jason-jh.lin 0 siblings, 0 replies; 10+ messages in thread From: jason-jh.lin @ 2021-12-10 6:11 UTC (permalink / raw) To: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, tzungbi Cc: Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, jason-jh.lin, nancy.lin, singo.chang To make sure the GCE request signal to SPM is not trigger by other HW modules and cause suspend premature wake. Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the request signal control by SW and release the request to SPM. Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index a8845b162dbf..342b91f16e65 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = { static const struct gce_plat gce_plat_v6 = { .thread_nr = 24, .shift = 3, - .control_by_sw = false, + .control_by_sw = true, .gce_num = 2 }; -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] mailbox: add control_by_sw for mt8195 @ 2021-12-10 6:11 ` jason-jh.lin 0 siblings, 0 replies; 10+ messages in thread From: jason-jh.lin @ 2021-12-10 6:11 UTC (permalink / raw) To: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, tzungbi Cc: Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, jason-jh.lin, nancy.lin, singo.chang To make sure the GCE request signal to SPM is not trigger by other HW modules and cause suspend premature wake. Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the request signal control by SW and release the request to SPM. Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> --- drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index a8845b162dbf..342b91f16e65 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = { static const struct gce_plat gce_plat_v6 = { .thread_nr = 24, .shift = 3, - .control_by_sw = false, + .control_by_sw = true, .gce_num = 2 }; -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 2021-12-10 6:11 ` jason-jh.lin (?) @ 2021-12-10 7:53 ` Tzung-Bi Shih -1 siblings, 0 replies; 10+ messages in thread From: Tzung-Bi Shih @ 2021-12-10 7:53 UTC (permalink / raw) To: jason-jh.lin Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, nancy.lin, singo.chang On Fri, Dec 10, 2021 at 02:11:38PM +0800, jason-jh.lin wrote: > To make sure the GCE request signal to SPM is not trigger by > other HW modules and cause suspend premature wake. > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > request signal control by SW and release the request to SPM. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 @ 2021-12-10 7:53 ` Tzung-Bi Shih 0 siblings, 0 replies; 10+ messages in thread From: Tzung-Bi Shih @ 2021-12-10 7:53 UTC (permalink / raw) To: jason-jh.lin Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, nancy.lin, singo.chang On Fri, Dec 10, 2021 at 02:11:38PM +0800, jason-jh.lin wrote: > To make sure the GCE request signal to SPM is not trigger by > other HW modules and cause suspend premature wake. > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > request signal control by SW and release the request to SPM. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 @ 2021-12-10 7:53 ` Tzung-Bi Shih 0 siblings, 0 replies; 10+ messages in thread From: Tzung-Bi Shih @ 2021-12-10 7:53 UTC (permalink / raw) To: jason-jh.lin Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, nancy.lin, singo.chang On Fri, Dec 10, 2021 at 02:11:38PM +0800, jason-jh.lin wrote: > To make sure the GCE request signal to SPM is not trigger by > other HW modules and cause suspend premature wake. > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > request signal control by SW and release the request to SPM. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 2021-12-10 6:11 ` jason-jh.lin (?) @ 2021-12-10 15:44 ` Chun-Kuang Hu -1 siblings, 0 replies; 10+ messages in thread From: Chun-Kuang Hu @ 2021-12-10 15:44 UTC (permalink / raw) To: jason-jh.lin Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, tzungbi, Yongqiang Niu, linux-kernel, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, Nancy Lin, singo.chang Hi, Jason: jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年12月10日 週五 下午2:11寫道： > > To make sure the GCE request signal to SPM is not trigger by > other HW modules and cause suspend premature wake. > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > request signal control by SW and release the request to SPM. How does mt8173, mt8183, and mt6779 prevent this? Or these SoCs could not prevent this? Regards, Chun-Kuang. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index a8845b162dbf..342b91f16e65 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = { > static const struct gce_plat gce_plat_v6 = { > .thread_nr = 24, > .shift = 3, > - .control_by_sw = false, > + .control_by_sw = true, > .gce_num = 2 > }; > > -- > 2.18.0 > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 @ 2021-12-10 15:44 ` Chun-Kuang Hu 0 siblings, 0 replies; 10+ messages in thread From: Chun-Kuang Hu @ 2021-12-10 15:44 UTC (permalink / raw) To: jason-jh.lin Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, tzungbi, Yongqiang Niu, linux-kernel, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, Nancy Lin, singo.chang Hi, Jason: jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年12月10日 週五 下午2:11寫道： > > To make sure the GCE request signal to SPM is not trigger by > other HW modules and cause suspend premature wake. > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > request signal control by SW and release the request to SPM. How does mt8173, mt8183, and mt6779 prevent this? Or these SoCs could not prevent this? Regards, Chun-Kuang. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index a8845b162dbf..342b91f16e65 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = { > static const struct gce_plat gce_plat_v6 = { > .thread_nr = 24, > .shift = 3, > - .control_by_sw = false, > + .control_by_sw = true, > .gce_num = 2 > }; > > -- > 2.18.0 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 @ 2021-12-10 15:44 ` Chun-Kuang Hu 0 siblings, 0 replies; 10+ messages in thread From: Chun-Kuang Hu @ 2021-12-10 15:44 UTC (permalink / raw) To: jason-jh.lin Cc: Chun-Kuang Hu, Jassi Brar, Matthias Brugger, tzungbi, Yongqiang Niu, linux-kernel, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, Nancy Lin, singo.chang Hi, Jason: jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年12月10日 週五 下午2:11寫道： > > To make sure the GCE request signal to SPM is not trigger by > other HW modules and cause suspend premature wake. > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > request signal control by SW and release the request to SPM. How does mt8173, mt8183, and mt6779 prevent this? Or these SoCs could not prevent this? Regards, Chun-Kuang. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index a8845b162dbf..342b91f16e65 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = { > static const struct gce_plat gce_plat_v6 = { > .thread_nr = 24, > .shift = 3, > - .control_by_sw = false, > + .control_by_sw = true, > .gce_num = 2 > }; > > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 2021-12-10 15:44 ` Chun-Kuang Hu @ 2021-12-13 5:32 ` Jason-JH Lin -1 siblings, 0 replies; 10+ messages in thread From: Jason-JH Lin @ 2021-12-13 5:32 UTC (permalink / raw) To: Chun-Kuang Hu Cc: Jassi Brar, Matthias Brugger, tzungbi, Yongqiang Niu, linux-kernel, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, Nancy Lin, singo.chang Hi Chun-Kuang, Thanks for the reviews. On Fri, 2021-12-10 at 23:44 +0800, Chun-Kuang Hu wrote: > Hi, Jason: > > jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年12月10日 週五 下午2:11寫道： > > > > To make sure the GCE request signal to SPM is not trigger by > > other HW modules and cause suspend premature wake. > > > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > > request signal control by SW and release the request to SPM. > > How does mt8173, mt8183, and mt6779 prevent this? Or these SoCs could > not prevent this? > > Regards, > Chun-Kuang. > Designer is not sure about the previous SoCs, such as mt6779, mt8173 and mt8183 whose gce is in mmsys, have the same issue or not? So we just add this configuration for mt8195 whose gce is in infra. Regards, Jason-JH.Lin. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > > b/drivers/mailbox/mtk-cmdq-mailbox.c > > index a8845b162dbf..342b91f16e65 100644 > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = { > > static const struct gce_plat gce_plat_v6 = { > > .thread_nr = 24, > > .shift = 3, > > - .control_by_sw = false, > > + .control_by_sw = true, > > .gce_num = 2 > > }; > > > > -- > > 2.18.0 > > -- Jason-JH Lin <jason-jh.lin@mediatek.com> _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] mailbox: add control_by_sw for mt8195 @ 2021-12-13 5:32 ` Jason-JH Lin 0 siblings, 0 replies; 10+ messages in thread From: Jason-JH Lin @ 2021-12-13 5:32 UTC (permalink / raw) To: Chun-Kuang Hu Cc: Jassi Brar, Matthias Brugger, tzungbi, Yongqiang Niu, linux-kernel, DTML, Linux ARM, moderated list:ARM/Mediatek SoC support, Nancy Lin, singo.chang Hi Chun-Kuang, Thanks for the reviews. On Fri, 2021-12-10 at 23:44 +0800, Chun-Kuang Hu wrote: > Hi, Jason: > > jason-jh.lin <jason-jh.lin@mediatek.com> 於 2021年12月10日 週五 下午2:11寫道： > > > > To make sure the GCE request signal to SPM is not trigger by > > other HW modules and cause suspend premature wake. > > > > Set 0x7 (the bit 0~2 as 1) to GCE_GCTL_VALUE, to configure the > > request signal control by SW and release the request to SPM. > > How does mt8173, mt8183, and mt6779 prevent this? Or these SoCs could > not prevent this? > > Regards, > Chun-Kuang. > Designer is not sure about the previous SoCs, such as mt6779, mt8173 and mt8183 whose gce is in mmsys, have the same issue or not? So we just add this configuration for mt8195 whose gce is in infra. Regards, Jason-JH.Lin. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > --- > > drivers/mailbox/mtk-cmdq-mailbox.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c > > b/drivers/mailbox/mtk-cmdq-mailbox.c > > index a8845b162dbf..342b91f16e65 100644 > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > @@ -664,7 +664,7 @@ static const struct gce_plat gce_plat_v5 = { > > static const struct gce_plat gce_plat_v6 = { > > .thread_nr = 24, > > .shift = 3, > > - .control_by_sw = false, > > + .control_by_sw = true, > > .gce_num = 2 > > }; > > > > -- > > 2.18.0 > > -- Jason-JH Lin <jason-jh.lin@mediatek.com> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-12-13 5:34 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-12-10 6:11 [PATCH] mailbox: add control_by_sw for mt8195 jason-jh.lin 2021-12-10 6:11 ` jason-jh.lin 2021-12-10 7:53 ` Tzung-Bi Shih 2021-12-10 7:53 ` Tzung-Bi Shih 2021-12-10 7:53 ` Tzung-Bi Shih 2021-12-10 15:44 ` Chun-Kuang Hu 2021-12-10 15:44 ` Chun-Kuang Hu 2021-12-10 15:44 ` Chun-Kuang Hu 2021-12-13 5:32 ` Jason-JH Lin 2021-12-13 5:32 ` Jason-JH Lin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.