All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, ardb@kernel.org, bp@alien8.de,
	broonie@kernel.org, dave.hansen@linux.intel.com,
	jpoimboe@redhat.com, jslaby@suse.cz,
	linux-arm-kernel@lists.infradead.org, maz@kernel.org,
	mingo@redhat.com, peterz@infradead.org, tabba@google.com,
	tglx@linutronix.de, will@kernel.org
Subject: Re: [RFC PATCH 4/6] arm64: clean up symbol aliasing
Date: Fri, 10 Dec 2021 15:02:59 +0000	[thread overview]
Message-ID: <YbNsI31st3oXleWq@arm.com> (raw)
In-Reply-To: <20211206124715.4101571-5-mark.rutland@arm.com>

On Mon, Dec 06, 2021 at 12:47:13PM +0000, Mark Rutland wrote:
> Now that we have SYM_FUNC_ALIAS() and SYM_FUNC_ALIAS_WEAK(), use those
> to simplify and more consistently define function aliases across
> arch/arm64.
> 
> Aliases are now defined in terms of a canonical function name. For
> position-independent functions I've made the __pi_<func> name the
> canonical name, and defined other alises in terms of this.
> 
> The SYM_FUNC_{START,END}_PI(func) macros obscure the __pi_<func> name,
> and make this hard to seatch for. The SYM_FUNC_START_WEAK_PI() macro
> also obscures the fact that the __pi_<func> fymbol is global and the
> <func> symbol is weak. For clarity, I have removed these macros and used
> SYM_FUNC_{START,END}() directly with the __pi_<func> name.
> 
> For example:
> 
>     SYM_FUNC_START_WEAK_PI(func)
>         ... asm insns ...
>     SYM_FUNC_END_PI(func)
>     EXPORT_SYMBOL(func)
> 
> ... becomes:
> 
>     SYM_FUNC_START(__pi_func)
>         ... asm insns ...
>     SYM_FUNC_END(__pi_func)
> 
>     SYM_FUNC_ALIAS_WEAK(func, __pi_func)
>     EXPORT_SYMBOL(func)
> 
> For clarity, where there are multiple annotations such as
> EXPORT_SYMBOL(), I've tried to keep annotations grouped by symbol. For
> example, where a function has a name and an alias which are both
> exported, this is organised as:
> 
>     SYM_FUNC_START(func)
> 	... asm insns ...
>     SYM_FUNC_END(func)
>     EXPORT_SYMBOL(func)
> 
>     SYM_FUNC_ALAIAS(alias, func)
>     EXPORT_SYMBOL(alias)
> 
> For consistency with the other string functions, I've defined strrchr as
> a position-independent function, as it can safely be used as such even
> though we have no users today.
> 
> As we no longer use SYM_FUNC_{START,END}_ALIAS(), our local copies are
> removed. The common versions will be removed by a subsequent patch.
> 
> There should be no functional change as a result of this patch.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Will Deacon <will@kernel.org>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, ardb@kernel.org, bp@alien8.de,
	broonie@kernel.org, dave.hansen@linux.intel.com,
	jpoimboe@redhat.com, jslaby@suse.cz,
	linux-arm-kernel@lists.infradead.org, maz@kernel.org,
	mingo@redhat.com, peterz@infradead.org, tabba@google.com,
	tglx@linutronix.de, will@kernel.org
Subject: Re: [RFC PATCH 4/6] arm64: clean up symbol aliasing
Date: Fri, 10 Dec 2021 15:02:59 +0000	[thread overview]
Message-ID: <YbNsI31st3oXleWq@arm.com> (raw)
In-Reply-To: <20211206124715.4101571-5-mark.rutland@arm.com>

On Mon, Dec 06, 2021 at 12:47:13PM +0000, Mark Rutland wrote:
> Now that we have SYM_FUNC_ALIAS() and SYM_FUNC_ALIAS_WEAK(), use those
> to simplify and more consistently define function aliases across
> arch/arm64.
> 
> Aliases are now defined in terms of a canonical function name. For
> position-independent functions I've made the __pi_<func> name the
> canonical name, and defined other alises in terms of this.
> 
> The SYM_FUNC_{START,END}_PI(func) macros obscure the __pi_<func> name,
> and make this hard to seatch for. The SYM_FUNC_START_WEAK_PI() macro
> also obscures the fact that the __pi_<func> fymbol is global and the
> <func> symbol is weak. For clarity, I have removed these macros and used
> SYM_FUNC_{START,END}() directly with the __pi_<func> name.
> 
> For example:
> 
>     SYM_FUNC_START_WEAK_PI(func)
>         ... asm insns ...
>     SYM_FUNC_END_PI(func)
>     EXPORT_SYMBOL(func)
> 
> ... becomes:
> 
>     SYM_FUNC_START(__pi_func)
>         ... asm insns ...
>     SYM_FUNC_END(__pi_func)
> 
>     SYM_FUNC_ALIAS_WEAK(func, __pi_func)
>     EXPORT_SYMBOL(func)
> 
> For clarity, where there are multiple annotations such as
> EXPORT_SYMBOL(), I've tried to keep annotations grouped by symbol. For
> example, where a function has a name and an alias which are both
> exported, this is organised as:
> 
>     SYM_FUNC_START(func)
> 	... asm insns ...
>     SYM_FUNC_END(func)
>     EXPORT_SYMBOL(func)
> 
>     SYM_FUNC_ALAIAS(alias, func)
>     EXPORT_SYMBOL(alias)
> 
> For consistency with the other string functions, I've defined strrchr as
> a position-independent function, as it can safely be used as such even
> though we have no users today.
> 
> As we no longer use SYM_FUNC_{START,END}_ALIAS(), our local copies are
> removed. The common versions will be removed by a subsequent patch.
> 
> There should be no functional change as a result of this patch.
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Will Deacon <will@kernel.org>

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

  reply	other threads:[~2021-12-10 15:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06 12:47 [RFC PATCH 0/6] linkage: better symbol aliasing Mark Rutland
2021-12-06 12:47 ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 1/6] linkage: add SYM_{ENTRY,START,END}_AT() Mark Rutland
2021-12-06 12:47   ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 2/6] linkage: add SYM_FUNC_{LOCAL_,}ALIAS() Mark Rutland
2021-12-06 12:47   ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 3/6] arm64: remove __dma_*_area() aliases Mark Rutland
2021-12-06 12:47   ` Mark Rutland
2021-12-10 15:02   ` Catalin Marinas
2021-12-10 15:02     ` Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 4/6] arm64: clean up symbol aliasing Mark Rutland
2021-12-06 12:47   ` Mark Rutland
2021-12-10 15:02   ` Catalin Marinas [this message]
2021-12-10 15:02     ` Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 5/6] x86: " Mark Rutland
2021-12-06 12:47   ` Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 6/6] linkage: remove START/END ALIAS macros Mark Rutland
2021-12-06 12:47   ` Mark Rutland
2021-12-06 14:06 ` [RFC PATCH 0/6] linkage: better symbol aliasing Ard Biesheuvel
2021-12-06 14:06   ` Ard Biesheuvel
2021-12-06 15:10   ` Mark Brown
2021-12-06 15:10     ` Mark Brown
2021-12-07  5:23 ` Josh Poimboeuf
2021-12-07  5:23   ` Josh Poimboeuf
2021-12-07 13:33   ` Mark Rutland
2021-12-07 13:33     ` Mark Rutland
2021-12-10 15:04 ` Catalin Marinas
2021-12-10 15:04   ` Catalin Marinas
2021-12-15  9:24   ` Mark Rutland
2021-12-15  9:24     ` Mark Rutland
2021-12-15 11:28 ` (subset) " Catalin Marinas
2021-12-15 11:28   ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbNsI31st3oXleWq@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=jpoimboe@redhat.com \
    --cc=jslaby@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tabba@google.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.