From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, - <opensource@rock-chips.com>,
David Heidelberg <david@ixit.cz>,
~okias/devicetree@lists.sr.ht, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI
Date: Mon, 13 Dec 2021 16:51:05 -0600 [thread overview]
Message-ID: <YbfOWXZJAZDuEU1V@robh.at.kernel.org> (raw)
In-Reply-To: <26502781.jAYDHVeSjN@diego>
On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko Stübner wrote:
> Hi David,
>
> Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg:
> > Convert into YAML format into format, which can be validated.
> >
> > Changes:
> > - drop panel from example
>
> the patch subject is strange, talking about a "power domain node".
> That needs a fix.
>
> Some more things below.
>
>
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - rockchip,px30-mipi-dsi
> > + - rockchip,rk3288-mipi-dsi
> > + - rockchip,rk3399-mipi-dsi
> > + - const: snps,dw-mipi-dsi
>
> > + - items:
> > + - const: rockchip,px30-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3288-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3399-mipi-dsi
>
> what are these for?
>
> I see that px30 uses the dsi without the snps part, but you
> can also just add a patch adding that second compatible to px30.dtsi
Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful.
But I guess that's more invasive so maybe stick with changing px30.
>
> I don't think we need to support both ways.
Agreed.
Rob
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, - <opensource@rock-chips.com>,
David Heidelberg <david@ixit.cz>,
~okias/devicetree@lists.sr.ht, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI
Date: Mon, 13 Dec 2021 16:51:05 -0600 [thread overview]
Message-ID: <YbfOWXZJAZDuEU1V@robh.at.kernel.org> (raw)
In-Reply-To: <26502781.jAYDHVeSjN@diego>
On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko Stübner wrote:
> Hi David,
>
> Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg:
> > Convert into YAML format into format, which can be validated.
> >
> > Changes:
> > - drop panel from example
>
> the patch subject is strange, talking about a "power domain node".
> That needs a fix.
>
> Some more things below.
>
>
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - rockchip,px30-mipi-dsi
> > + - rockchip,rk3288-mipi-dsi
> > + - rockchip,rk3399-mipi-dsi
> > + - const: snps,dw-mipi-dsi
>
> > + - items:
> > + - const: rockchip,px30-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3288-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3399-mipi-dsi
>
> what are these for?
>
> I see that px30 uses the dsi without the snps part, but you
> can also just add a patch adding that second compatible to px30.dtsi
Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful.
But I guess that's more invasive so maybe stick with changing px30.
>
> I don't think we need to support both ways.
Agreed.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Sandy Huang <hjc@rock-chips.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, - <opensource@rock-chips.com>,
David Heidelberg <david@ixit.cz>,
~okias/devicetree@lists.sr.ht, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI
Date: Mon, 13 Dec 2021 16:51:05 -0600 [thread overview]
Message-ID: <YbfOWXZJAZDuEU1V@robh.at.kernel.org> (raw)
In-Reply-To: <26502781.jAYDHVeSjN@diego>
On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko Stübner wrote:
> Hi David,
>
> Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg:
> > Convert into YAML format into format, which can be validated.
> >
> > Changes:
> > - drop panel from example
>
> the patch subject is strange, talking about a "power domain node".
> That needs a fix.
>
> Some more things below.
>
>
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - rockchip,px30-mipi-dsi
> > + - rockchip,rk3288-mipi-dsi
> > + - rockchip,rk3399-mipi-dsi
> > + - const: snps,dw-mipi-dsi
>
> > + - items:
> > + - const: rockchip,px30-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3288-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3399-mipi-dsi
>
> what are these for?
>
> I see that px30 uses the dsi without the snps part, but you
> can also just add a patch adding that second compatible to px30.dtsi
Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful.
But I guess that's more invasive so maybe stick with changing px30.
>
> I don't think we need to support both ways.
Agreed.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: - <opensource@rock-chips.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
Sandy Huang <hjc@rock-chips.com>,
David Heidelberg <david@ixit.cz>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, ~okias/devicetree@lists.sr.ht,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI
Date: Mon, 13 Dec 2021 16:51:05 -0600 [thread overview]
Message-ID: <YbfOWXZJAZDuEU1V@robh.at.kernel.org> (raw)
In-Reply-To: <26502781.jAYDHVeSjN@diego>
On Sat, Dec 11, 2021 at 11:55:58AM +0100, Heiko Stübner wrote:
> Hi David,
>
> Am Montag, 6. Dezember 2021, 22:26:50 CET schrieb David Heidelberg:
> > Convert into YAML format into format, which can be validated.
> >
> > Changes:
> > - drop panel from example
>
> the patch subject is strange, talking about a "power domain node".
> That needs a fix.
>
> Some more things below.
>
>
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - enum:
> > + - rockchip,px30-mipi-dsi
> > + - rockchip,rk3288-mipi-dsi
> > + - rockchip,rk3399-mipi-dsi
> > + - const: snps,dw-mipi-dsi
>
> > + - items:
> > + - const: rockchip,px30-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3288-mipi-dsi
> > + - items:
> > + - const: rockchip,rk3399-mipi-dsi
>
> what are these for?
>
> I see that px30 uses the dsi without the snps part, but you
> can also just add a patch adding that second compatible to px30.dtsi
Or drop snps,dw-mipi-dsi as it doesn't seem to be all that meaningful.
But I guess that's more invasive so maybe stick with changing px30.
>
> I don't think we need to support both ways.
Agreed.
Rob
next prev parent reply other threads:[~2021-12-13 22:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 21:26 [PATCH] dt-bindings: convert power domain node for rockchip DW MIPI DSI David Heidelberg
2021-12-06 21:26 ` David Heidelberg
2021-12-06 21:26 ` David Heidelberg
2021-12-06 21:26 ` David Heidelberg
2021-12-11 10:55 ` Heiko Stübner
2021-12-11 10:55 ` Heiko Stübner
2021-12-11 10:55 ` Heiko Stübner
2021-12-11 10:55 ` Heiko Stübner
2021-12-13 22:51 ` Rob Herring [this message]
2021-12-13 22:51 ` Rob Herring
2021-12-13 22:51 ` Rob Herring
2021-12-13 22:51 ` Rob Herring
2021-12-13 22:47 ` Rob Herring
2021-12-13 22:47 ` Rob Herring
2021-12-13 22:47 ` Rob Herring
2021-12-13 22:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbfOWXZJAZDuEU1V@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=opensource@rock-chips.com \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.