From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/1] lib: Add support for debugging .all_filesystems
Date: Tue, 14 Dec 2021 09:29:41 +0100 [thread overview]
Message-ID: <YbhV9VIv/8o97O6r@pevik> (raw)
In-Reply-To: <CAEemH2dp55yFvaXhq_5e77k6QBnY0aFU5fhz4TjW82bkbwwDiA@mail.gmail.com>
Hi Li,
> On Tue, Dec 14, 2021 at 3:34 AM Petr Vorel <pvorel@suse.cz> wrote:
> > LTP_ALL_FILESYSTEMS_ONLY_FS_TYPE environment variable tests only that
> > filesystem instead of all supported filesystems.
...
> > +++ b/doc/user-guide.txt
...
> > 'TST_NEEDS_DEVICE=1').
> > +| 'LTP_ALL_FILESYSTEMS_ONLY_FS_TYPE' | Testing only specified filesystem
> > instead all
> > + supported (for tests with '.all_filesystems').
> My only concern is that the variable name is too long and not easy
> to remember/understand usage. Can we find a better name?
> LTP_ONE_FS_TYPE
> LTP_ASGD_FD_TYPE
> LTP_FS_TYPE_DEBUG
Yes, it's too long. LTP_FS_TYPE_DEBUG sounds best to me, but no strong opinion
about it.
If we agree we want this, we can consider to use some switch instead or print
this variable in help output (-h), with other variables from
https://github.com/linux-test-project/ltp/wiki/User-Guidelines.
> or some else.
> P.s.
> And btw I often use .skip_filesystems skip other FS for debugging :).
I do use it as well, but it's I wanted to have way to debug single filesystem
without having to recompile (easier on embedded or non-intel platforms run via
some frameworks).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-12-14 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 19:34 [LTP] [PATCH 1/1] lib: Add support for debugging .all_filesystems Petr Vorel
2021-12-14 7:46 ` Li Wang
2021-12-14 8:29 ` Petr Vorel [this message]
2021-12-14 9:04 ` Li Wang
2021-12-14 10:35 ` Cyril Hrubis
2021-12-14 11:27 ` Petr Vorel
2021-12-14 12:14 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbhV9VIv/8o97O6r@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.