All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/1] lib: Add support for debugging .all_filesystems
Date: Tue, 14 Dec 2021 12:27:06 +0100	[thread overview]
Message-ID: <Ybh/isQcQltJFlyb@pevik> (raw)
In-Reply-To: <YbhzexvHiyLKSAu6@yuki>

Hi all,

> Hi!
> > > My only concern is that the variable name is too long and not easy
> > > to remember/understand usage. Can we find a better name?
> > >     LTP_ONE_FS_TYPE
> > >     LTP_ASGD_FD_TYPE
> > >     LTP_FS_TYPE_DEBUG
> > Yes, it's too long. LTP_FS_TYPE_DEBUG sounds best to me, but no strong opinion
> > about it.

> Not sure about the "DEBUG" in the name. I would go for a variation of
> the first name "LTP_SINGLE_FS_TYPE" or "LTP_LIMIT_FS_TYPE"
LTP_SINGLE_FS_TYPE looks better for me, because I'd understand LIMIT to run
fewer filesystems but possibly more than one.

> > If we agree we want this, we can consider to use some switch instead or print
> > this variable in help output (-h), with other variables from
> > https://github.com/linux-test-project/ltp/wiki/User-Guidelines.

> Printing the variables on -h does sounds reasonabe.
+1 (post v2).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2021-12-14 11:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13 19:34 [LTP] [PATCH 1/1] lib: Add support for debugging .all_filesystems Petr Vorel
2021-12-14  7:46 ` Li Wang
2021-12-14  8:29   ` Petr Vorel
2021-12-14  9:04     ` Li Wang
2021-12-14 10:35     ` Cyril Hrubis
2021-12-14 11:27       ` Petr Vorel [this message]
2021-12-14 12:14         ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ybh/isQcQltJFlyb@pevik \
    --to=pvorel@suse.cz \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.