Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML

From: Rob Herring <robh@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
	linux-pwm@vger.kernel.org, linux-mmc@vger.kernel.org,
	"Markus Mayer" <mmayer@broadcom.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Ray Jui" <rjui@broadcom.com>, "Amit Kucheria" <amitk@kernel.org>,
	bcm-kernel-feedback-list@broadcom.com,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-pm@vger.kernel.org, "Doug Berger" <opendmb@gmail.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Bartosz Golaszewski" <brgl@bgdev.pl>,
	linux-usb@vger.kernel.org,
	"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-ide@vger.kernel.org, "Thomas Gleixner" <tglx@linutronix.de>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Al Cooper" <alcooperx@gmail.com>,
	"Daniel Lezcano" <daniel.lezcano@linaro.org>,
	linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Gregory Fong" <gregory.0xf0@gmail.com>,
	linux-rtc@vger.kernel.org,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Marc Zyngier" <maz@kernel.org>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 13/15] dt-bindings: ata: Convert Broadcom SATA to YAML
Date: Tue, 14 Dec 2021 12:28:54 -0600	[thread overview]
Message-ID: <YbjiZkK4HpWq90oG@robh.at.kernel.org> (raw)
In-Reply-To: <dd170216-fedd-45a1-a3a5-efc99b9f6197@gmail.com>

On Wed, Dec 08, 2021 at 09:33:38AM -0800, Florian Fainelli wrote:
> On 12/8/21 5:44 AM, Rob Herring wrote:
> > On Tue, 07 Dec 2021 16:37:24 -0800, Florian Fainelli wrote:
> >> Convert the Broadcom SATA3 AHCI controller Device Tree binding to YAML
> >> to help with validation.
> >>
> >> Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >>  .../bindings/ata/brcm,sata-brcm.txt           | 45 ---------
> >>  .../bindings/ata/brcm,sata-brcm.yaml          | 98 +++++++++++++++++++
> >>  2 files changed, 98 insertions(+), 45 deletions(-)
> >>  delete mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.txt
> >>  create mode 100644 Documentation/devicetree/bindings/ata/brcm,sata-brcm.yaml
> >>
> > 
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> > 
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> > 
> > Full log is available here: https://patchwork.ozlabs.org/patch/1565011
> 
> Likewise, those indicate that the preceding patch which renames the sata
> controller unit name has not been applied.

I looked at that, but it was the unevaluated properties I was worried 
about. However, the example has the same thing, but no errors. I think 
running with DT_SCHEMA_FILES means sata-common.yaml is not included. 
I'll have to look into that.

Rob