From: Greg KH <gregkh@linuxfoundation.org>
To: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Cc: stable@vger.kernel.org, rppt@kernel.org,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux@armlinux.org.uk, rppt@linux.ibm.com, tony@atomide.com,
wangkefeng.wang@huawei.com, yj.chiang@mediatek.com
Subject: Re: [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map
Date: Wed, 15 Dec 2021 15:02:17 +0100 [thread overview]
Message-ID: <Ybn1aSo/pMq2tMPm@kroah.com> (raw)
In-Reply-To: <YbcNXBj+FIwuQd/8@kroah.com>
On Mon, Dec 13, 2021 at 10:07:40AM +0100, Greg KH wrote:
> On Mon, Dec 13, 2021 at 04:57:05PM +0800, Mark-PK Tsai wrote:
> > When linux memory is not aligned with page block size and have hole in zone,
> > the 5.4-lts arm kernel might crash in move_freepages() as Kefen Wang reported in [1].
> > Backport the upstream fix commits by Mike Rapoport [2] to 5.4 can fix this issue.
> >
> > And free_unused_memmap() of arm and arm64 are moved to generic mm/memblock in
> > the below upstream commit, so I applied the first two patches to free_unused_memmap()
> > in arch/arm/mm/init.c.
> >
> > (4f5b0c178996 arm, arm64: move free_unused_memmap() to generic mm)
> >
> > [1] https://lore.kernel.org/lkml/2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com/
> > [2] https://lore.kernel.org/lkml/20210630071211.21011-1-rppt@kernel.org/#t
> >
> > Mike Rapoport (5):
> > memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER
> > memblock: align freed memory map on pageblock boundaries with
> > SPARSEMEM
> > memblock: ensure there is no overflow in memblock_overlaps_region()
> > arm: extend pfn_valid to take into account freed memory map alignment
> > arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM
> >
> > arch/arm/mm/init.c | 37 +++++++++++++++++++++++++------------
> > arch/arm/mm/ioremap.c | 4 +++-
> > mm/memblock.c | 3 ++-
> > 3 files changed, 30 insertions(+), 14 deletions(-)
> >
> > --
> > 2.18.0
> >
>
> These look like they also are required in 5.10.y as well, right? Please
> also provide a backported series for that tree, we can not have users
> moving to a newer kernel version and having regressions.
>
> I can't take this series until then, sorry.
Ah, now I see your 5.10 series, thanks. I'll go queue both of these
series up now, thanks for the backports.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
Cc: stable@vger.kernel.org, rppt@kernel.org,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux@armlinux.org.uk, rppt@linux.ibm.com, tony@atomide.com,
wangkefeng.wang@huawei.com, yj.chiang@mediatek.com
Subject: Re: [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map
Date: Wed, 15 Dec 2021 15:02:17 +0100 [thread overview]
Message-ID: <Ybn1aSo/pMq2tMPm@kroah.com> (raw)
In-Reply-To: <YbcNXBj+FIwuQd/8@kroah.com>
On Mon, Dec 13, 2021 at 10:07:40AM +0100, Greg KH wrote:
> On Mon, Dec 13, 2021 at 04:57:05PM +0800, Mark-PK Tsai wrote:
> > When linux memory is not aligned with page block size and have hole in zone,
> > the 5.4-lts arm kernel might crash in move_freepages() as Kefen Wang reported in [1].
> > Backport the upstream fix commits by Mike Rapoport [2] to 5.4 can fix this issue.
> >
> > And free_unused_memmap() of arm and arm64 are moved to generic mm/memblock in
> > the below upstream commit, so I applied the first two patches to free_unused_memmap()
> > in arch/arm/mm/init.c.
> >
> > (4f5b0c178996 arm, arm64: move free_unused_memmap() to generic mm)
> >
> > [1] https://lore.kernel.org/lkml/2a1592ad-bc9d-4664-fd19-f7448a37edc0@huawei.com/
> > [2] https://lore.kernel.org/lkml/20210630071211.21011-1-rppt@kernel.org/#t
> >
> > Mike Rapoport (5):
> > memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER
> > memblock: align freed memory map on pageblock boundaries with
> > SPARSEMEM
> > memblock: ensure there is no overflow in memblock_overlaps_region()
> > arm: extend pfn_valid to take into account freed memory map alignment
> > arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM
> >
> > arch/arm/mm/init.c | 37 +++++++++++++++++++++++++------------
> > arch/arm/mm/ioremap.c | 4 +++-
> > mm/memblock.c | 3 ++-
> > 3 files changed, 30 insertions(+), 14 deletions(-)
> >
> > --
> > 2.18.0
> >
>
> These look like they also are required in 5.10.y as well, right? Please
> also provide a backported series for that tree, we can not have users
> moving to a newer kernel version and having regressions.
>
> I can't take this series until then, sorry.
Ah, now I see your 5.10 series, thanks. I'll go queue both of these
series up now, thanks for the backports.
greg k-h
next prev parent reply other threads:[~2021-12-15 14:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 8:57 [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map Mark-PK Tsai
2021-12-13 8:57 ` Mark-PK Tsai
2021-12-13 8:57 ` [PATCH 5.4 1/5] memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER Mark-PK Tsai
2021-12-13 8:57 ` Mark-PK Tsai
2021-12-13 10:31 ` Mike Rapoport
2021-12-13 10:31 ` Mike Rapoport
2021-12-15 14:09 ` Patch "memblock: free_unused_memmap: use pageblock units instead of MAX_ORDER" has been added to the 5.4-stable tree gregkh
2021-12-15 14:09 ` gregkh
2021-12-13 8:57 ` [PATCH 5.4 2/5] memblock: align freed memory map on pageblock boundaries with SPARSEMEM Mark-PK Tsai
2021-12-13 8:57 ` Mark-PK Tsai
2021-12-15 14:09 ` Patch "memblock: align freed memory map on pageblock boundaries with SPARSEMEM" has been added to the 5.4-stable tree gregkh
2021-12-15 14:09 ` gregkh
2021-12-13 8:57 ` [PATCH 5.4 3/5] memblock: ensure there is no overflow in memblock_overlaps_region() Mark-PK Tsai
2021-12-13 8:57 ` Mark-PK Tsai
2021-12-15 14:09 ` Patch "memblock: ensure there is no overflow in memblock_overlaps_region()" has been added to the 5.4-stable tree gregkh
2021-12-15 14:09 ` gregkh
2021-12-13 8:57 ` [PATCH 5.4 4/5] arm: extend pfn_valid to take into account freed memory map alignment Mark-PK Tsai
2021-12-13 8:57 ` Mark-PK Tsai
2021-12-15 14:09 ` Patch "arm: extend pfn_valid to take into account freed memory map alignment" has been added to the 5.4-stable tree gregkh
2021-12-15 14:09 ` gregkh
2021-12-13 8:57 ` [PATCH 5.4 5/5] arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM Mark-PK Tsai
2021-12-13 8:57 ` Mark-PK Tsai
2021-12-15 14:09 ` Patch "arm: ioremap: don't abuse pfn_valid() to check if pfn is in RAM" has been added to the 5.4-stable tree gregkh
2021-12-15 14:09 ` gregkh
2021-12-13 9:07 ` [PATCH 5.4 0/5] memblock, arm: fixes for freeing of the memory map Greg KH
2021-12-13 9:07 ` Greg KH
2021-12-15 14:02 ` Greg KH [this message]
2021-12-15 14:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybn1aSo/pMq2tMPm@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=mark-pk.tsai@mediatek.com \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=stable@vger.kernel.org \
--cc=tony@atomide.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yj.chiang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.