From: Rob Herring <robh@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: andy.shevchenko@gmail.com, christian.koenig@amd.com,
digetx@gmail.com, dri-devel@lists.freedesktop.org,
jonathanh@nvidia.com, ldewangan@nvidia.com,
linaro-mm-sig@lists.linaro.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-tegra@vger.kernel.org, p.zabel@pengutronix.de,
sumit.semwal@linaro.org, thierry.reding@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties
Date: Wed, 15 Dec 2021 12:37:29 -0600 [thread overview]
Message-ID: <Ybo16aNZ5MBW6XY6@robh.at.kernel.org> (raw)
In-Reply-To: <1639062321-18840-2-git-send-email-akhilrajeev@nvidia.com>
On Thu, Dec 09, 2021 at 08:35:20PM +0530, Akhil R wrote:
> Tegra I2C can use a gpio as an smbus-alert. Document the usage of
> the same.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
> Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> index 3f2f990..71ee79b 100644
> --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> @@ -70,6 +70,10 @@ Required properties:
> - rx
> - tx
>
> +optional properties:
> +- smbalert-gpio: Must contain an entry for the gpio to be used as smbus alert.
> + It will be used only if optional smbus-alert property is present.
There's already a standard way to do this with interrupts. And GPIOs can
be interrupts usually.
> +
> Example:
>
> i2c@7000c000 {
> --
> 2.7.4
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Akhil R <akhilrajeev@nvidia.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, jonathanh@nvidia.com,
linaro-mm-sig@lists.linaro.org, andy.shevchenko@gmail.com,
ldewangan@nvidia.com, thierry.reding@gmail.com,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
digetx@gmail.com, christian.koenig@amd.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties
Date: Wed, 15 Dec 2021 12:37:29 -0600 [thread overview]
Message-ID: <Ybo16aNZ5MBW6XY6@robh.at.kernel.org> (raw)
In-Reply-To: <1639062321-18840-2-git-send-email-akhilrajeev@nvidia.com>
On Thu, Dec 09, 2021 at 08:35:20PM +0530, Akhil R wrote:
> Tegra I2C can use a gpio as an smbus-alert. Document the usage of
> the same.
>
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
> Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> index 3f2f990..71ee79b 100644
> --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.txt
> @@ -70,6 +70,10 @@ Required properties:
> - rx
> - tx
>
> +optional properties:
> +- smbalert-gpio: Must contain an entry for the gpio to be used as smbus alert.
> + It will be used only if optional smbus-alert property is present.
There's already a standard way to do this with interrupts. And GPIOs can
be interrupts usually.
> +
> Example:
>
> i2c@7000c000 {
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2021-12-15 18:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 15:05 [PATCH 0/2] Add SMBus features to Tegra I2C Akhil R
2021-12-09 15:05 ` Akhil R
2021-12-09 15:05 ` [PATCH 1/2] dt-bindings: i2c: tegra: Add SMBus feature properties Akhil R
2021-12-09 15:05 ` Akhil R
2021-12-09 15:30 ` Andy Shevchenko
2021-12-09 15:30 ` Andy Shevchenko
2021-12-15 18:37 ` Rob Herring [this message]
2021-12-15 18:37 ` Rob Herring
2021-12-09 15:05 ` [PATCH 2/2] i2c: tegra: Add SMBus block read and SMBus alert functions Akhil R
2021-12-09 15:05 ` Akhil R
2021-12-09 15:27 ` Dmitry Osipenko
2021-12-10 9:38 ` Akhil R
2021-12-11 20:07 ` Dmitry Osipenko
2021-12-11 20:12 ` Dmitry Osipenko
2021-12-09 15:30 ` Dmitry Osipenko
2021-12-09 15:33 ` Andy Shevchenko
2021-12-09 15:33 ` Andy Shevchenko
2021-12-09 15:42 ` Dmitry Osipenko
2021-12-09 15:42 ` Dmitry Osipenko
2021-12-09 15:43 ` Dmitry Osipenko
2021-12-09 16:04 ` [PATCH 0/2] Add SMBus features to Tegra I2C Dmitry Osipenko
2021-12-10 8:56 ` Thierry Reding
2021-12-10 8:56 ` Thierry Reding
2021-12-15 18:42 ` Rob Herring
2021-12-15 18:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybo16aNZ5MBW6XY6@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=akhilrajeev@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=christian.koenig@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.