* [PATCH] phy: freescale: pcie: explictly add bitfield.h
@ 2021-12-15 6:08 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2021-12-15 6:08 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Richard Zhu
Cc: linux-phy, Vinod Koul, linux-arm-kernel, linux-kernel,
kernel test robot
kernel test robot complains about missing FIELD_PREP, so include
bitfield.h for that
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index f6502463d49a..04b1aafb29f4 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -3,6 +3,7 @@
* Copyright 2021 NXP
*/
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/iopoll.h>
--
2.31.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] phy: freescale: pcie: explictly add bitfield.h
@ 2021-12-15 6:08 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2021-12-15 6:08 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Richard Zhu
Cc: linux-phy, Vinod Koul, linux-arm-kernel, linux-kernel,
kernel test robot
kernel test robot complains about missing FIELD_PREP, so include
bitfield.h for that
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index f6502463d49a..04b1aafb29f4 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -3,6 +3,7 @@
* Copyright 2021 NXP
*/
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/iopoll.h>
--
2.31.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] phy: freescale: pcie: explictly add bitfield.h
@ 2021-12-15 6:08 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2021-12-15 6:08 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Richard Zhu
Cc: linux-phy, Vinod Koul, linux-arm-kernel, linux-kernel,
kernel test robot
kernel test robot complains about missing FIELD_PREP, so include
bitfield.h for that
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
index f6502463d49a..04b1aafb29f4 100644
--- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
@@ -3,6 +3,7 @@
* Copyright 2021 NXP
*/
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/io.h>
#include <linux/iopoll.h>
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH] phy: freescale: pcie: explictly add bitfield.h
2021-12-15 6:08 ` Vinod Koul
(?)
@ 2021-12-15 6:29 ` Hongxing Zhu
-1 siblings, 0 replies; 9+ messages in thread
From: Hongxing Zhu @ 2021-12-15 6:29 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I
Cc: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot
> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Wednesday, December 15, 2021 2:09 PM
> To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> <hongxing.zhu@nxp.com>
> Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel test robot <lkp@intel.com>
> Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
>
> kernel test robot complains about missing FIELD_PREP, so include
> bitfield.h for that
>
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> standalone phy driver")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks a lot for your help to fix it.
And I'm sorry about that I didn't capture this error in my local build and tests.
Best Regards
Richard Zhu
> ---
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index f6502463d49a..04b1aafb29f4 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -3,6 +3,7 @@
> * Copyright 2021 NXP
> */
>
> +#include <linux/bitfield.h>
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> --
> 2.31.1
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] phy: freescale: pcie: explictly add bitfield.h
@ 2021-12-15 6:29 ` Hongxing Zhu
0 siblings, 0 replies; 9+ messages in thread
From: Hongxing Zhu @ 2021-12-15 6:29 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I
Cc: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot
> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Wednesday, December 15, 2021 2:09 PM
> To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> <hongxing.zhu@nxp.com>
> Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel test robot <lkp@intel.com>
> Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
>
> kernel test robot complains about missing FIELD_PREP, so include
> bitfield.h for that
>
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> standalone phy driver")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks a lot for your help to fix it.
And I'm sorry about that I didn't capture this error in my local build and tests.
Best Regards
Richard Zhu
> ---
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index f6502463d49a..04b1aafb29f4 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -3,6 +3,7 @@
> * Copyright 2021 NXP
> */
>
> +#include <linux/bitfield.h>
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> --
> 2.31.1
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH] phy: freescale: pcie: explictly add bitfield.h
@ 2021-12-15 6:29 ` Hongxing Zhu
0 siblings, 0 replies; 9+ messages in thread
From: Hongxing Zhu @ 2021-12-15 6:29 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I
Cc: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot
> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Wednesday, December 15, 2021 2:09 PM
> To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> <hongxing.zhu@nxp.com>
> Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> kernel test robot <lkp@intel.com>
> Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
>
> kernel test robot complains about missing FIELD_PREP, so include
> bitfield.h for that
>
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> declaration of function 'FIELD_PREP'
> [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> standalone phy driver")
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks a lot for your help to fix it.
And I'm sorry about that I didn't capture this error in my local build and tests.
Best Regards
Richard Zhu
> ---
> drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> index f6502463d49a..04b1aafb29f4 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c
> @@ -3,6 +3,7 @@
> * Copyright 2021 NXP
> */
>
> +#include <linux/bitfield.h>
> #include <linux/clk.h>
> #include <linux/io.h>
> #include <linux/iopoll.h>
> --
> 2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] phy: freescale: pcie: explictly add bitfield.h
2021-12-15 6:29 ` Hongxing Zhu
(?)
@ 2021-12-15 15:21 ` Vinod Koul
-1 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2021-12-15 15:21 UTC (permalink / raw)
To: Hongxing Zhu
Cc: Kishon Vijay Abraham I, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot
On 15-12-21, 06:29, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Vinod Koul <vkoul@kernel.org>
> > Sent: Wednesday, December 15, 2021 2:09 PM
> > To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> > <hongxing.zhu@nxp.com>
> > Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > kernel test robot <lkp@intel.com>
> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> >
> > kernel test robot complains about missing FIELD_PREP, so include
> > bitfield.h for that
> >
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> > standalone phy driver")
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks for quick review, I have pushed this
> Thanks a lot for your help to fix it.
> And I'm sorry about that I didn't capture this error in my local build and tests.
No worries, Do test on different arch's other than yours
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] phy: freescale: pcie: explictly add bitfield.h
@ 2021-12-15 15:21 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2021-12-15 15:21 UTC (permalink / raw)
To: Hongxing Zhu
Cc: Kishon Vijay Abraham I, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot
On 15-12-21, 06:29, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Vinod Koul <vkoul@kernel.org>
> > Sent: Wednesday, December 15, 2021 2:09 PM
> > To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> > <hongxing.zhu@nxp.com>
> > Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > kernel test robot <lkp@intel.com>
> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> >
> > kernel test robot complains about missing FIELD_PREP, so include
> > bitfield.h for that
> >
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> > standalone phy driver")
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks for quick review, I have pushed this
> Thanks a lot for your help to fix it.
> And I'm sorry about that I didn't capture this error in my local build and tests.
No worries, Do test on different arch's other than yours
--
~Vinod
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] phy: freescale: pcie: explictly add bitfield.h
@ 2021-12-15 15:21 ` Vinod Koul
0 siblings, 0 replies; 9+ messages in thread
From: Vinod Koul @ 2021-12-15 15:21 UTC (permalink / raw)
To: Hongxing Zhu
Cc: Kishon Vijay Abraham I, linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot
On 15-12-21, 06:29, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Vinod Koul <vkoul@kernel.org>
> > Sent: Wednesday, December 15, 2021 2:09 PM
> > To: Kishon Vijay Abraham I <kishon@ti.com>; Hongxing Zhu
> > <hongxing.zhu@nxp.com>
> > Cc: linux-phy@lists.infradead.org; Vinod Koul <vkoul@kernel.org>;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > kernel test robot <lkp@intel.com>
> > Subject: [PATCH] phy: freescale: pcie: explictly add bitfield.h
> >
> > kernel test robot complains about missing FIELD_PREP, so include
> > bitfield.h for that
> >
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> > drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:41: error: implicit
> > declaration of function 'FIELD_PREP'
> > [-Werror=implicit-function-declaration]
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie
> > standalone phy driver")
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks for quick review, I have pushed this
> Thanks a lot for your help to fix it.
> And I'm sorry about that I didn't capture this error in my local build and tests.
No worries, Do test on different arch's other than yours
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-12-15 16:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-15 6:08 [PATCH] phy: freescale: pcie: explictly add bitfield.h Vinod Koul
2021-12-15 6:08 ` Vinod Koul
2021-12-15 6:08 ` Vinod Koul
2021-12-15 6:29 ` Hongxing Zhu
2021-12-15 6:29 ` Hongxing Zhu
2021-12-15 6:29 ` Hongxing Zhu
2021-12-15 15:21 ` Vinod Koul
2021-12-15 15:21 ` Vinod Koul
2021-12-15 15:21 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.