All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Vladimir Davydov
	<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] mm/memcontrol: Disable on PREEMPT_RT
Date: Wed, 15 Dec 2021 17:47:54 +0100	[thread overview]
Message-ID: <YbocOh+h3o/Yc5Ag@linutronix.de> (raw)
In-Reply-To: <YbcbmvQk+Sgdsi9G-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>

On 2021-12-13 11:08:26 [+0100], Michal Hocko wrote:
> On Fri 10-12-21 16:22:01, Sebastian Andrzej Siewior wrote:
> [...]
> I am sorry but I didn't get to read and digest the rest of the message
> yet. Let me just point out this
> 
> > The problematic part here is mem_cgroup_tree_per_node::lock which can
> > not be acquired with disabled interrupts on PREEMPT_RT.  The "locking
> > scope" is not always clear to me.  Also, if it is _just_ the counter,
> > then we might solve this differently.
> 
> I do not think you should be losing sleep over soft limit reclaim. This
> is certainly not something to be used for RT workloads and rather than
> touching that code I think it makes some sense to simply disallow soft
> limit with RT enabled (i.e. do not allow to set any soft limit).

Okay. So instead of disabling it entirely you suggest I should take
another stab at it? Okay. Disabling softlimit, where should I start with
it? Should mem_cgroup_write() for RES_SOFT_LIMIT always return an error
or something else?
In the meantime I try to swap in my memcg memory…

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Waiman Long <longman@redhat.com>
Subject: Re: [PATCH] mm/memcontrol: Disable on PREEMPT_RT
Date: Wed, 15 Dec 2021 17:47:54 +0100	[thread overview]
Message-ID: <YbocOh+h3o/Yc5Ag@linutronix.de> (raw)
In-Reply-To: <YbcbmvQk+Sgdsi9G@dhcp22.suse.cz>

On 2021-12-13 11:08:26 [+0100], Michal Hocko wrote:
> On Fri 10-12-21 16:22:01, Sebastian Andrzej Siewior wrote:
> [...]
> I am sorry but I didn't get to read and digest the rest of the message
> yet. Let me just point out this
> 
> > The problematic part here is mem_cgroup_tree_per_node::lock which can
> > not be acquired with disabled interrupts on PREEMPT_RT.  The "locking
> > scope" is not always clear to me.  Also, if it is _just_ the counter,
> > then we might solve this differently.
> 
> I do not think you should be losing sleep over soft limit reclaim. This
> is certainly not something to be used for RT workloads and rather than
> touching that code I think it makes some sense to simply disallow soft
> limit with RT enabled (i.e. do not allow to set any soft limit).

Okay. So instead of disabling it entirely you suggest I should take
another stab at it? Okay. Disabling softlimit, where should I start with
it? Should mem_cgroup_write() for RES_SOFT_LIMIT always return an error
or something else?
In the meantime I try to swap in my memcg memory…

Sebastian


  parent reply	other threads:[~2021-12-15 16:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 15:52 [PATCH] mm/memcontrol: Disable on PREEMPT_RT Sebastian Andrzej Siewior
2021-12-07 15:52 ` Sebastian Andrzej Siewior
     [not found] ` <20211207155208.eyre5svucpg7krxe-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2021-12-07 16:00   ` Waiman Long
2021-12-07 16:00     ` Waiman Long
2021-12-07 16:55   ` Johannes Weiner
2021-12-07 16:55     ` Johannes Weiner
     [not found]     ` <Ya+SCkLOLBVN/kiY-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2021-12-10 15:22       ` Sebastian Andrzej Siewior
2021-12-10 15:22         ` Sebastian Andrzej Siewior
     [not found]         ` <YbNwmUMPFM/MO0cX-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2021-12-13 10:08           ` Michal Hocko
2021-12-13 10:08             ` Michal Hocko
     [not found]             ` <YbcbmvQk+Sgdsi9G-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-12-15 16:47               ` Sebastian Andrzej Siewior [this message]
2021-12-15 16:47                 ` Sebastian Andrzej Siewior
     [not found]                 ` <YbocOh+h3o/Yc5Ag-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2021-12-15 16:56                   ` Michal Hocko
2021-12-15 16:56                     ` Michal Hocko
     [not found]                     ` <YboeI1aTFdQpN0TI-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-12-15 17:13                       ` Sebastian Andrzej Siewior
2021-12-15 17:13                         ` Sebastian Andrzej Siewior
     [not found]                         ` <YboiRA1znig/cbCt-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2021-12-15 18:44                           ` Michal Hocko
2021-12-15 18:44                             ` Michal Hocko
     [not found]                             ` <Ybo3cAkyg0SrUyJJ-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2021-12-16  7:51                               ` Sebastian Andrzej Siewior
2021-12-16  7:51                                 ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YbocOh+h3o/Yc5Ag@linutronix.de \
    --to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
    --cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=mhocko-IBi9RG/b67k@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.