From: Tejun Heo <tj@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: daniel@iogearbox.net, ast@kernel.org, andrii@kernel.org,
bpf@vger.kernel.org, kafai@fb.com, songliubraving@fb.com,
yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
lizefan.x@bytedance.com, hannes@cmpxchg.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH bpf-next v4 3/3] bpf: remove the cgroup -> bpf header dependecy
Date: Wed, 15 Dec 2021 08:28:39 -1000 [thread overview]
Message-ID: <Yboz17Cd3NrdircO@slm.duckdns.org> (raw)
In-Reply-To: <20211215181231.1053479-4-kuba@kernel.org>
On Wed, Dec 15, 2021 at 10:12:31AM -0800, Jakub Kicinski wrote:
> Remove the dependency from cgroup-defs.h to bpf-cgroup.h and bpf.h.
> This reduces the incremental build size of x86 allmodconfig after
> bpf.h was touched from ~17k objects rebuilt to ~5k objects.
> bpf.h is 2.2kLoC and is modified relatively often.
>
> We need a new header with just the definition of struct cgroup_bpf
> and enum cgroup_bpf_attach_type, this is akin to cgroup-defs.h.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org,
ast-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
andrii-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
bpf-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kafai-b10kYP2dOMg@public.gmane.org,
songliubraving-b10kYP2dOMg@public.gmane.org,
yhs-b10kYP2dOMg@public.gmane.org,
john.fastabend-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
kpsingh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH bpf-next v4 3/3] bpf: remove the cgroup -> bpf header dependecy
Date: Wed, 15 Dec 2021 08:28:39 -1000 [thread overview]
Message-ID: <Yboz17Cd3NrdircO@slm.duckdns.org> (raw)
In-Reply-To: <20211215181231.1053479-4-kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Wed, Dec 15, 2021 at 10:12:31AM -0800, Jakub Kicinski wrote:
> Remove the dependency from cgroup-defs.h to bpf-cgroup.h and bpf.h.
> This reduces the incremental build size of x86 allmodconfig after
> bpf.h was touched from ~17k objects rebuilt to ~5k objects.
> bpf.h is 2.2kLoC and is modified relatively often.
>
> We need a new header with just the definition of struct cgroup_bpf
> and enum cgroup_bpf_attach_type, this is akin to cgroup-defs.h.
>
> Signed-off-by: Jakub Kicinski <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2021-12-15 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 18:12 [PATCH bpf-next v4 0/3] bpf: remove the cgroup -> bpf header dependecy Jakub Kicinski
2021-12-15 18:12 ` [PATCH bpf-next v4 1/3] add includes masked by cgroup -> bpf dependency Jakub Kicinski
2021-12-15 18:12 ` [PATCH bpf-next v4 2/3] add missing bpf-cgroup.h includes Jakub Kicinski
2021-12-15 18:28 ` Tejun Heo
2021-12-15 18:12 ` [PATCH bpf-next v4 3/3] bpf: remove the cgroup -> bpf header dependecy Jakub Kicinski
2021-12-15 18:12 ` Jakub Kicinski
2021-12-15 18:28 ` Tejun Heo [this message]
2021-12-15 18:28 ` Tejun Heo
2021-12-15 23:07 ` kernel test robot
2021-12-15 23:59 ` kernel test robot
2021-12-15 19:47 ` [PATCH bpf-next v4 0/3] " Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yboz17Cd3NrdircO@slm.duckdns.org \
--to=tj@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.