From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org, Agneli <poczt@protonmail.ch>,
linux-tegra@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v4 06/22] ASoC: tegra20-spdif: stop setting slave_id
Date: Thu, 16 Dec 2021 16:16:38 +0100 [thread overview]
Message-ID: <YbtYVss3y8lgK1Z3@orome> (raw)
In-Reply-To: <20211204143725.31646-7-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On Sat, Dec 04, 2021 at 05:37:09PM +0300, Dmitry Osipenko wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The DMA resource is never set up anywhere, and passing this as slave_id
> has not been the proper procedure in a long time.
>
> As a preparation for removing all slave_id references from the ALSA code,
> remove this one.
>
> According to Dmitry Osipenko, this driver has never been used and
> the mechanism for configuring DMA would not work as it is implemented,
> so this part will get rewritten when the driver gets put into use
> again in the future.
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/tegra/tegra20_spdif.c | 1 -
> 1 file changed, 1 deletion(-)
In case you want to pick this up into the ASoC tree and Vinod removes it
from the DMA tree:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>, Agneli <poczt@protonmail.ch>,
linux-tegra@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 06/22] ASoC: tegra20-spdif: stop setting slave_id
Date: Thu, 16 Dec 2021 16:16:38 +0100 [thread overview]
Message-ID: <YbtYVss3y8lgK1Z3@orome> (raw)
In-Reply-To: <20211204143725.31646-7-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On Sat, Dec 04, 2021 at 05:37:09PM +0300, Dmitry Osipenko wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The DMA resource is never set up anywhere, and passing this as slave_id
> has not been the proper procedure in a long time.
>
> As a preparation for removing all slave_id references from the ALSA code,
> remove this one.
>
> According to Dmitry Osipenko, this driver has never been used and
> the mechanism for configuring DMA would not work as it is implemented,
> so this part will get rewritten when the driver gets put into use
> again in the future.
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/tegra/tegra20_spdif.c | 1 -
> 1 file changed, 1 deletion(-)
In case you want to pick this up into the ASoC tree and Vinod removes it
from the DMA tree:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
dri-devel@lists.freedesktop.org, Agneli <poczt@protonmail.ch>,
linux-tegra@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH v4 06/22] ASoC: tegra20-spdif: stop setting slave_id
Date: Thu, 16 Dec 2021 16:16:38 +0100 [thread overview]
Message-ID: <YbtYVss3y8lgK1Z3@orome> (raw)
In-Reply-To: <20211204143725.31646-7-digetx@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
On Sat, Dec 04, 2021 at 05:37:09PM +0300, Dmitry Osipenko wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The DMA resource is never set up anywhere, and passing this as slave_id
> has not been the proper procedure in a long time.
>
> As a preparation for removing all slave_id references from the ALSA code,
> remove this one.
>
> According to Dmitry Osipenko, this driver has never been used and
> the mechanism for configuring DMA would not work as it is implemented,
> so this part will get rewritten when the driver gets put into use
> again in the future.
>
> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/tegra/tegra20_spdif.c | 1 -
> 1 file changed, 1 deletion(-)
In case you want to pick this up into the ASoC tree and Vinod removes it
from the DMA tree:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-16 15:17 UTC|newest]
Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 14:37 [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20 Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 01/22] ASoC: dt-bindings: Add binding for Tegra20 S/PDIF Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 13:56 ` Thierry Reding
2021-12-16 13:56 ` Thierry Reding
2021-12-16 13:56 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 02/22] ASoC: dt-bindings: tegra20-i2s: Convert to schema Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 13:59 ` Thierry Reding
2021-12-16 13:59 ` Thierry Reding
2021-12-16 13:59 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 03/22] ASoC: dt-bindings: tegra20-i2s: Document new nvidia, fixed-parent-rate property Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 03/22] ASoC: dt-bindings: tegra20-i2s: Document new nvidia,fixed-parent-rate property Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 04/22] dt-bindings: host1x: Document optional HDMI sound-dai-cells Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 14:20 ` Thierry Reding
2021-12-16 14:20 ` Thierry Reding
2021-12-16 14:20 ` Thierry Reding
2021-12-17 11:12 ` Mark Brown
2021-12-17 11:12 ` Mark Brown
2021-12-17 11:12 ` Mark Brown
2021-12-17 11:55 ` Dmitry Osipenko
2021-12-17 11:55 ` Dmitry Osipenko
2021-12-17 11:55 ` Dmitry Osipenko
2021-12-17 12:02 ` Thierry Reding
2021-12-17 12:02 ` Thierry Reding
2021-12-17 12:02 ` Thierry Reding
2021-12-17 12:06 ` Dmitry Osipenko
2021-12-17 12:06 ` Dmitry Osipenko
2021-12-17 12:06 ` Dmitry Osipenko
2021-12-17 17:18 ` Dmitry Osipenko
2021-12-17 17:18 ` Dmitry Osipenko
2021-12-17 17:18 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 05/22] ASoC: tegra20: spdif: Set FIFO trigger level Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:15 ` Thierry Reding
2021-12-16 15:15 ` Thierry Reding
2021-12-16 15:15 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 06/22] ASoC: tegra20-spdif: stop setting slave_id Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:16 ` Thierry Reding [this message]
2021-12-16 15:16 ` Thierry Reding
2021-12-16 15:16 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 07/22] ASoC: tegra20: spdif: Support device-tree Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:17 ` Thierry Reding
2021-12-16 15:17 ` Thierry Reding
2021-12-16 15:17 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 08/22] ASoC: tegra20: spdif: Improve driver's code Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:18 ` Thierry Reding
2021-12-16 15:18 ` Thierry Reding
2021-12-16 15:18 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 09/22] ASoC: tegra20: spdif: Use more resource-managed helpers Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:21 ` Thierry Reding
2021-12-16 15:21 ` Thierry Reding
2021-12-16 15:21 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 10/22] ASoC: tegra20: spdif: Reset hardware Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:22 ` Thierry Reding
2021-12-16 15:22 ` Thierry Reding
2021-12-16 15:22 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 11/22] ASoC: tegra20: spdif: Support system suspend Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:22 ` Thierry Reding
2021-12-16 15:22 ` Thierry Reding
2021-12-16 15:22 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 12/22] ASoC: tegra20: spdif: Filter out unsupported rates Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:30 ` Thierry Reding
2021-12-16 15:30 ` Thierry Reding
2021-12-16 15:30 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 13/22] ASoC: tegra20: i2s: " Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 15:31 ` Thierry Reding
2021-12-16 15:31 ` Thierry Reding
2021-12-16 15:31 ` Thierry Reding
2021-12-04 14:37 ` [PATCH v4 14/22] drm/tegra: hdmi: Unwind tegra_hdmi_init() errors Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 15/22] drm/tegra: hdmi: Register audio CODEC on Tegra20 Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 16/22] ARM: tegra_defconfig: Enable S/PDIF driver Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 17/22] ARM: config: multi v7: Enable NVIDIA Tegra20 " Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 18/22] ARM: config: multi v7: Enable NVIDIA Tegra20 APB DMA driver Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 19/22] ARM: tegra: Add S/PDIF node to Tegra20 device-tree Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 20/22] ARM: tegra: Add HDMI audio graph " Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-16 13:46 ` Thierry Reding
2021-12-16 13:46 ` Thierry Reding
2021-12-16 13:46 ` Thierry Reding
2021-12-16 14:24 ` Dmitry Osipenko
2021-12-16 14:24 ` Dmitry Osipenko
2021-12-16 14:24 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 21/22] ARM: tegra: acer-a500: Enable S/PDIF and HDMI audio Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-04 14:37 ` [PATCH v4 22/22] ARM: tegra: paz00: " Dmitry Osipenko
2021-12-04 14:37 ` Dmitry Osipenko
2021-12-15 18:57 ` [PATCH v4 00/22] Support HDMI audio on NVIDIA Tegra20 Mark Brown
2021-12-15 18:57 ` Mark Brown
2021-12-15 18:57 ` Mark Brown
2021-12-15 19:19 ` Dmitry Osipenko
2021-12-15 19:19 ` Dmitry Osipenko
2021-12-15 19:19 ` Dmitry Osipenko
2021-12-15 19:58 ` Mark Brown
2021-12-15 19:58 ` Mark Brown
2021-12-15 19:58 ` Mark Brown
2021-12-16 13:55 ` Thierry Reding
2021-12-16 13:55 ` Thierry Reding
2021-12-16 13:55 ` Thierry Reding
2021-12-16 15:09 ` Dmitry Osipenko
2021-12-16 15:09 ` Dmitry Osipenko
2021-12-16 15:09 ` Dmitry Osipenko
2021-12-16 14:29 ` Dmitry Osipenko
2021-12-16 14:29 ` Dmitry Osipenko
2021-12-16 14:29 ` Dmitry Osipenko
2021-12-17 6:04 ` Vinod Koul
2021-12-17 6:04 ` Vinod Koul
2021-12-17 6:04 ` Vinod Koul
2021-12-17 12:06 ` Dmitry Osipenko
2021-12-17 12:06 ` Dmitry Osipenko
2021-12-17 12:06 ` Dmitry Osipenko
2021-12-21 2:50 ` (subset) " Mark Brown
2021-12-21 2:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbtYVss3y8lgK1Z3@orome \
--to=thierry.reding@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=poczt@protonmail.ch \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.