From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v1 1/1] serial: 8520_mtk: Prepare for platform_get_irq_optional() changes
Date: Fri, 17 Dec 2021 17:54:55 +0100 [thread overview]
Message-ID: <YbzA3y5jp5K5zL/+@kroah.com> (raw)
In-Reply-To: <20211217151034.62046-1-andriy.shevchenko@linux.intel.com>
On Fri, Dec 17, 2021 at 05:10:34PM +0200, Andy Shevchenko wrote:
> The platform_get_irq_optional() is going to be changed in a way
> that the result of it:
> = 0 means no IRQ is provided
> < 0 means the error which needs to be propagated to the upper layers
> > 0 valid vIRQ is allocated
What about 0 being a valid irq?
> In this case, drop check for 0. Note, the 0 is not valid vIRQ and
> platform_get_irq_optional() issues a big WARN() in such case,
But it still is a valid irq, so why did you just break things? Yes, a
warning will happen, but the driver and platform will still work.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index fb65dc601b23..8d3e16d7bf63 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -641,7 +641,7 @@ static int __maybe_unused mtk8250_resume(struct device *dev)
> struct mtk8250_data *data = dev_get_drvdata(dev);
> int irq = data->rx_wakeup_irq;
>
> - if (irq >= 0)
> + if (irq > 0)
> disable_irq_wake(irq);
Why change this now? What does this solve at this point in time?
thanks,
greg k-h
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v1 1/1] serial: 8520_mtk: Prepare for platform_get_irq_optional() changes
Date: Fri, 17 Dec 2021 17:54:55 +0100 [thread overview]
Message-ID: <YbzA3y5jp5K5zL/+@kroah.com> (raw)
In-Reply-To: <20211217151034.62046-1-andriy.shevchenko@linux.intel.com>
On Fri, Dec 17, 2021 at 05:10:34PM +0200, Andy Shevchenko wrote:
> The platform_get_irq_optional() is going to be changed in a way
> that the result of it:
> = 0 means no IRQ is provided
> < 0 means the error which needs to be propagated to the upper layers
> > 0 valid vIRQ is allocated
What about 0 being a valid irq?
> In this case, drop check for 0. Note, the 0 is not valid vIRQ and
> platform_get_irq_optional() issues a big WARN() in such case,
But it still is a valid irq, so why did you just break things? Yes, a
warning will happen, but the driver and platform will still work.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index fb65dc601b23..8d3e16d7bf63 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -641,7 +641,7 @@ static int __maybe_unused mtk8250_resume(struct device *dev)
> struct mtk8250_data *data = dev_get_drvdata(dev);
> int irq = data->rx_wakeup_irq;
>
> - if (irq >= 0)
> + if (irq > 0)
> disable_irq_wake(irq);
Why change this now? What does this solve at this point in time?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Zhiyong Tao <zhiyong.tao@mediatek.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v1 1/1] serial: 8520_mtk: Prepare for platform_get_irq_optional() changes
Date: Fri, 17 Dec 2021 17:54:55 +0100 [thread overview]
Message-ID: <YbzA3y5jp5K5zL/+@kroah.com> (raw)
In-Reply-To: <20211217151034.62046-1-andriy.shevchenko@linux.intel.com>
On Fri, Dec 17, 2021 at 05:10:34PM +0200, Andy Shevchenko wrote:
> The platform_get_irq_optional() is going to be changed in a way
> that the result of it:
> = 0 means no IRQ is provided
> < 0 means the error which needs to be propagated to the upper layers
> > 0 valid vIRQ is allocated
What about 0 being a valid irq?
> In this case, drop check for 0. Note, the 0 is not valid vIRQ and
> platform_get_irq_optional() issues a big WARN() in such case,
But it still is a valid irq, so why did you just break things? Yes, a
warning will happen, but the driver and platform will still work.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index fb65dc601b23..8d3e16d7bf63 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -641,7 +641,7 @@ static int __maybe_unused mtk8250_resume(struct device *dev)
> struct mtk8250_data *data = dev_get_drvdata(dev);
> int irq = data->rx_wakeup_irq;
>
> - if (irq >= 0)
> + if (irq > 0)
> disable_irq_wake(irq);
Why change this now? What does this solve at this point in time?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-17 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 15:10 [PATCH v1 1/1] serial: 8520_mtk: Prepare for platform_get_irq_optional() changes Andy Shevchenko
2021-12-17 15:10 ` Andy Shevchenko
2021-12-17 15:10 ` Andy Shevchenko
2021-12-17 16:54 ` Greg Kroah-Hartman [this message]
2021-12-17 16:54 ` Greg Kroah-Hartman
2021-12-17 16:54 ` Greg Kroah-Hartman
2021-12-17 18:09 ` Andy Shevchenko
2021-12-17 18:09 ` Andy Shevchenko
2021-12-17 18:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbzA3y5jp5K5zL/+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.