From: Al Viro <viro@zeniv.linux.org.uk>
To: Richard Weinberger <richard@nod.at>
Cc: hch <hch@lst.de>, anton ivanov <anton.ivanov@cambridgegreys.com>,
x86 <x86@kernel.org>, linux-um <linux-um@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: remove set_fs for UML
Date: Sat, 1 Jan 2022 00:12:24 +0000 [thread overview]
Message-ID: <Yc+caOi47BbzlPw6@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <1202521211.191037.1640120703350.JavaMail.zimbra@nod.at>
On Tue, Dec 21, 2021 at 10:05:03PM +0100, Richard Weinberger wrote:
> Christoph,
>
> ----- Ursprüngliche Mail -----
> > Von: "hch" <hch@lst.de>
> > An: "richard" <richard@nod.at>, "anton ivanov" <anton.ivanov@cambridgegreys.com>
> > CC: "x86" <x86@kernel.org>, "linux-um" <linux-um@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>
> > Gesendet: Mittwoch, 15. Dezember 2021 17:56:10
> > Betreff: remove set_fs for UML
>
> > Hi Richard and Anton,
> >
> > this series removes address space overrides using set_fs for UML.
> >
> > Diffstat:
> > um/Kconfig | 1 -
> > um/include/asm/thread_info.h | 4 ----
> > um/include/asm/uaccess.h | 21 +++++++++++++++++++--
> > um/kernel/skas/uaccess.c | 25 -------------------------
> > x86/include/asm/mtrr.h | 8 +-------
> > x86/kernel/setup.c | 7 ++++++-
> > x86/um/asm/segment.h | 8 --------
> > 7 files changed, 26 insertions(+), 48 deletions(-)
>
> So far UML seems to work with these changes applied. :-)
> I have applied both patches to my UML tree for now, I assume x86 maintainers are fine with
> patch 1/2?
Hmmm... AFAICS, the right thing to do would be to have __get_kernel_nofault
and __put_kernel_nofault in arch/x86/um/asm/something. The question is how
to avoid duplicating the x86 implementation of those (along with the asm-goto
fun, etc.)...
But Christoph is right, it's not a new problem. As far as I'm concerned,
that series looks fine.
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@zeniv.linux.org.uk>
To: Richard Weinberger <richard@nod.at>
Cc: hch <hch@lst.de>, anton ivanov <anton.ivanov@cambridgegreys.com>,
x86 <x86@kernel.org>, linux-um <linux-um@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: remove set_fs for UML
Date: Sat, 1 Jan 2022 00:12:24 +0000 [thread overview]
Message-ID: <Yc+caOi47BbzlPw6@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <1202521211.191037.1640120703350.JavaMail.zimbra@nod.at>
On Tue, Dec 21, 2021 at 10:05:03PM +0100, Richard Weinberger wrote:
> Christoph,
>
> ----- Ursprüngliche Mail -----
> > Von: "hch" <hch@lst.de>
> > An: "richard" <richard@nod.at>, "anton ivanov" <anton.ivanov@cambridgegreys.com>
> > CC: "x86" <x86@kernel.org>, "linux-um" <linux-um@lists.infradead.org>, "linux-kernel" <linux-kernel@vger.kernel.org>
> > Gesendet: Mittwoch, 15. Dezember 2021 17:56:10
> > Betreff: remove set_fs for UML
>
> > Hi Richard and Anton,
> >
> > this series removes address space overrides using set_fs for UML.
> >
> > Diffstat:
> > um/Kconfig | 1 -
> > um/include/asm/thread_info.h | 4 ----
> > um/include/asm/uaccess.h | 21 +++++++++++++++++++--
> > um/kernel/skas/uaccess.c | 25 -------------------------
> > x86/include/asm/mtrr.h | 8 +-------
> > x86/kernel/setup.c | 7 ++++++-
> > x86/um/asm/segment.h | 8 --------
> > 7 files changed, 26 insertions(+), 48 deletions(-)
>
> So far UML seems to work with these changes applied. :-)
> I have applied both patches to my UML tree for now, I assume x86 maintainers are fine with
> patch 1/2?
Hmmm... AFAICS, the right thing to do would be to have __get_kernel_nofault
and __put_kernel_nofault in arch/x86/um/asm/something. The question is how
to avoid duplicating the x86 implementation of those (along with the asm-goto
fun, etc.)...
But Christoph is right, it's not a new problem. As far as I'm concerned,
that series looks fine.
next prev parent reply other threads:[~2022-01-01 0:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 16:56 remove set_fs for UML Christoph Hellwig
2021-12-15 16:56 ` Christoph Hellwig
2021-12-15 16:56 ` [PATCH 1/2] x86/mtrr: remove the mtrr_bp_init stub Christoph Hellwig
2021-12-15 16:56 ` Christoph Hellwig
2021-12-22 18:56 ` [tip: x86/misc] x86/mtrr: Remove the mtrr_bp_init() stub tip-bot2 for Christoph Hellwig
2021-12-15 16:56 ` [PATCH 2/2] um: remove set_fs Christoph Hellwig
2021-12-15 16:56 ` Christoph Hellwig
2021-12-21 21:05 ` remove set_fs for UML Richard Weinberger
2021-12-21 21:05 ` Richard Weinberger
2021-12-22 8:17 ` hch
2021-12-22 8:17 ` hch
2021-12-22 13:55 ` Borislav Petkov
2021-12-22 13:55 ` Borislav Petkov
2021-12-22 16:55 ` Richard Weinberger
2021-12-22 16:55 ` Richard Weinberger
2021-12-22 18:54 ` Borislav Petkov
2021-12-22 18:54 ` Borislav Petkov
2022-01-01 0:12 ` Al Viro [this message]
2022-01-01 0:12 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yc+caOi47BbzlPw6@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anton.ivanov@cambridgegreys.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.