All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: linux-staging@lists.linux.dev, nsaenz@kernel.org,
	f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com,
	juerg.haefliger@canonical.com, rdunlap@infradead.org,
	dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com,
	unixbhaskar@gmail.com, mitaliborkar810@gmail.com,
	phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] staging: vc04_services: avoid the use of typedef for function pointers
Date: Thu, 30 Dec 2021 14:20:14 +0100	[thread overview]
Message-ID: <Yc2yDsMg2D6GZe+T@kroah.com> (raw)
In-Reply-To: <cover.1640776340.git.gascoar@gmail.com>

On Thu, Dec 30, 2021 at 08:31:23AM -0300, Gaston Gonzalez wrote:
> This patch set removes some typedefs for function pointers in vc04_services.
> 
> v1 -> v2:
> 
> - Following Greg suggestion, functions pointers were not renamed making patches
>   1 and 2 much smaller.
> - Function pointers in vchiq-mmal were not touched as the result is less
>   readable than the original.
> - In the description of changes in the TODO file, it was specified that there
>   are no current 'struct typedefs' left inside vc04_servivces. 
> - The name of the particular subsystem of vc04_services was included in the
>   title of each commit.

Much nicer, thanks for redoing this.  Now queued up.

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: linux-staging@lists.linux.dev, nsaenz@kernel.org,
	f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com,
	juerg.haefliger@canonical.com, rdunlap@infradead.org,
	dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com,
	unixbhaskar@gmail.com, mitaliborkar810@gmail.com,
	phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] staging: vc04_services: avoid the use of typedef for function pointers
Date: Thu, 30 Dec 2021 14:20:14 +0100	[thread overview]
Message-ID: <Yc2yDsMg2D6GZe+T@kroah.com> (raw)
In-Reply-To: <cover.1640776340.git.gascoar@gmail.com>

On Thu, Dec 30, 2021 at 08:31:23AM -0300, Gaston Gonzalez wrote:
> This patch set removes some typedefs for function pointers in vc04_services.
> 
> v1 -> v2:
> 
> - Following Greg suggestion, functions pointers were not renamed making patches
>   1 and 2 much smaller.
> - Function pointers in vchiq-mmal were not touched as the result is less
>   readable than the original.
> - In the description of changes in the TODO file, it was specified that there
>   are no current 'struct typedefs' left inside vc04_servivces. 
> - The name of the particular subsystem of vc04_services was included in the
>   title of each commit.

Much nicer, thanks for redoing this.  Now queued up.

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-12-30 13:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 11:31 [PATCH v2 0/3] staging: vc04_services: avoid the use of typedef for function pointers Gaston Gonzalez
2021-12-30 11:31 ` Gaston Gonzalez
2021-12-30 11:31 ` [PATCH v2 1/3] staging: vc04_services: bcm2835-audio: " Gaston Gonzalez
2021-12-30 11:31   ` Gaston Gonzalez
2021-12-30 11:31 ` [PATCH v2 2/3] staging: vc04_services: bcm2835-camera: " Gaston Gonzalez
2021-12-30 11:31   ` Gaston Gonzalez
2021-12-30 11:31 ` [PATCH v2 3/3] staging: vc04_services: update TODO file Gaston Gonzalez
2021-12-30 11:31   ` Gaston Gonzalez
2022-01-06 12:51   ` Dan Carpenter
2022-01-06 12:51     ` Dan Carpenter
2021-12-30 13:20 ` Greg KH [this message]
2021-12-30 13:20   ` [PATCH v2 0/3] staging: vc04_services: avoid the use of typedef for function pointers Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yc2yDsMg2D6GZe+T@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=f.fainelli@gmail.com \
    --cc=gascoar@gmail.com \
    --cc=juerg.haefliger@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mitaliborkar810@gmail.com \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=rdunlap@infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    --cc=unixbhaskar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.