All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yu Tu <yu.tu@amlogic.com>
Cc: linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	Jiri Slaby <jirislaby@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH 2/3] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit
Date: Tue, 21 Dec 2021 08:32:02 +0100	[thread overview]
Message-ID: <YcGC8hlOEbzH8rc8@kroah.com> (raw)
In-Reply-To: <20211221071634.25980-3-yu.tu@amlogic.com>

On Tue, Dec 21, 2021 at 03:16:33PM +0800, Yu Tu wrote:
> The meson_uart_shutdown function should have the opposite operation to
> the meson_uart_startup function, so the shutdown of AML_UART_TX_EN is
> logically missing.
> 
> Signed-off-by: Yu Tu <yu.tu@amlogic.com>

What commit does this fix?  Should it go to stable kernels?  Please put
that in here if needed.

thanks,

greg k-h

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yu Tu <yu.tu@amlogic.com>
Cc: linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	Jiri Slaby <jirislaby@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH 2/3] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit
Date: Tue, 21 Dec 2021 08:32:02 +0100	[thread overview]
Message-ID: <YcGC8hlOEbzH8rc8@kroah.com> (raw)
In-Reply-To: <20211221071634.25980-3-yu.tu@amlogic.com>

On Tue, Dec 21, 2021 at 03:16:33PM +0800, Yu Tu wrote:
> The meson_uart_shutdown function should have the opposite operation to
> the meson_uart_startup function, so the shutdown of AML_UART_TX_EN is
> logically missing.
> 
> Signed-off-by: Yu Tu <yu.tu@amlogic.com>

What commit does this fix?  Should it go to stable kernels?  Please put
that in here if needed.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yu Tu <yu.tu@amlogic.com>
Cc: linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	Jiri Slaby <jirislaby@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH 2/3] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit
Date: Tue, 21 Dec 2021 08:32:02 +0100	[thread overview]
Message-ID: <YcGC8hlOEbzH8rc8@kroah.com> (raw)
In-Reply-To: <20211221071634.25980-3-yu.tu@amlogic.com>

On Tue, Dec 21, 2021 at 03:16:33PM +0800, Yu Tu wrote:
> The meson_uart_shutdown function should have the opposite operation to
> the meson_uart_startup function, so the shutdown of AML_UART_TX_EN is
> logically missing.
> 
> Signed-off-by: Yu Tu <yu.tu@amlogic.com>

What commit does this fix?  Should it go to stable kernels?  Please put
that in here if needed.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-21  7:32 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21  7:16 [PATCH 0/3] the UART driver compatible with the Amlogic Meson S4 SoC Yu Tu
2021-12-21  7:16 ` Yu Tu
2021-12-21  7:16 ` Yu Tu
2021-12-21  7:16 ` [PATCH 1/3] tty: serial: meson: modify request_irq and free_irq Yu Tu
2021-12-21  7:16   ` Yu Tu
2021-12-21  7:16   ` Yu Tu
2021-12-21  7:30   ` Greg Kroah-Hartman
2021-12-21  7:30     ` Greg Kroah-Hartman
2021-12-21  7:30     ` Greg Kroah-Hartman
2021-12-22  8:44     ` Yu Tu
2021-12-22  8:44       ` Yu Tu
2021-12-22  8:44       ` Yu Tu
2021-12-21  7:16 ` [PATCH 2/3] tty: serial: meson: meson_uart_shutdown omit clear AML_UART_TX_EN bit Yu Tu
2021-12-21  7:16   ` Yu Tu
2021-12-21  7:16   ` Yu Tu
2021-12-21  7:32   ` Greg Kroah-Hartman [this message]
2021-12-21  7:32     ` Greg Kroah-Hartman
2021-12-21  7:32     ` Greg Kroah-Hartman
2021-12-22  9:01     ` Yu Tu
2021-12-22  9:01       ` Yu Tu
2021-12-22  9:01       ` Yu Tu
2021-12-21  7:16 ` [PATCH 3/3] tty: serial: meson: add UART driver compatible with S4 SoC on-chip Yu Tu
2021-12-21  7:16   ` Yu Tu
2021-12-21  7:16   ` Yu Tu
2021-12-21  7:34   ` Greg Kroah-Hartman
2021-12-21  7:34     ` Greg Kroah-Hartman
2021-12-21  7:34     ` Greg Kroah-Hartman
2021-12-22  9:28     ` Yu Tu
2021-12-22  9:28       ` Yu Tu
2021-12-22  9:28       ` Yu Tu
2021-12-24 17:25   ` Martin Blumenstingl
2021-12-24 17:25     ` Martin Blumenstingl
2021-12-24 17:25     ` Martin Blumenstingl
2021-12-27  6:56     ` Yu Tu
2021-12-27  6:56       ` Yu Tu
2021-12-27  6:56       ` Yu Tu
2021-12-27 11:58       ` Jerome Brunet
2021-12-27 11:58         ` Jerome Brunet
2021-12-27 11:58         ` Jerome Brunet
2021-12-27 20:04       ` Martin Blumenstingl
2021-12-27 20:04         ` Martin Blumenstingl
2021-12-27 20:04         ` Martin Blumenstingl
2021-12-28 11:24         ` Yu Tu
2021-12-28 11:24           ` Yu Tu
2021-12-28 11:24           ` Yu Tu
2021-12-21  7:30 ` [PATCH 0/3] the UART driver compatible with the Amlogic Meson S4 SoC Greg Kroah-Hartman
2021-12-21  7:30   ` Greg Kroah-Hartman
2021-12-21  7:30   ` Greg Kroah-Hartman
2021-12-22  8:19   ` Yu Tu
2021-12-22  8:19     ` Yu Tu
2021-12-22  8:19     ` Yu Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YcGC8hlOEbzH8rc8@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbrunet@baylibre.com \
    --cc=jirislaby@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=narmstrong@baylibre.com \
    --cc=yu.tu@amlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.