From: Lee Jones <lee.jones@linaro.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Peter Geis <pgwipeout@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Date: Tue, 21 Dec 2021 08:48:43 +0000 [thread overview]
Message-ID: <YcGU6pQqfEPBqjrO@google.com> (raw)
In-Reply-To: <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45>
On Mon, 20 Dec 2021, Frank Wunderlich wrote:
> Hi
>
> > Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
> > Von: "Peter Geis" <pgwipeout@gmail.com>
> > @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client)
> > if (pm_power_off == rk808_pm_power_off)
> > pm_power_off = NULL;
> >
> > + if (of_property_read_bool(np, "rockchip,system-power-controller"))
> > + unregister_restart_handler(&rk808_restart_handler);
> > +
> > return 0;
> > }
>
> this change misses a declaration
>
> struct device_node *np = client->dev.of_node;
How did this compile when you tested it?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Peter Geis <pgwipeout@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Dmitry Osipenko <digetx@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Date: Tue, 21 Dec 2021 08:48:43 +0000 [thread overview]
Message-ID: <YcGU6pQqfEPBqjrO@google.com> (raw)
In-Reply-To: <trinity-c54ecce4-7a39-4143-b136-f53c9b40ffd1-1640018026851@3c-app-gmx-bap45>
On Mon, 20 Dec 2021, Frank Wunderlich wrote:
> Hi
>
> > Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
> > Von: "Peter Geis" <pgwipeout@gmail.com>
> > @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client)
> > if (pm_power_off == rk808_pm_power_off)
> > pm_power_off = NULL;
> >
> > + if (of_property_read_bool(np, "rockchip,system-power-controller"))
> > + unregister_restart_handler(&rk808_restart_handler);
> > +
> > return 0;
> > }
>
> this change misses a declaration
>
> struct device_node *np = client->dev.of_node;
How did this compile when you tested it?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-12-21 8:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 14:46 [PATCH v3] mfd: rk808: add reboot support to rk808.c Peter Geis
2021-12-20 14:46 ` Peter Geis
2021-12-20 14:53 ` Dmitry Osipenko
2021-12-20 14:53 ` Dmitry Osipenko
2021-12-20 16:33 ` Aw: " Frank Wunderlich
2021-12-20 16:33 ` Frank Wunderlich
2021-12-20 16:36 ` Dmitry Osipenko
2021-12-20 16:36 ` Dmitry Osipenko
2021-12-20 17:07 ` Peter Geis
2021-12-20 17:07 ` Peter Geis
2021-12-21 8:48 ` Lee Jones [this message]
2021-12-21 8:48 ` Lee Jones
2021-12-21 9:10 ` Frank Wunderlich
2021-12-21 9:10 ` Frank Wunderlich
2021-12-22 11:09 ` Lee Jones
2021-12-22 11:09 ` Lee Jones
2021-12-22 11:31 ` Aw: " Frank Wunderlich
2021-12-22 11:31 ` Frank Wunderlich
2021-12-22 12:53 ` Lee Jones
2021-12-22 12:53 ` Lee Jones
2021-12-22 13:19 ` Peter Geis
2021-12-22 13:19 ` Peter Geis
-- strict thread matches above, loose matches on Subject: below --
2021-12-20 17:06 Peter Geis
2021-12-20 17:06 ` Peter Geis
2021-12-21 15:56 ` Dmitry Osipenko
2021-12-21 15:56 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcGU6pQqfEPBqjrO@google.com \
--to=lee.jones@linaro.org \
--cc=digetx@gmail.com \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.