From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jingoo Han <jingoohan1@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Tsuchiya Yuto <kitakar@gmail.com>
Subject: Re: [PATCH v2 2/3] backlight: lp855x: Add dev helper variable to lp855x_probe()
Date: Wed, 22 Dec 2021 11:13:42 +0000 [thread overview]
Message-ID: <YcMIZgofh7Z/X5qQ@google.com> (raw)
In-Reply-To: <20211102225504.18920-2-hdegoede@redhat.com>
On Tue, 02 Nov 2021, Hans de Goede wrote:
> Add a dev local variable to the lp855x_probe(), to replace "&cl->dev"
> and "lp->dev" in various places.
>
> Also switch to dev_err_probe() in one case which takes care of not
> printing -EPROBE_DEFER errors for us.
>
> This is mostly a preparation for adding ACPI enumeration support which
> will use the new "dev" variable more.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 29 +++++++++++++----------------
> 1 file changed, 13 insertions(+), 16 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Tsuchiya Yuto <kitakar@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] backlight: lp855x: Add dev helper variable to lp855x_probe()
Date: Wed, 22 Dec 2021 11:13:42 +0000 [thread overview]
Message-ID: <YcMIZgofh7Z/X5qQ@google.com> (raw)
In-Reply-To: <20211102225504.18920-2-hdegoede@redhat.com>
On Tue, 02 Nov 2021, Hans de Goede wrote:
> Add a dev local variable to the lp855x_probe(), to replace "&cl->dev"
> and "lp->dev" in various places.
>
> Also switch to dev_err_probe() in one case which takes care of not
> printing -EPROBE_DEFER errors for us.
>
> This is mostly a preparation for adding ACPI enumeration support which
> will use the new "dev" variable more.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/video/backlight/lp855x_bl.c | 29 +++++++++++++----------------
> 1 file changed, 13 insertions(+), 16 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-12-22 11:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 22:55 [PATCH v2 1/3] backlight: lp855x: Move device_config setting out of lp855x_configure() Hans de Goede
2021-11-02 22:55 ` Hans de Goede
2021-11-02 22:55 ` [PATCH v2 2/3] backlight: lp855x: Add dev helper variable to lp855x_probe() Hans de Goede
2021-11-02 22:55 ` Hans de Goede
2021-12-22 11:13 ` Lee Jones [this message]
2021-12-22 11:13 ` Lee Jones
2021-11-02 22:55 ` [PATCH v2 3/3] backlight: lp855x: Add support ACPI enumeration Hans de Goede
2021-11-02 22:55 ` Hans de Goede
2021-11-03 17:17 ` Daniel Thompson
2021-11-03 17:17 ` Daniel Thompson
2021-11-03 17:28 ` Hans de Goede
2021-11-03 17:28 ` Hans de Goede
2021-11-03 17:31 ` Daniel Thompson
2021-11-03 17:31 ` Daniel Thompson
2021-11-03 17:34 ` Hans de Goede
2021-11-03 17:34 ` Hans de Goede
2021-11-04 8:29 ` Lee Jones
2021-11-04 8:29 ` Lee Jones
2021-11-04 8:53 ` Hans de Goede
2021-11-04 8:53 ` Hans de Goede
2021-12-22 11:14 ` Lee Jones
2021-12-22 11:14 ` Lee Jones
2021-12-22 11:13 ` [PATCH v2 1/3] backlight: lp855x: Move device_config setting out of lp855x_configure() Lee Jones
2021-12-22 11:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcMIZgofh7Z/X5qQ@google.com \
--to=lee.jones@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=jingoohan1@gmail.com \
--cc=kitakar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.