* [PATCH 0/3] Add RTC support to i.MX8QM
@ 2021-12-21 12:15 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2021-12-21 12:15 UTC (permalink / raw)
To: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc, Abel Vesa
This adds rtc devicetree node to i.MX8QM, adds the compatible to the
rtc-imx-sc driver and documents it.
Abel Vesa (3):
dt-bindings: fsl: scu: Add i.MX8QM rtc binding
rtc: imx-sc: Add i.MX8QM RTC support
arm64: dts: imx8qm: Add SCU RTC node
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 3 +++
drivers/rtc/rtc-imx-sc.c | 1 +
3 files changed, 7 insertions(+), 1 deletion(-)
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
2021-12-21 12:15 ` Abel Vesa
@ 2021-12-21 12:15 ` Abel Vesa
-1 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2021-12-21 12:15 UTC (permalink / raw)
To: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc, Abel Vesa
Add i.MX8QM rtc compatible to the SCU bindings documentation.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index f1470d562156..4633be2182dd 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
------------------------------------------------------------
Required properties:
-- compatible: should be "fsl,imx8qxp-sc-rtc";
+- compatible: Should be one of:
+ "fsl,imx8qm-sc-rtc",
+ "fsl,imx8qxp-sc-rtc".
OCOTP bindings based on SCU Message Protocol
------------------------------------------------------------
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
@ 2021-12-21 12:15 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2021-12-21 12:15 UTC (permalink / raw)
To: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc, Abel Vesa
Add i.MX8QM rtc compatible to the SCU bindings documentation.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
index f1470d562156..4633be2182dd 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
@@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
------------------------------------------------------------
Required properties:
-- compatible: should be "fsl,imx8qxp-sc-rtc";
+- compatible: Should be one of:
+ "fsl,imx8qm-sc-rtc",
+ "fsl,imx8qxp-sc-rtc".
OCOTP bindings based on SCU Message Protocol
------------------------------------------------------------
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
2021-12-21 12:15 ` Abel Vesa
@ 2021-12-22 18:29 ` Rob Herring
-1 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-12-22 18:29 UTC (permalink / raw)
To: Abel Vesa
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-arm-kernel,
Linux Kernel Mailing List, Shawn Guo, Fabio Estevam, linux-rtc,
devicetree, Sascha Hauer
On Tue, 21 Dec 2021 14:15:46 +0200, Abel Vesa wrote:
> Add i.MX8QM rtc compatible to the SCU bindings documentation.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
@ 2021-12-22 18:29 ` Rob Herring
0 siblings, 0 replies; 14+ messages in thread
From: Rob Herring @ 2021-12-22 18:29 UTC (permalink / raw)
To: Abel Vesa
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-arm-kernel,
Linux Kernel Mailing List, Shawn Guo, Fabio Estevam, linux-rtc,
devicetree, Sascha Hauer
On Tue, 21 Dec 2021 14:15:46 +0200, Abel Vesa wrote:
> Add i.MX8QM rtc compatible to the SCU bindings documentation.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
2021-12-21 12:15 ` Abel Vesa
@ 2021-12-29 21:36 ` Alexandre Belloni
-1 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2021-12-29 21:36 UTC (permalink / raw)
To: Abel Vesa
Cc: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc
On 21/12/2021 14:15:46+0200, Abel Vesa wrote:
> Add i.MX8QM rtc compatible to the SCU bindings documentation.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index f1470d562156..4633be2182dd 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
> ------------------------------------------------------------
>
> Required properties:
> -- compatible: should be "fsl,imx8qxp-sc-rtc";
> +- compatible: Should be one of:
> + "fsl,imx8qm-sc-rtc",
> + "fsl,imx8qxp-sc-rtc".
Are the imx8qm and imx8qxp SCU actually different? I would hope you
won't had a third messaging protocol for the RTC...
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
@ 2021-12-29 21:36 ` Alexandre Belloni
0 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2021-12-29 21:36 UTC (permalink / raw)
To: Abel Vesa
Cc: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc
On 21/12/2021 14:15:46+0200, Abel Vesa wrote:
> Add i.MX8QM rtc compatible to the SCU bindings documentation.
>
> Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> index f1470d562156..4633be2182dd 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> @@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
> ------------------------------------------------------------
>
> Required properties:
> -- compatible: should be "fsl,imx8qxp-sc-rtc";
> +- compatible: Should be one of:
> + "fsl,imx8qm-sc-rtc",
> + "fsl,imx8qxp-sc-rtc".
Are the imx8qm and imx8qxp SCU actually different? I would hope you
won't had a third messaging protocol for the RTC...
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
2021-12-29 21:36 ` Alexandre Belloni
@ 2022-01-03 19:46 ` Abel Vesa
-1 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2022-01-03 19:46 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc
On 21-12-29 22:36:27, Alexandre Belloni wrote:
> On 21/12/2021 14:15:46+0200, Abel Vesa wrote:
> > Add i.MX8QM rtc compatible to the SCU bindings documentation.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> > Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index f1470d562156..4633be2182dd 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
> > ------------------------------------------------------------
> >
> > Required properties:
> > -- compatible: should be "fsl,imx8qxp-sc-rtc";
> > +- compatible: Should be one of:
> > + "fsl,imx8qm-sc-rtc",
> > + "fsl,imx8qxp-sc-rtc".
>
> Are the imx8qm and imx8qxp SCU actually different? I would hope you
> won't had a third messaging protocol for the RTC...
>
Sorry, my bad.
No, there is no difference between imx8mq and imx8qxp.
I'll replace the compatible in the imx8qm.dtsi with fsl,imx8qxp-sc-rtc,
drop this patch and the one that adds the compatible to the rtc driver.
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] dt-bindings: fsl: scu: Add i.MX8QM rtc binding
@ 2022-01-03 19:46 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2022-01-03 19:46 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc
On 21-12-29 22:36:27, Alexandre Belloni wrote:
> On 21/12/2021 14:15:46+0200, Abel Vesa wrote:
> > Add i.MX8QM rtc compatible to the SCU bindings documentation.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> > Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > index f1470d562156..4633be2182dd 100644
> > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
> > @@ -134,7 +134,9 @@ RTC bindings based on SCU Message Protocol
> > ------------------------------------------------------------
> >
> > Required properties:
> > -- compatible: should be "fsl,imx8qxp-sc-rtc";
> > +- compatible: Should be one of:
> > + "fsl,imx8qm-sc-rtc",
> > + "fsl,imx8qxp-sc-rtc".
>
> Are the imx8qm and imx8qxp SCU actually different? I would hope you
> won't had a third messaging protocol for the RTC...
>
Sorry, my bad.
No, there is no difference between imx8mq and imx8qxp.
I'll replace the compatible in the imx8qm.dtsi with fsl,imx8qxp-sc-rtc,
drop this patch and the one that adds the compatible to the rtc driver.
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/3] rtc: imx-sc: Add i.MX8QM RTC support
2021-12-21 12:15 ` Abel Vesa
@ 2021-12-21 12:15 ` Abel Vesa
-1 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2021-12-21 12:15 UTC (permalink / raw)
To: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc, Abel Vesa
Add i.MX8QM RTC support.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
drivers/rtc/rtc-imx-sc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx-sc.c
index 814d516645e2..6828f894e15e 100644
--- a/drivers/rtc/rtc-imx-sc.c
+++ b/drivers/rtc/rtc-imx-sc.c
@@ -166,6 +166,7 @@ static int imx_sc_rtc_probe(struct platform_device *pdev)
static const struct of_device_id imx_sc_dt_ids[] = {
{ .compatible = "fsl,imx8qxp-sc-rtc", },
+ { .compatible = "fsl,imx8qm-sc-rtc", },
{}
};
MODULE_DEVICE_TABLE(of, imx_sc_dt_ids);
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/3] rtc: imx-sc: Add i.MX8QM RTC support
@ 2021-12-21 12:15 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2021-12-21 12:15 UTC (permalink / raw)
To: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc, Abel Vesa
Add i.MX8QM RTC support.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
drivers/rtc/rtc-imx-sc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx-sc.c
index 814d516645e2..6828f894e15e 100644
--- a/drivers/rtc/rtc-imx-sc.c
+++ b/drivers/rtc/rtc-imx-sc.c
@@ -166,6 +166,7 @@ static int imx_sc_rtc_probe(struct platform_device *pdev)
static const struct of_device_id imx_sc_dt_ids[] = {
{ .compatible = "fsl,imx8qxp-sc-rtc", },
+ { .compatible = "fsl,imx8qm-sc-rtc", },
{}
};
MODULE_DEVICE_TABLE(of, imx_sc_dt_ids);
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] arm64: dts: imx8qm: Add SCU RTC node
2021-12-21 12:15 ` Abel Vesa
@ 2021-12-21 12:15 ` Abel Vesa
-1 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2021-12-21 12:15 UTC (permalink / raw)
To: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc, Abel Vesa
Add SCU RTC node to support SC RTC driver.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index 4a7c017b5f31..9e5de26b01a0 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -201,6 +201,9 @@ iomuxc: pinctrl {
compatible = "fsl,imx8qm-iomuxc";
};
+ rtc: rtc {
+ compatible = "fsl,imx8qm-sc-rtc";
+ };
};
/* sorted in register address */
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 3/3] arm64: dts: imx8qm: Add SCU RTC node
@ 2021-12-21 12:15 ` Abel Vesa
0 siblings, 0 replies; 14+ messages in thread
From: Abel Vesa @ 2021-12-21 12:15 UTC (permalink / raw)
To: Rob Herring, Sascha Hauer, Shawn Guo, Fabio Estevam
Cc: Pengutronix Kernel Team, NXP Linux Team, devicetree,
Linux Kernel Mailing List, linux-arm-kernel, linux-rtc, Abel Vesa
Add SCU RTC node to support SC RTC driver.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index 4a7c017b5f31..9e5de26b01a0 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -201,6 +201,9 @@ iomuxc: pinctrl {
compatible = "fsl,imx8qm-iomuxc";
};
+ rtc: rtc {
+ compatible = "fsl,imx8qm-sc-rtc";
+ };
};
/* sorted in register address */
--
2.31.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread