From: Greg KH <gregkh@linuxfoundation.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: jonathanh@nvidia.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
tiwai@suse.com, robh+dt@kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, thierry.reding@gmail.com,
stable@vger.kernel.org, linux-tegra@vger.kernel.org,
Dmitry Osipenko <digetx@gmail.com>,
mkumard@nvidia.com
Subject: Re: [PATCH v3 1/3] ALSA: hda/tegra: Fix Tegra194 HDA reset failure
Date: Thu, 23 Dec 2021 08:16:15 +0100 [thread overview]
Message-ID: <YcQiP+MxrlLi+R94@kroah.com> (raw)
In-Reply-To: <f734e48f-dd60-ddb8-510a-3c4f37d8fb52@nvidia.com>
On Thu, Dec 23, 2021 at 10:04:19AM +0530, Sameer Pujar wrote:
>
>
> On 12/23/2021 12:10 AM, Dmitry Osipenko wrote:
> > 22.12.2021 07:35, Sameer Pujar пишет:
> > > HDA regression is recently reported on Tegra194 based platforms.
> > > This happens because "hda2codec_2x" reset does not really exist
> > > in Tegra194 and it causes probe failure. All the HDA based audio
> > > tests fail at the moment. This underlying issue is exposed by
> > > commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
> > > response") which now checks return code of BPMP command response.
> > > Fix this issue by skipping unavailable reset on Tegra194.
> > >
> > > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > > Cc: stable@vger.kernel.org
> > > Depends-on: 87f0e46e7559 ("ALSA: hda/tegra: Reset hardware")
> > Is "Depends-on" a valid tag? I can't find it in Documentation/.
>
> I do find the usage of the tag in many commits though there is no reference
> of this in doc. I always thought it would act as a reference when commits
> get pulled to other branches. If this is not true and it does not mean
> anything, I will drop this.
It is not true at all, please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Dmitry Osipenko <digetx@gmail.com>,
tiwai@suse.com, broonie@kernel.org, lgirdwood@gmail.com,
robh+dt@kernel.org, thierry.reding@gmail.com, perex@perex.cz,
jonathanh@nvidia.com, mkumard@nvidia.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3 1/3] ALSA: hda/tegra: Fix Tegra194 HDA reset failure
Date: Thu, 23 Dec 2021 08:16:15 +0100 [thread overview]
Message-ID: <YcQiP+MxrlLi+R94@kroah.com> (raw)
In-Reply-To: <f734e48f-dd60-ddb8-510a-3c4f37d8fb52@nvidia.com>
On Thu, Dec 23, 2021 at 10:04:19AM +0530, Sameer Pujar wrote:
>
>
> On 12/23/2021 12:10 AM, Dmitry Osipenko wrote:
> > 22.12.2021 07:35, Sameer Pujar пишет:
> > > HDA regression is recently reported on Tegra194 based platforms.
> > > This happens because "hda2codec_2x" reset does not really exist
> > > in Tegra194 and it causes probe failure. All the HDA based audio
> > > tests fail at the moment. This underlying issue is exposed by
> > > commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
> > > response") which now checks return code of BPMP command response.
> > > Fix this issue by skipping unavailable reset on Tegra194.
> > >
> > > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > > Cc: stable@vger.kernel.org
> > > Depends-on: 87f0e46e7559 ("ALSA: hda/tegra: Reset hardware")
> > Is "Depends-on" a valid tag? I can't find it in Documentation/.
>
> I do find the usage of the tag in many commits though there is no reference
> of this in doc. I always thought it would act as a reference when commits
> get pulled to other branches. If this is not true and it does not mean
> anything, I will drop this.
It is not true at all, please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
next prev parent reply other threads:[~2021-12-23 7:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 4:35 [PATCH v3 0/3] Fix Tegra194 HDA regression Sameer Pujar
2021-12-22 4:35 ` Sameer Pujar
2021-12-22 4:35 ` [PATCH v3 1/3] ALSA: hda/tegra: Fix Tegra194 HDA reset failure Sameer Pujar
2021-12-22 4:35 ` Sameer Pujar
2021-12-22 18:40 ` Dmitry Osipenko
2021-12-22 18:40 ` Dmitry Osipenko
2021-12-23 4:34 ` Sameer Pujar
2021-12-23 4:34 ` Sameer Pujar
2021-12-23 7:16 ` Greg KH [this message]
2021-12-23 7:16 ` Greg KH
2021-12-23 11:24 ` Sameer Pujar
2021-12-23 11:24 ` Sameer Pujar
2021-12-22 4:35 ` [PATCH v3 2/3] dt-bindings: sound: tegra: Update HDA resets Sameer Pujar
2021-12-22 4:35 ` Sameer Pujar
2021-12-22 19:37 ` Rob Herring
2021-12-22 19:37 ` Rob Herring
2021-12-22 4:35 ` [PATCH v3 3/3] arm64: tegra: Remove non existent Tegra194 reset Sameer Pujar
2021-12-22 4:35 ` Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcQiP+MxrlLi+R94@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=spujar@nvidia.com \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.