From: Mark Brown <broonie@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vinod.koul@linaro.org,
tiwai@suse.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, vkoul@kernel.org,
srinivas.kandagatla@linaro.org, sanyog.r.kale@intel.com,
bard.liao@intel.com
Subject: Re: [PATCH 7/7] soundwire: intel: remove PDM support
Date: Thu, 23 Dec 2021 18:26:56 +0000 [thread overview]
Message-ID: <YcS/cPb0UXsc9SWm@sirena.org.uk> (raw)
In-Reply-To: <20211213054634.30088-8-yung-chuan.liao@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2291 bytes --]
On Mon, Dec 13, 2021 at 01:46:34PM +0800, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> While the hardware supports PDM streams, this capability has never
> been tested or enabled on any product, so this is dead-code. Let's
> remove all this.
This doesn't build with current code, I'm guessing due to a Soundwire
dependency I don't have:
/mnt/kernel/drivers/soundwire/intel.c:1142:3: error: 'const struct snd_soc_dai_ops' has no member named 'set_sdw_stream'; did you mean 'set_stream'?
1142 | .set_sdw_stream = intel_pdm_set_sdw_stream,
| ^~~~~~~~~~~~~~
| set_stream
/mnt/kernel/drivers/soundwire/intel.c:1142:20: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *, struct snd_soc_dai *)' from incompatible pointer type 'int (*)(struct snd_soc_dai *, void *, int)' [-Werror=incompatible-pointer-types]
1142 | .set_sdw_stream = intel_pdm_set_sdw_stream,
| ^~~~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/soundwire/intel.c:1142:20: note: (near initialization for 'intel_pdm_dai_ops.hw_params')
/mnt/kernel/drivers/soundwire/intel.c:1143:3: error: 'const struct snd_soc_dai_ops' has no member named 'get_sdw_stream'; did you mean 'get_stream'?
1143 | .get_sdw_stream = intel_get_sdw_stream,
| ^~~~~~~~~~~~~~
| get_stream
/mnt/kernel/drivers/soundwire/intel.c:1143:20: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_soc_dai *)' from incompatible pointer type 'void * (*)(struct snd_soc_dai *, int)' [-Werror=incompatible-pointer-types]
1143 | .get_sdw_stream = intel_get_sdw_stream,
| ^~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/soundwire/intel.c:1143:20: note: (near initialization for 'intel_pdm_dai_ops.hw_free')
cc1: all warnings being treated as errors
make[3]: *** [/mnt/kernel/scripts/Makefile.build:287: drivers/soundwire/intel.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/mnt/kernel/scripts/Makefile.build:549: drivers/soundwire] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/mnt/kernel/Makefile:1846: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:219: __sub-make] Error 2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: alsa-devel@alsa-project.org, vkoul@kernel.org,
vinod.koul@linaro.org, linux-kernel@vger.kernel.org,
tiwai@suse.de, gregkh@linuxfoundation.org,
srinivas.kandagatla@linaro.org,
pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com,
bard.liao@intel.com
Subject: Re: [PATCH 7/7] soundwire: intel: remove PDM support
Date: Thu, 23 Dec 2021 18:26:56 +0000 [thread overview]
Message-ID: <YcS/cPb0UXsc9SWm@sirena.org.uk> (raw)
In-Reply-To: <20211213054634.30088-8-yung-chuan.liao@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2291 bytes --]
On Mon, Dec 13, 2021 at 01:46:34PM +0800, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> While the hardware supports PDM streams, this capability has never
> been tested or enabled on any product, so this is dead-code. Let's
> remove all this.
This doesn't build with current code, I'm guessing due to a Soundwire
dependency I don't have:
/mnt/kernel/drivers/soundwire/intel.c:1142:3: error: 'const struct snd_soc_dai_ops' has no member named 'set_sdw_stream'; did you mean 'set_stream'?
1142 | .set_sdw_stream = intel_pdm_set_sdw_stream,
| ^~~~~~~~~~~~~~
| set_stream
/mnt/kernel/drivers/soundwire/intel.c:1142:20: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_pcm_hw_params *, struct snd_soc_dai *)' from incompatible pointer type 'int (*)(struct snd_soc_dai *, void *, int)' [-Werror=incompatible-pointer-types]
1142 | .set_sdw_stream = intel_pdm_set_sdw_stream,
| ^~~~~~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/soundwire/intel.c:1142:20: note: (near initialization for 'intel_pdm_dai_ops.hw_params')
/mnt/kernel/drivers/soundwire/intel.c:1143:3: error: 'const struct snd_soc_dai_ops' has no member named 'get_sdw_stream'; did you mean 'get_stream'?
1143 | .get_sdw_stream = intel_get_sdw_stream,
| ^~~~~~~~~~~~~~
| get_stream
/mnt/kernel/drivers/soundwire/intel.c:1143:20: error: initialization of 'int (*)(struct snd_pcm_substream *, struct snd_soc_dai *)' from incompatible pointer type 'void * (*)(struct snd_soc_dai *, int)' [-Werror=incompatible-pointer-types]
1143 | .get_sdw_stream = intel_get_sdw_stream,
| ^~~~~~~~~~~~~~~~~~~~
/mnt/kernel/drivers/soundwire/intel.c:1143:20: note: (near initialization for 'intel_pdm_dai_ops.hw_free')
cc1: all warnings being treated as errors
make[3]: *** [/mnt/kernel/scripts/Makefile.build:287: drivers/soundwire/intel.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/mnt/kernel/scripts/Makefile.build:549: drivers/soundwire] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/mnt/kernel/Makefile:1846: drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:219: __sub-make] Error 2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-23 18:28 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 5:46 [PATCH 0/7] ASoC/SoundWire: improve suspend flows and use set_stream() instead of set_tdm_slots() for HDAudio Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-13 5:46 ` [PATCH 1/7] ASOC: SOF: Intel: use snd_soc_dai_get_widget() Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-13 5:46 ` [PATCH 2/7] ASoC/soundwire: intel: simplify callbacks for params/hw_free Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-23 16:30 ` Vinod Koul
2021-12-23 16:30 ` Vinod Koul
2021-12-13 5:46 ` [PATCH 3/7] soundwire: intel: improve suspend flows Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-23 6:56 ` Vinod Koul
2021-12-23 6:56 ` Vinod Koul
2021-12-13 5:46 ` [PATCH 4/7] ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-23 16:35 ` Vinod Koul
2021-12-23 16:35 ` Vinod Koul
2021-12-13 5:46 ` [PATCH 5/7] ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-13 5:46 ` [PATCH 6/7] soundwire: intel: remove unnecessary init Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-23 6:58 ` Vinod Koul
2021-12-23 6:58 ` Vinod Koul
2021-12-13 5:46 ` [PATCH 7/7] soundwire: intel: remove PDM support Bard Liao
2021-12-13 5:46 ` Bard Liao
2021-12-23 6:59 ` Vinod Koul
2021-12-23 6:59 ` Vinod Koul
2021-12-23 7:46 ` Liao, Bard
2021-12-23 7:46 ` Liao, Bard
2021-12-23 11:05 ` Vinod Koul
2021-12-23 11:05 ` Vinod Koul
2021-12-23 12:29 ` Liao, Bard
2021-12-23 12:29 ` Liao, Bard
2022-01-10 16:32 ` Pierre-Louis Bossart
2021-12-23 16:35 ` Vinod Koul
2021-12-23 16:35 ` Vinod Koul
2021-12-23 18:26 ` Mark Brown [this message]
2021-12-23 18:26 ` Mark Brown
2021-12-24 1:38 ` Liao, Bard
2021-12-24 1:38 ` Liao, Bard
2021-12-21 18:09 ` [PATCH 0/7] ASoC/SoundWire: improve suspend flows and use set_stream() instead of set_tdm_slots() for HDAudio Mark Brown
2021-12-21 18:09 ` Mark Brown
2021-12-22 13:47 ` Liao, Bard
2021-12-22 13:47 ` Liao, Bard
2021-12-23 5:19 ` Vinod Koul
2021-12-23 5:19 ` Vinod Koul
2021-12-24 16:17 ` Mark Brown
2021-12-24 16:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcS/cPb0UXsc9SWm@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vinod.koul@linaro.org \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.