From: Lee Jones <lee.jones@linaro.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver
Date: Wed, 29 Dec 2021 10:18:37 +0000 [thread overview]
Message-ID: <Ycw1/XufNWq/FUss@google.com> (raw)
In-Reply-To: <20211224041352.29405-9-quan@os.amperecomputing.com>
On Fri, 24 Dec 2021, Quan Nguyen wrote:
> This commit adds driver support for accessing various information
> reported by Ampere's SMpro co-processor such as Boot Progress and
> other miscellaneous data.
>
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
> Change in v6:
> + First introduced in v6 [Quan]
>
> drivers/mfd/smpro-mfd.c | 1 +
Please pull all of these patches out.
There are no build dependencies here.
> drivers/misc/Kconfig | 7 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/smpro-misc.c | 177 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 186 insertions(+)
> create mode 100644 drivers/misc/smpro-misc.c
>
> diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c
> index a7cd64bf9eaa..5611dd30f8f4 100644
> --- a/drivers/mfd/smpro-mfd.c
> +++ b/drivers/mfd/smpro-mfd.c
> @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = {
> static const struct mfd_cell smpro_devs[] = {
> MFD_CELL_NAME("smpro-hwmon"),
> MFD_CELL_NAME("smpro-errmon"),
> + MFD_CELL_NAME("smpro-misc"),
Misc is a Linuxisum which are not allowed in DT.
What does this driver actually do?
--
Lee Jones [???]
Senior Technical Lead - Developer Services
Linaro.org ? Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>
Subject: Re: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver
Date: Wed, 29 Dec 2021 10:18:37 +0000 [thread overview]
Message-ID: <Ycw1/XufNWq/FUss@google.com> (raw)
In-Reply-To: <20211224041352.29405-9-quan@os.amperecomputing.com>
On Fri, 24 Dec 2021, Quan Nguyen wrote:
> This commit adds driver support for accessing various information
> reported by Ampere's SMpro co-processor such as Boot Progress and
> other miscellaneous data.
>
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
> Change in v6:
> + First introduced in v6 [Quan]
>
> drivers/mfd/smpro-mfd.c | 1 +
Please pull all of these patches out.
There are no build dependencies here.
> drivers/misc/Kconfig | 7 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/smpro-misc.c | 177 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 186 insertions(+)
> create mode 100644 drivers/misc/smpro-misc.c
>
> diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c
> index a7cd64bf9eaa..5611dd30f8f4 100644
> --- a/drivers/mfd/smpro-mfd.c
> +++ b/drivers/mfd/smpro-mfd.c
> @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = {
> static const struct mfd_cell smpro_devs[] = {
> MFD_CELL_NAME("smpro-hwmon"),
> MFD_CELL_NAME("smpro-errmon"),
> + MFD_CELL_NAME("smpro-misc"),
Misc is a Linuxisum which are not allowed in DT.
What does this driver actually do?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: linux-aspeed@lists.ozlabs.org, linux-doc@vger.kernel.org,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Phong Vo <phong@os.amperecomputing.com>,
Jonathan Corbet <corbet@lwn.net>,
openbmc@lists.ozlabs.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Rob Herring <robh+dt@kernel.org>,
Open Source Submission <patches@amperecomputing.com>,
linux-hwmon@vger.kernel.org, Andrew Jeffery <andrew@aj.id.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Subject: Re: [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver
Date: Wed, 29 Dec 2021 10:18:37 +0000 [thread overview]
Message-ID: <Ycw1/XufNWq/FUss@google.com> (raw)
In-Reply-To: <20211224041352.29405-9-quan@os.amperecomputing.com>
On Fri, 24 Dec 2021, Quan Nguyen wrote:
> This commit adds driver support for accessing various information
> reported by Ampere's SMpro co-processor such as Boot Progress and
> other miscellaneous data.
>
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
> Change in v6:
> + First introduced in v6 [Quan]
>
> drivers/mfd/smpro-mfd.c | 1 +
Please pull all of these patches out.
There are no build dependencies here.
> drivers/misc/Kconfig | 7 ++
> drivers/misc/Makefile | 1 +
> drivers/misc/smpro-misc.c | 177 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 186 insertions(+)
> create mode 100644 drivers/misc/smpro-misc.c
>
> diff --git a/drivers/mfd/smpro-mfd.c b/drivers/mfd/smpro-mfd.c
> index a7cd64bf9eaa..5611dd30f8f4 100644
> --- a/drivers/mfd/smpro-mfd.c
> +++ b/drivers/mfd/smpro-mfd.c
> @@ -28,6 +28,7 @@ static const struct regmap_config simple_word_regmap_config = {
> static const struct mfd_cell smpro_devs[] = {
> MFD_CELL_NAME("smpro-hwmon"),
> MFD_CELL_NAME("smpro-errmon"),
> + MFD_CELL_NAME("smpro-misc"),
Misc is a Linuxisum which are not allowed in DT.
What does this driver actually do?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-12-29 10:18 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 4:13 [PATCH v6 0/9] Add Ampere's Altra SMPro MFD and its child drivers Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 1/9] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 2/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro " Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2022-02-08 9:12 ` Lee Jones
2022-02-08 9:12 ` Lee Jones
2022-02-08 9:12 ` Lee Jones
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 3/9] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 4/9] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 5/9] regmap: Introduces regmap lock helpers Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 13:19 ` Mark Brown
2021-12-24 13:19 ` Mark Brown
2021-12-24 13:19 ` Mark Brown
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 8:32 ` Greg Kroah-Hartman
2021-12-24 8:32 ` Greg Kroah-Hartman
2021-12-24 8:32 ` Greg Kroah-Hartman
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 8:32 ` Quan Nguyen
2021-12-24 13:28 ` Mark Brown
2021-12-24 13:28 ` Mark Brown
2021-12-24 13:28 ` Mark Brown
2022-03-07 8:30 ` Quan Nguyen
2022-03-07 8:30 ` Quan Nguyen
2022-03-07 8:30 ` Quan Nguyen
2021-12-28 6:31 ` kernel test robot
2021-12-29 10:16 ` Lee Jones
2021-12-29 10:16 ` Lee Jones
2021-12-29 10:16 ` Lee Jones
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 7/9] docs: misc-devices: (smpro-errmon) Add documentation Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-29 10:18 ` Lee Jones [this message]
2021-12-29 10:18 ` Lee Jones
2021-12-29 10:18 ` Lee Jones
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 13:16 ` Arnd Bergmann
2022-03-07 13:16 ` Arnd Bergmann
2022-03-07 13:16 ` Arnd Bergmann
2021-12-24 4:13 ` [PATCH v6 9/9] docs: misc-devices: (smpro-misc) Add documentation Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
2021-12-24 4:13 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ycw1/XufNWq/FUss@google.com \
--to=lee.jones@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.