From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Ryusuke Konishi
<konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-nilfs <linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] nilfs2: use default_groups in kobj_type
Date: Wed, 29 Dec 2021 09:34:10 +0100 [thread overview]
Message-ID: <YcwdgkuScucp7ELG@kroah.com> (raw)
In-Reply-To: <CAKFNMona12jPJMGveSHgVDks_EYd_ZAJ_gDRLZo=exyFD3Y8+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Dec 29, 2021 at 01:52:15AM +0900, Ryusuke Konishi wrote:
> On Tue, Dec 28, 2021 at 11:42 PM Greg Kroah-Hartman
> <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org> wrote:
> >
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the nilfs2 code to use default_groups field which has been
> > the preferred way since aa30f47cf666 ("kobject: Add support for default
> > attribute groups to kobj_type") so that we can soon get rid of the
> > obsolete default_attrs field.
> >
> > Cc: Ryusuke Konishi <konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
>
> Acked-by: Ryusuke Konishi <konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Looks good to me.
> Please take it through your tree for your convenience, thanks.
Will do, thanks!
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-nilfs <linux-nilfs@vger.kernel.org>
Subject: Re: [PATCH] nilfs2: use default_groups in kobj_type
Date: Wed, 29 Dec 2021 09:34:10 +0100 [thread overview]
Message-ID: <YcwdgkuScucp7ELG@kroah.com> (raw)
In-Reply-To: <CAKFNMona12jPJMGveSHgVDks_EYd_ZAJ_gDRLZo=exyFD3Y8+g@mail.gmail.com>
On Wed, Dec 29, 2021 at 01:52:15AM +0900, Ryusuke Konishi wrote:
> On Tue, Dec 28, 2021 at 11:42 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the nilfs2 code to use default_groups field which has been
> > the preferred way since aa30f47cf666 ("kobject: Add support for default
> > attribute groups to kobj_type") so that we can soon get rid of the
> > obsolete default_attrs field.
> >
> > Cc: Ryusuke Konishi <konishi.ryusuke@gmail.com>
> > Cc: linux-nilfs@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Acked-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
>
> Looks good to me.
> Please take it through your tree for your convenience, thanks.
Will do, thanks!
greg k-h
next prev parent reply other threads:[~2021-12-29 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 14:42 [PATCH] nilfs2: use default_groups in kobj_type Greg Kroah-Hartman
2021-12-28 14:42 ` Greg Kroah-Hartman
[not found] ` <20211228144252.390554-1-gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
2021-12-28 16:52 ` Ryusuke Konishi
2021-12-28 16:52 ` Ryusuke Konishi
[not found] ` <CAKFNMona12jPJMGveSHgVDks_EYd_ZAJ_gDRLZo=exyFD3Y8+g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2021-12-29 8:34 ` Greg Kroah-Hartman [this message]
2021-12-29 8:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcwdgkuScucp7ELG@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=konishi.ryusuke-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.