* [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified
@ 2022-01-11 22:05 Douglas Anderson
2022-01-12 0:29 ` Stephen Boyd
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Douglas Anderson @ 2022-01-11 22:05 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Stephen Boyd
Cc: Matthias Kaehlcke, linux-arm-msm, Douglas Anderson, Andy Gross,
Rob Herring, devicetree, linux-gpio, linux-kernel
If the drive-strength isn't specified in the device tree then it
doesn't actually default to 2. Instead, it defaults to whatever the
heck the BIOS left it at. If the BIOS doesn't touch it then that means
it's whatever the heck the initial state of the pin was when the SoC
booted.
Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
index 3b37cf102d41..dac788bc9320 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
@@ -70,7 +70,6 @@ $defs:
properties:
drive-strength:
enum: [2, 4, 6, 8, 10, 12, 14, 16]
- default: 2
description:
Selects the drive strength for the specified pins, in mA.
--
2.34.1.575.g55b058a8bb-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified
2022-01-11 22:05 [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified Douglas Anderson
@ 2022-01-12 0:29 ` Stephen Boyd
2022-01-12 16:35 ` Matthias Kaehlcke
2022-01-16 0:58 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2022-01-12 0:29 UTC (permalink / raw)
To: Bjorn Andersson, Douglas Anderson, Linus Walleij
Cc: Matthias Kaehlcke, linux-arm-msm, Andy Gross, Rob Herring,
devicetree, linux-gpio, linux-kernel
Quoting Douglas Anderson (2022-01-11 14:05:21)
> If the drive-strength isn't specified in the device tree then it
> doesn't actually default to 2. Instead, it defaults to whatever the
> heck the BIOS left it at. If the BIOS doesn't touch it then that means
> it's whatever the heck the initial state of the pin was when the SoC
> booted.
>
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified
2022-01-11 22:05 [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified Douglas Anderson
2022-01-12 0:29 ` Stephen Boyd
@ 2022-01-12 16:35 ` Matthias Kaehlcke
2022-01-16 0:58 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2022-01-12 16:35 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Linus Walleij, Stephen Boyd, linux-arm-msm,
Andy Gross, Rob Herring, devicetree, linux-gpio, linux-kernel
On Tue, Jan 11, 2022 at 02:05:21PM -0800, Douglas Anderson wrote:
> If the drive-strength isn't specified in the device tree then it
> doesn't actually default to 2. Instead, it defaults to whatever the
> heck the BIOS left it at. If the BIOS doesn't touch it then that means
> it's whatever the heck the initial state of the pin was when the SoC
> booted.
>
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified
2022-01-11 22:05 [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified Douglas Anderson
2022-01-12 0:29 ` Stephen Boyd
2022-01-12 16:35 ` Matthias Kaehlcke
@ 2022-01-16 0:58 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2022-01-16 0:58 UTC (permalink / raw)
To: Douglas Anderson
Cc: Bjorn Andersson, Stephen Boyd, Matthias Kaehlcke, linux-arm-msm,
Andy Gross, Rob Herring, devicetree, linux-gpio, linux-kernel
On Tue, Jan 11, 2022 at 11:05 PM Douglas Anderson <dianders@chromium.org> wrote:
> If the drive-strength isn't specified in the device tree then it
> doesn't actually default to 2. Instead, it defaults to whatever the
> heck the BIOS left it at. If the BIOS doesn't touch it then that means
> it's whatever the heck the initial state of the pin was when the SoC
> booted.
>
> Reported-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-16 0:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11 22:05 [PATCH] dt-bindings: pinctrl: drive-strength doesn't default to 2 if unspecified Douglas Anderson
2022-01-12 0:29 ` Stephen Boyd
2022-01-12 16:35 ` Matthias Kaehlcke
2022-01-16 0:58 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.