All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Javier Martinez Canillas <javier@dowhile0.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: mfd: maxim,max77802: Convert to dtschema
Date: Tue, 4 Jan 2022 09:35:31 -0600	[thread overview]
Message-ID: <YdRpQ2jIJ+vvg33q@robh.at.kernel.org> (raw)
In-Reply-To: <20211228164305.35877-4-krzysztof.kozlowski@canonical.com>

On Tue, Dec 28, 2021 at 05:43:05PM +0100, Krzysztof Kozlowski wrote:
> Convert the MFD part of Maxim MAX77802 PMIC to DT schema format.  The
> example DTS was copied from existing DTS (exynos5800-peach-pi.dts), so
> keep the license as GPL-2.0-only.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/mfd/max77802.txt      |  25 ---
>  .../bindings/mfd/maxim,max77802.yaml          | 194 ++++++++++++++++++
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 195 insertions(+), 26 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
>  create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt
> deleted file mode 100644
> index 09decac20d91..000000000000
> --- a/Documentation/devicetree/bindings/mfd/max77802.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Maxim MAX77802 multi-function device
> -
> -The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high
> -efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power
> -up application processors and peripherals, a 2-channel 32kHz clock outputs,
> -a Real-Time-Clock (RTC) and a I2C interface to program the individual
> -regulators, clocks outputs and the RTC.
> -
> -Bindings for the built-in 32k clock generator block and
> -regulators are defined in ../clk/maxim,max77802.txt and
> -../regulator/max77802.txt respectively.
> -
> -Required properties:
> -- compatible		: Must be "maxim,max77802"
> -- reg			: Specifies the I2C slave address of PMIC block.
> -- interrupts		: I2C device IRQ line connected to the main SoC.
> -
> -Example:
> -
> -	max77802: pmic@9 {
> -		compatible = "maxim,max77802";
> -		interrupt-parent = <&intc>;
> -		interrupts = <26 IRQ_TYPE_NONE>;
> -		reg = <0x09>;
> -	};
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> new file mode 100644
> index 000000000000..26f49fbace18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> @@ -0,0 +1,194 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/maxim,max77802.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX77802 Power Management IC
> +
> +maintainers:
> +  - Javier Martinez Canillas <javier@dowhile0.org>
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +description: |
> +  This is a part of device tree bindings for Maxim MAX77802 Power Management
> +  Integrated Circuit (PMIC).
> +
> +  The Maxim MAX77802 is a Power Management IC which includes voltage and
> +  current regulators (10 high efficiency Buck regulators and 32 Low-DropOut
> +  (LDO)), RTC and clock outputs.
> +
> +  The MAX77802 provides two 32.768khz clock outputs that can be controlled
> +  (gated/ungated) over I2C.  The clock IDs are defined as preprocessor macros
> +  in dt-bindings/clock/maxim,max77802.h.
> +
> +properties:
> +  compatible:
> +    const: maxim,max77802
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    $ref: ../regulator/maxim,max77802.yaml

Use absolute path: /schemas/regulator/...

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Javier Martinez Canillas <javier@dowhile0.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: mfd: maxim, max77802: Convert to dtschema
Date: Tue, 4 Jan 2022 09:35:31 -0600	[thread overview]
Message-ID: <YdRpQ2jIJ+vvg33q@robh.at.kernel.org> (raw)
In-Reply-To: <20211228164305.35877-4-krzysztof.kozlowski@canonical.com>

On Tue, Dec 28, 2021 at 05:43:05PM +0100, Krzysztof Kozlowski wrote:
> Convert the MFD part of Maxim MAX77802 PMIC to DT schema format.  The
> example DTS was copied from existing DTS (exynos5800-peach-pi.dts), so
> keep the license as GPL-2.0-only.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/mfd/max77802.txt      |  25 ---
>  .../bindings/mfd/maxim,max77802.yaml          | 194 ++++++++++++++++++
>  MAINTAINERS                                   |   2 +-
>  3 files changed, 195 insertions(+), 26 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mfd/max77802.txt
>  create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/max77802.txt b/Documentation/devicetree/bindings/mfd/max77802.txt
> deleted file mode 100644
> index 09decac20d91..000000000000
> --- a/Documentation/devicetree/bindings/mfd/max77802.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Maxim MAX77802 multi-function device
> -
> -The Maxim MAX77802 is a Power Management IC (PMIC) that contains 10 high
> -efficiency Buck regulators, 32 Low-DropOut (LDO) regulators used to power
> -up application processors and peripherals, a 2-channel 32kHz clock outputs,
> -a Real-Time-Clock (RTC) and a I2C interface to program the individual
> -regulators, clocks outputs and the RTC.
> -
> -Bindings for the built-in 32k clock generator block and
> -regulators are defined in ../clk/maxim,max77802.txt and
> -../regulator/max77802.txt respectively.
> -
> -Required properties:
> -- compatible		: Must be "maxim,max77802"
> -- reg			: Specifies the I2C slave address of PMIC block.
> -- interrupts		: I2C device IRQ line connected to the main SoC.
> -
> -Example:
> -
> -	max77802: pmic@9 {
> -		compatible = "maxim,max77802";
> -		interrupt-parent = <&intc>;
> -		interrupts = <26 IRQ_TYPE_NONE>;
> -		reg = <0x09>;
> -	};
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> new file mode 100644
> index 000000000000..26f49fbace18
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77802.yaml
> @@ -0,0 +1,194 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/maxim,max77802.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX77802 Power Management IC
> +
> +maintainers:
> +  - Javier Martinez Canillas <javier@dowhile0.org>
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +description: |
> +  This is a part of device tree bindings for Maxim MAX77802 Power Management
> +  Integrated Circuit (PMIC).
> +
> +  The Maxim MAX77802 is a Power Management IC which includes voltage and
> +  current regulators (10 high efficiency Buck regulators and 32 Low-DropOut
> +  (LDO)), RTC and clock outputs.
> +
> +  The MAX77802 provides two 32.768khz clock outputs that can be controlled
> +  (gated/ungated) over I2C.  The clock IDs are defined as preprocessor macros
> +  in dt-bindings/clock/maxim,max77802.h.
> +
> +properties:
> +  compatible:
> +    const: maxim,max77802
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    $ref: ../regulator/maxim,max77802.yaml

Use absolute path: /schemas/regulator/...

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-04 15:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-28 16:43 [PATCH 0/3] regulator/mfd: dt-bindings: maxim,max77802: convert to dtschema Krzysztof Kozlowski
2021-12-28 16:43 ` [PATCH 0/3] regulator/mfd: dt-bindings: maxim, max77802: " Krzysztof Kozlowski
2021-12-28 16:43 ` [PATCH 1/3] ARM: dts: exynos: drop unsupported MAX77802 regulators on Odroid XU Krzysztof Kozlowski
2021-12-28 16:43   ` Krzysztof Kozlowski
2022-01-23 17:09   ` (subset) " Krzysztof Kozlowski
2022-01-23 17:09     ` Krzysztof Kozlowski
2021-12-28 16:43 ` [PATCH 2/3] regulator: dt-bindings: maxim,max77802: Convert to dtschema Krzysztof Kozlowski
2021-12-28 16:43   ` [PATCH 2/3] regulator: dt-bindings: maxim, max77802: " Krzysztof Kozlowski
2022-01-04 15:33   ` [PATCH 2/3] regulator: dt-bindings: maxim,max77802: " Rob Herring
2022-01-04 15:33     ` Rob Herring
2022-01-11 16:43     ` Krzysztof Kozlowski
2022-01-11 16:43       ` Krzysztof Kozlowski
2021-12-28 16:43 ` [PATCH 3/3] dt-bindings: mfd: " Krzysztof Kozlowski
2021-12-28 16:43   ` Krzysztof Kozlowski
2022-01-04 15:35   ` Rob Herring [this message]
2022-01-04 15:35     ` [PATCH 3/3] dt-bindings: mfd: maxim, max77802: " Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdRpQ2jIJ+vvg33q@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=javier@dowhile0.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.