All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org,
	linux-omap <linux-omap@vger.kernel.org>,
	Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH] dt-bindings: clock: Add binding for TI clksel
Date: Mon, 10 Jan 2022 12:30:54 +0200	[thread overview]
Message-ID: <YdwK3haVDCxyIioo@atomide.com> (raw)
In-Reply-To: <CAL_JsqLek5SOypZhTxpLK13x2HEYbLbYYotLGOfM-JTb=QE-Eg@mail.gmail.com>

* Rob Herring <robh@kernel.org> [220104 22:06]:
> On Wed, Dec 22, 2021 at 12:24 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hi,
> >
> > * Rob Herring <robh@kernel.org> [211221 18:13]:
> > > On Fri, Dec 17, 2021 at 01:36:40PM +0200, Tony Lindgren wrote:
> > > > +additionalProperties: true
> > >
> > > Like what properties?
> > >
> > > true is only used for common, incomplete schemas referenced by device
> > > schemas.
> >
> > There is a collection of the current component clock child nodes for each
> > clksel instance. I got warnings with "additionalProperties: false", but
> > maybe the child clock nodes need to be somehow specified in the binding?
> 
> If everything else is a child node, then you can do:
> 
> additionalProperties:
>   type: object

OK thanks will do, the additional properties are always child nodes.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	devicetree@vger.kernel.org,
	linux-omap <linux-omap@vger.kernel.org>,
	Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH] dt-bindings: clock: Add binding for TI clksel
Date: Mon, 10 Jan 2022 12:30:54 +0200	[thread overview]
Message-ID: <YdwK3haVDCxyIioo@atomide.com> (raw)
In-Reply-To: <CAL_JsqLek5SOypZhTxpLK13x2HEYbLbYYotLGOfM-JTb=QE-Eg@mail.gmail.com>

* Rob Herring <robh@kernel.org> [220104 22:06]:
> On Wed, Dec 22, 2021 at 12:24 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hi,
> >
> > * Rob Herring <robh@kernel.org> [211221 18:13]:
> > > On Fri, Dec 17, 2021 at 01:36:40PM +0200, Tony Lindgren wrote:
> > > > +additionalProperties: true
> > >
> > > Like what properties?
> > >
> > > true is only used for common, incomplete schemas referenced by device
> > > schemas.
> >
> > There is a collection of the current component clock child nodes for each
> > clksel instance. I got warnings with "additionalProperties: false", but
> > maybe the child clock nodes need to be somehow specified in the binding?
> 
> If everything else is a child node, then you can do:
> 
> additionalProperties:
>   type: object

OK thanks will do, the additional properties are always child nodes.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-10 10:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 11:36 [PATCH] dt-bindings: clock: Add binding for TI clksel Tony Lindgren
2021-12-17 11:36 ` Tony Lindgren
2021-12-21 18:13 ` Rob Herring
2021-12-21 18:13   ` Rob Herring
2021-12-22  6:24   ` Tony Lindgren
2021-12-22  6:24     ` Tony Lindgren
2022-01-04 22:05     ` Rob Herring
2022-01-04 22:05       ` Rob Herring
2022-01-10 10:30       ` Tony Lindgren [this message]
2022-01-10 10:30         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YdwK3haVDCxyIioo@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.