* [PATCH] drm/amdgpu: not return error on the init_apu_flags
@ 2022-01-10 2:25 Prike Liang
2022-01-10 11:46 ` Huang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Prike Liang @ 2022-01-10 2:25 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Prike Liang, ray.huang
In some APU project we needn't always assign flags to identify each other,
so we may not need return an error.
Change-Id: I92c1acb9ffbdba7e9a68469163911801db262412
Signed-off-by: Prike Liang <Prike.Liang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4322d92c25c7..2a6671f37336 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1449,7 +1449,7 @@ static int amdgpu_device_init_apu_flags(struct amdgpu_device *adev)
adev->apu_flags |= AMD_APU_IS_CYAN_SKILLFISH2;
break;
default:
- return -EINVAL;
+ break;
}
return 0;
@@ -3497,9 +3497,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
mutex_init(&adev->psp.mutex);
mutex_init(&adev->notifier_lock);
- r = amdgpu_device_init_apu_flags(adev);
- if (r)
- return r;
+ amdgpu_device_init_apu_flags(adev);
r = amdgpu_device_check_arguments(adev);
if (r)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: not return error on the init_apu_flags
2022-01-10 2:25 [PATCH] drm/amdgpu: not return error on the init_apu_flags Prike Liang
@ 2022-01-10 11:46 ` Huang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Huang Rui @ 2022-01-10 11:46 UTC (permalink / raw)
To: Liang, Prike; +Cc: Deucher, Alexander, amd-gfx@lists.freedesktop.org
On Mon, Jan 10, 2022 at 10:25:57AM +0800, Liang, Prike wrote:
> In some APU project we needn't always assign flags to identify each other,
> so we may not need return an error.
>
> Change-Id: I92c1acb9ffbdba7e9a68469163911801db262412
> Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Please remove the Change-Id. With that fixed, patch is
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 4322d92c25c7..2a6671f37336 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1449,7 +1449,7 @@ static int amdgpu_device_init_apu_flags(struct amdgpu_device *adev)
> adev->apu_flags |= AMD_APU_IS_CYAN_SKILLFISH2;
> break;
> default:
> - return -EINVAL;
> + break;
> }
>
> return 0;
> @@ -3497,9 +3497,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,
> mutex_init(&adev->psp.mutex);
> mutex_init(&adev->notifier_lock);
>
> - r = amdgpu_device_init_apu_flags(adev);
> - if (r)
> - return r;
> + amdgpu_device_init_apu_flags(adev);
>
> r = amdgpu_device_check_arguments(adev);
> if (r)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-10 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-10 2:25 [PATCH] drm/amdgpu: not return error on the init_apu_flags Prike Liang
2022-01-10 11:46 ` Huang Rui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.