* [PATCH] gvisor: add some missing definitions to vmx.h
@ 2022-01-23 19:53 Ayush Ranjan
2022-01-24 9:43 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Ayush Ranjan @ 2022-01-23 19:53 UTC (permalink / raw)
To: Paolo Bonzini, Thomas Gleixner
Cc: Ben Gardon, Jim Mattson, Andrei Vagin, kvm, linux-kernel,
Michael Davidson, Ayush Ranjan
From: Michael Davidson <md@google.com>
gvisor needs definitions for some additional secondary exec controls.
Tested: builds
Signed-off-by: Ayush Ranjan <ayushranjan@google.com>
Signed-off-by: Michael Davidson <md@google.com>
---
arch/x86/include/asm/vmx.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index c77ad687cdf7..df40dc568eb9 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -67,6 +67,7 @@
#define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)
#define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)
#define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING)
+#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)
#define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)
#define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)
#define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)
--
2.35.0.rc0.227.g00780c9af4-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] gvisor: add some missing definitions to vmx.h
2022-01-23 19:53 [PATCH] gvisor: add some missing definitions to vmx.h Ayush Ranjan
@ 2022-01-24 9:43 ` Paolo Bonzini
2022-01-24 17:04 ` Sean Christopherson
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2022-01-24 9:43 UTC (permalink / raw)
To: Ayush Ranjan, Thomas Gleixner
Cc: Ben Gardon, Jim Mattson, Andrei Vagin, kvm, linux-kernel,
Michael Davidson
On 1/23/22 20:53, Ayush Ranjan wrote:
> From: Michael Davidson <md@google.com>
>
> gvisor needs definitions for some additional secondary exec controls.
>
> Tested: builds
> Signed-off-by: Ayush Ranjan <ayushranjan@google.com>
> Signed-off-by: Michael Davidson <md@google.com>
Incorrect order of the Signed-off-by header (author goes first,
submitter goes last).
> ---
> arch/x86/include/asm/vmx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index c77ad687cdf7..df40dc568eb9 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -67,6 +67,7 @@
> #define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)
> #define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)
> #define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING)
> +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)
> #define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)
> #define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)
> #define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)
I'm not sure why gvisor would care about an internal Linux header.
gvisor should only use arch/x86/include/uapi headers.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gvisor: add some missing definitions to vmx.h
2022-01-24 9:43 ` Paolo Bonzini
@ 2022-01-24 17:04 ` Sean Christopherson
2022-01-25 8:50 ` Ayush Ranjan
0 siblings, 1 reply; 4+ messages in thread
From: Sean Christopherson @ 2022-01-24 17:04 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Ayush Ranjan, Thomas Gleixner, Ben Gardon, Jim Mattson,
Andrei Vagin, kvm, linux-kernel, Michael Davidson
On Mon, Jan 24, 2022, Paolo Bonzini wrote:
> On 1/23/22 20:53, Ayush Ranjan wrote:
> > From: Michael Davidson <md@google.com>
> >
> > gvisor needs definitions for some additional secondary exec controls.
> >
> > Tested: builds
> > Signed-off-by: Ayush Ranjan <ayushranjan@google.com>
> > Signed-off-by: Michael Davidson <md@google.com>
>
> Incorrect order of the Signed-off-by header (author goes first, submitter
> goes last).
>
> > ---
> > arch/x86/include/asm/vmx.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> > index c77ad687cdf7..df40dc568eb9 100644
> > --- a/arch/x86/include/asm/vmx.h
> > +++ b/arch/x86/include/asm/vmx.h
> > @@ -67,6 +67,7 @@
> > #define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)
> > #define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)
> > #define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING)
> > +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)
> > #define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)
> > #define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)
> > #define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)
>
> I'm not sure why gvisor would care about an internal Linux header. gvisor
> should only use arch/x86/include/uapi headers.
It's Google-internal kernel crud, this patch should not be merged. Though with a
bit of patience, an equivalent patch will come with TDX support. If we do merge
something before TDX, I'd strongly prefer to take that "complete" version with a
rewritten changelog.
[*] https://lore.kernel.org/all/e519d6ae1e75a4bea494bb3940e1272e935ead18.1625186503.git.isaku.yamahata@intel.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gvisor: add some missing definitions to vmx.h
2022-01-24 17:04 ` Sean Christopherson
@ 2022-01-25 8:50 ` Ayush Ranjan
0 siblings, 0 replies; 4+ messages in thread
From: Ayush Ranjan @ 2022-01-25 8:50 UTC (permalink / raw)
To: Sean Christopherson
Cc: Paolo Bonzini, Thomas Gleixner, Ben Gardon, Jim Mattson,
Andrei Vagin, kvm, linux-kernel, Michael Davidson
Abandoning this patch in favor of the more complete series of work quoted above.
On Mon, Jan 24, 2022 at 9:04 AM Sean Christopherson <seanjc@google.com> wrote:
>
> On Mon, Jan 24, 2022, Paolo Bonzini wrote:
> > On 1/23/22 20:53, Ayush Ranjan wrote:
> > > From: Michael Davidson <md@google.com>
> > >
> > > gvisor needs definitions for some additional secondary exec controls.
> > >
> > > Tested: builds
> > > Signed-off-by: Ayush Ranjan <ayushranjan@google.com>
> > > Signed-off-by: Michael Davidson <md@google.com>
> >
> > Incorrect order of the Signed-off-by header (author goes first, submitter
> > goes last).
> >
> > > ---
> > > arch/x86/include/asm/vmx.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> > > index c77ad687cdf7..df40dc568eb9 100644
> > > --- a/arch/x86/include/asm/vmx.h
> > > +++ b/arch/x86/include/asm/vmx.h
> > > @@ -67,6 +67,7 @@
> > > #define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)
> > > #define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)
> > > #define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING)
> > > +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)
> > > #define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)
> > > #define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)
> > > #define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)
> >
> > I'm not sure why gvisor would care about an internal Linux header. gvisor
> > should only use arch/x86/include/uapi headers.
>
> It's Google-internal kernel crud, this patch should not be merged. Though with a
> bit of patience, an equivalent patch will come with TDX support. If we do merge
> something before TDX, I'd strongly prefer to take that "complete" version with a
> rewritten changelog.
>
> [*] https://lore.kernel.org/all/e519d6ae1e75a4bea494bb3940e1272e935ead18.1625186503.git.isaku.yamahata@intel.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-25 9:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-23 19:53 [PATCH] gvisor: add some missing definitions to vmx.h Ayush Ranjan
2022-01-24 9:43 ` Paolo Bonzini
2022-01-24 17:04 ` Sean Christopherson
2022-01-25 8:50 ` Ayush Ranjan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.