All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	DRI Devel <dri-devel@lists.freedesktop.org>,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files
Date: Tue, 18 Jan 2022 14:49:47 +0200	[thread overview]
Message-ID: <Yea3a6fTYEqs6FSg@intel.intel> (raw)
In-Reply-To: <c2fe4be4-8b7b-6aae-7477-a4da8e3ac337@linux.intel.com>

Hi Tvrtko,

> > +bool is_object_gt(struct kobject *kobj)
> 
> Not sure if you will need it exported in a later patch but for now it seems
> only users are local to this file.

it is actually used by sysfs_gt.c and sysfs_gt_pm.c.

Thank you,
Andi

PS. in this v4 I forgot to replace many drm_err() with
    drm_warn(), will do it properly in the next version.

WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	DRI Devel <dri-devel@lists.freedesktop.org>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files
Date: Tue, 18 Jan 2022 14:49:47 +0200	[thread overview]
Message-ID: <Yea3a6fTYEqs6FSg@intel.intel> (raw)
In-Reply-To: <c2fe4be4-8b7b-6aae-7477-a4da8e3ac337@linux.intel.com>

Hi Tvrtko,

> > +bool is_object_gt(struct kobject *kobj)
> 
> Not sure if you will need it exported in a later patch but for now it seems
> only users are local to this file.

it is actually used by sysfs_gt.c and sysfs_gt_pm.c.

Thank you,
Andi

PS. in this v4 I forgot to replace many drm_err() with
    drm_warn(), will do it properly in the next version.

  reply	other threads:[~2022-01-18 12:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 19:32 [Intel-gfx] [PATCH v4 0/2] Introduce multitile support Andi Shyti
2022-01-17 19:32 ` Andi Shyti
2022-01-17 19:32 ` [Intel-gfx] [PATCH v4 1/2] drm/i915: Prepare for multiple GTs Andi Shyti
2022-01-17 19:32   ` Andi Shyti
2022-01-17 22:24   ` [Intel-gfx] " Michal Wajdeczko
2022-01-17 22:24     ` Michal Wajdeczko
2022-01-17 23:12     ` [Intel-gfx] " Andi Shyti
2022-01-17 23:12       ` Andi Shyti
2022-01-17 19:32 ` [Intel-gfx] [PATCH v4 2/2] drm/i915/gt: make a gt sysfs group and move power management files Andi Shyti
2022-01-17 19:32   ` Andi Shyti
2022-01-17 22:49   ` [Intel-gfx] " Michal Wajdeczko
2022-01-17 22:49     ` Michal Wajdeczko
2022-01-18  0:00     ` [Intel-gfx] " Andi Shyti
2022-01-18  0:00       ` Andi Shyti
2022-01-18 11:16   ` [Intel-gfx] " Tvrtko Ursulin
2022-01-18 12:49     ` Andi Shyti [this message]
2022-01-18 12:49       ` Andi Shyti
2022-01-17 19:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Introduce multitile support Patchwork
2022-01-17 19:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-17 20:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-17 21:32 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yea3a6fTYEqs6FSg@intel.intel \
    --to=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.