From: Abel Vesa <abel.vesa@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jacky Bai <ping.bai@nxp.com>
Subject: Re: [PATCH] clk: imx: Add imx8dxl clk driver
Date: Tue, 18 Jan 2022 12:23:43 +0200 [thread overview]
Message-ID: <YeaVL33SMFHc8pZ3@abelvesa> (raw)
In-Reply-To: <YeaT6pGCo2wUGEFf@abelvesa>
On 22-01-18 12:18:18, Abel Vesa wrote:
> On 21-12-16 10:50:23, Stephen Boyd wrote:
> > Quoting Abel Vesa (2021-11-10 09:56:40)
> > > diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
> > > index c53a688d8ccc..7f4893706cc2 100644
> > > --- a/drivers/clk/imx/clk-imx8qxp.c
> > > +++ b/drivers/clk/imx/clk-imx8qxp.c
> > > @@ -297,6 +297,7 @@ static const struct of_device_id imx8qxp_match[] = {
> > > { .compatible = "fsl,scu-clk", },
> > > { .compatible = "fsl,imx8qxp-clk", &imx_clk_scu_rsrc_imx8qxp, },
> > > { .compatible = "fsl,imx8qm-clk", &imx_clk_scu_rsrc_imx8qm, },
> > > + { .compatible = "fsl,imx8dxl-clk", &imx_clk_scu_rsrc_imx8dxl, },
> >
> > Can you keep this sorted on compatible string? Then we don't have to
> > worry about conflicts as much.
> >
>
> Yep. Will resend.
Actually, v2 is right here:
https://lore.kernel.org/linux-arm-kernel/1639747533-9778-1-git-send-email-abel.vesa@nxp.com/
You ACK'ed it already. And it adds the dxl compatible in the right spot.
>
> > > { /* sentinel */ }
> > > };
> > >
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jacky Bai <ping.bai@nxp.com>
Subject: Re: [PATCH] clk: imx: Add imx8dxl clk driver
Date: Tue, 18 Jan 2022 12:23:43 +0200 [thread overview]
Message-ID: <YeaVL33SMFHc8pZ3@abelvesa> (raw)
In-Reply-To: <YeaT6pGCo2wUGEFf@abelvesa>
On 22-01-18 12:18:18, Abel Vesa wrote:
> On 21-12-16 10:50:23, Stephen Boyd wrote:
> > Quoting Abel Vesa (2021-11-10 09:56:40)
> > > diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
> > > index c53a688d8ccc..7f4893706cc2 100644
> > > --- a/drivers/clk/imx/clk-imx8qxp.c
> > > +++ b/drivers/clk/imx/clk-imx8qxp.c
> > > @@ -297,6 +297,7 @@ static const struct of_device_id imx8qxp_match[] = {
> > > { .compatible = "fsl,scu-clk", },
> > > { .compatible = "fsl,imx8qxp-clk", &imx_clk_scu_rsrc_imx8qxp, },
> > > { .compatible = "fsl,imx8qm-clk", &imx_clk_scu_rsrc_imx8qm, },
> > > + { .compatible = "fsl,imx8dxl-clk", &imx_clk_scu_rsrc_imx8dxl, },
> >
> > Can you keep this sorted on compatible string? Then we don't have to
> > worry about conflicts as much.
> >
>
> Yep. Will resend.
Actually, v2 is right here:
https://lore.kernel.org/linux-arm-kernel/1639747533-9778-1-git-send-email-abel.vesa@nxp.com/
You ACK'ed it already. And it adds the dxl compatible in the right spot.
>
> > > { /* sentinel */ }
> > > };
> > >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-18 10:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 17:56 [PATCH] clk: imx: Add imx8dxl clk driver Abel Vesa
2021-11-10 17:56 ` Abel Vesa
2021-12-16 16:14 ` Abel Vesa
2021-12-16 16:14 ` Abel Vesa
2021-12-16 18:50 ` Stephen Boyd
2021-12-16 18:50 ` Stephen Boyd
2022-01-18 10:18 ` Abel Vesa
2022-01-18 10:18 ` Abel Vesa
2022-01-18 10:23 ` Abel Vesa [this message]
2022-01-18 10:23 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeaVL33SMFHc8pZ3@abelvesa \
--to=abel.vesa@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.