From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Gabriel Krisman Bertazi <krisman@collabora.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: unicode: clean up the Kconfig symbol confusion
Date: Tue, 18 Jan 2022 11:00:20 -0800 [thread overview]
Message-ID: <YecORDbXEmi9cFwC@sol.localdomain> (raw)
In-Reply-To: <20220118065614.1241470-1-hch@lst.de>
On Tue, Jan 18, 2022 at 07:56:14AM +0100, Christoph Hellwig wrote:
> Turn the CONFIG_UNICODE symbol into a tristate that generates some always
> built in code and remove the confusing CONFIG_UNICODE_UTF8_DATA symbol.
>
> Note that a lot of the IS_ENALBED() checks could be turned from cpp
> statements into normal ifs, but this change is intended to be fairly
> mechanic, so that should be cleaned up later.
>
> Fixes: 2b3d04787012 ("unicode: Add utf8-data module")
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me,
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
linux-ext4@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] unicode: clean up the Kconfig symbol confusion
Date: Tue, 18 Jan 2022 11:00:20 -0800 [thread overview]
Message-ID: <YecORDbXEmi9cFwC@sol.localdomain> (raw)
In-Reply-To: <20220118065614.1241470-1-hch@lst.de>
On Tue, Jan 18, 2022 at 07:56:14AM +0100, Christoph Hellwig wrote:
> Turn the CONFIG_UNICODE symbol into a tristate that generates some always
> built in code and remove the confusing CONFIG_UNICODE_UTF8_DATA symbol.
>
> Note that a lot of the IS_ENALBED() checks could be turned from cpp
> statements into normal ifs, but this change is intended to be fairly
> mechanic, so that should be cleaned up later.
>
> Fixes: 2b3d04787012 ("unicode: Add utf8-data module")
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me,
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-01-18 19:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 6:56 [PATCH] unicode: clean up the Kconfig symbol confusion Christoph Hellwig
2022-01-18 6:56 ` [f2fs-dev] " Christoph Hellwig
2022-01-18 19:00 ` Eric Biggers [this message]
2022-01-18 19:00 ` [f2fs-dev] " Eric Biggers
2022-01-19 8:28 ` [PATCH] " Linus Torvalds
2022-01-19 8:28 ` [f2fs-dev] " Linus Torvalds
2022-01-21 1:10 ` Gabriel Krisman Bertazi
2022-01-21 1:10 ` [f2fs-dev] " Gabriel Krisman Bertazi
2022-01-24 9:08 ` Christoph Hellwig
2022-01-24 9:08 ` [f2fs-dev] " Christoph Hellwig
2022-01-31 6:44 ` Christoph Hellwig
2022-01-31 6:44 ` [f2fs-dev] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YecORDbXEmi9cFwC@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.