From: Borislav Petkov <bp@alien8.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org,
x86@kernel.org, Lucas De Marchi <lucas.demarchi@intel.com>,
stable@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Intel-gfx] [PATCH v5 1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU
Date: Tue, 18 Jan 2022 21:31:07 +0100 [thread overview]
Message-ID: <Yecji9MQQhQiCcel@zn.tnic> (raw)
In-Reply-To: <20220118200145.GA887728@bhelgaas>
On Tue, Jan 18, 2022 at 02:01:45PM -0600, Bjorn Helgaas wrote:
> Haha :) I was hoping not to touch it myself because I think this
> whole stolen memory thing is kind of nasty. It's not clear to me why
> we need it at all, or why we have to keep all this device-specific
> logic in the kernel, or why it has to be an early quirk as opposed to
> a regular PCI quirk. We had a thread [1] about it a while ago but I
> don't think anything got resolved.
/me goes and skims over it.
OMG, what a mess. And OEM BIOS is involved.
Makes me wanna run away screaming.
> But to try to make forward progress, I applied patch 1/5 (actually,
> the updated one from [2]) to my pci/misc branch with the updated
> commit log and code comments below.
Yap.
And if that stops the continuous stream of new-platform-addition
patches, even better.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: x86@kernel.org, linux-pci@vger.kernel.org,
intel-gfx@lists.freedesktop.org,
Dave Hansen <dave.hansen@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
stable@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Intel-gfx] [PATCH v5 1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU
Date: Tue, 18 Jan 2022 21:31:07 +0100 [thread overview]
Message-ID: <Yecji9MQQhQiCcel@zn.tnic> (raw)
In-Reply-To: <20220118200145.GA887728@bhelgaas>
On Tue, Jan 18, 2022 at 02:01:45PM -0600, Bjorn Helgaas wrote:
> Haha :) I was hoping not to touch it myself because I think this
> whole stolen memory thing is kind of nasty. It's not clear to me why
> we need it at all, or why we have to keep all this device-specific
> logic in the kernel, or why it has to be an early quirk as opposed to
> a regular PCI quirk. We had a thread [1] about it a while ago but I
> don't think anything got resolved.
/me goes and skims over it.
OMG, what a mess. And OEM BIOS is involved.
Makes me wanna run away screaming.
> But to try to make forward progress, I applied patch 1/5 (actually,
> the updated one from [2]) to my pci/misc branch with the updated
> commit log and code comments below.
Yap.
And if that stops the continuous stream of new-platform-addition
patches, even better.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-01-18 20:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 0:28 [Intel-gfx] [PATCH v5 1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU Lucas De Marchi
2022-01-14 0:28 ` Lucas De Marchi
2022-01-14 0:28 ` [Intel-gfx] [PATCH v5 2/5] x86/quirks: Stop using QFLAG_APPLY_ONCE in via_bugs() Lucas De Marchi
2022-01-14 0:28 ` Lucas De Marchi
2022-01-14 0:28 ` [Intel-gfx] [PATCH v5 3/5] x86/quirks: Stop using QFLAG_APPLY_ONCE in nvidia_bugs() Lucas De Marchi
2022-01-14 0:28 ` Lucas De Marchi
2022-01-14 0:28 ` [Intel-gfx] [PATCH v5 4/5] x86/quirks: Remove unused logic for flags Lucas De Marchi
2022-01-14 0:28 ` Lucas De Marchi
2022-01-14 0:28 ` [Intel-gfx] [PATCH v5 5/5] x86/quirks: Improve line wrap on quirk conditions Lucas De Marchi
2022-01-14 0:28 ` Lucas De Marchi
2022-01-14 1:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU Patchwork
2022-01-14 2:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-01-18 9:40 ` [Intel-gfx] [PATCH v5 1/5] " Borislav Petkov
2022-01-18 9:40 ` Borislav Petkov
2022-01-18 16:36 ` [Intel-gfx] " Lucas De Marchi
2022-01-18 16:36 ` Lucas De Marchi
2022-01-18 17:26 ` [Intel-gfx] " Borislav Petkov
2022-01-18 17:26 ` Borislav Petkov
2022-01-18 17:58 ` [Intel-gfx] " Bjorn Helgaas
2022-01-18 17:58 ` Bjorn Helgaas
2022-01-18 18:37 ` Borislav Petkov
2022-01-18 18:37 ` Borislav Petkov
2022-01-18 20:01 ` Bjorn Helgaas
2022-01-18 20:01 ` Bjorn Helgaas
2022-01-18 20:31 ` Borislav Petkov [this message]
2022-01-18 20:31 ` Borislav Petkov
2022-01-19 20:30 ` Lucas De Marchi
2022-01-19 20:30 ` Lucas De Marchi
2022-01-19 20:58 ` Bjorn Helgaas
2022-01-19 20:58 ` Bjorn Helgaas
2022-01-18 19:05 ` Lucas De Marchi
2022-01-18 19:05 ` Lucas De Marchi
2022-01-18 19:14 ` [Intel-gfx] " Borislav Petkov
2022-01-18 19:14 ` Borislav Petkov
2022-01-18 19:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [v5,1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU (rev2) Patchwork
2022-01-18 20:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v5,1/5] x86/quirks: Fix stolen detection with integrated + discrete GPU (rev3) Patchwork
2022-01-18 20:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-01-18 23:01 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yecji9MQQhQiCcel@zn.tnic \
--to=bp@alien8.de \
--cc=bhelgaas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-pci@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.