From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: Alistair Francis <alistair.francis@wdc.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] meson.build: Use a function from libfdt 1.5.1 for the library check
Date: Wed, 19 Jan 2022 10:27:50 +1100 [thread overview]
Message-ID: <YedM9icYA+S5OMT7@yekko> (raw)
In-Reply-To: <20220118170548.97288-1-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
On Tue, Jan 18, 2022 at 06:05:48PM +0100, Thomas Huth wrote:
> The fdt version test in meson.build uses a function from libfdt v1.4.7,
> but we require version 1.5.1 nowadays. Thus use a function that has
> been introduced in that version instead.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/822
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 762d7cee85..d1cc04c7a2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2276,7 +2276,7 @@ if have_system
> if fdt.found() and cc.links('''
> #include <libfdt.h>
> #include <libfdt_env.h>
> - int main(void) { fdt_check_full(NULL, 0); return 0; }''',
> + int main(void) { fdt_find_max_phandle(NULL, NULL); return 0; }''',
> dependencies: fdt)
> fdt_opt = 'system'
> elif fdt_opt == 'system'
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Alistair Francis <alistair.francis@wdc.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] meson.build: Use a function from libfdt 1.5.1 for the library check
Date: Wed, 19 Jan 2022 10:27:50 +1100 [thread overview]
Message-ID: <YedM9icYA+S5OMT7@yekko> (raw)
In-Reply-To: <20220118170548.97288-1-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]
On Tue, Jan 18, 2022 at 06:05:48PM +0100, Thomas Huth wrote:
> The fdt version test in meson.build uses a function from libfdt v1.4.7,
> but we require version 1.5.1 nowadays. Thus use a function that has
> been introduced in that version instead.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/822
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 762d7cee85..d1cc04c7a2 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2276,7 +2276,7 @@ if have_system
> if fdt.found() and cc.links('''
> #include <libfdt.h>
> #include <libfdt_env.h>
> - int main(void) { fdt_check_full(NULL, 0); return 0; }''',
> + int main(void) { fdt_find_max_phandle(NULL, NULL); return 0; }''',
> dependencies: fdt)
> fdt_opt = 'system'
> elif fdt_opt == 'system'
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-19 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 17:05 [PATCH] meson.build: Use a function from libfdt 1.5.1 for the library check Thomas Huth
2022-01-18 17:52 ` Philippe Mathieu-Daudé
2022-01-18 17:52 ` Philippe Mathieu-Daudé via
2022-01-18 22:34 ` Alistair Francis
2022-01-18 22:34 ` Alistair Francis
2022-01-18 23:27 ` David Gibson [this message]
2022-01-18 23:27 ` David Gibson
2022-01-19 8:49 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YedM9icYA+S5OMT7@yekko \
--to=david@gibson.dropbear.id.au \
--cc=alistair.francis@wdc.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.