From: Rob Herring <robh@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] dt-bindings: mtd: partitions: Document new dynamic-partitions node
Date: Thu, 20 Jan 2022 19:49:26 -0600 [thread overview]
Message-ID: <YeoRJlTbILNtZgoW@robh.at.kernel.org> (raw)
In-Reply-To: <20220120202615.28076-2-ansuelsmth@gmail.com>
On Thu, Jan 20, 2022 at 09:26:14PM +0100, Ansuel Smith wrote:
> Document new dynamic-partitions node used to provide an of node for
> partition registred at runtime by parsers. This is required for nvmem
> system to declare and detect nvmem-cells.
So you have some discoverable way to find all the partitions and the
nvmem cells are at an unknown (to the DT) location, but still need to be
described in DT?
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../mtd/partitions/dynamic-partitions.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml
> new file mode 100644
> index 000000000000..7528e49f2d7e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/partitions/dynamic-partitions.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dynamic partitions
> +
> +description: |
> + This binding can be used on platforms which have partitions registered at
> + runtime by parsers or partition table present on the flash. Example are
> + partitions declared from smem parser or cmdlinepart. This will create an
Some information in DT and some on the cmdline seems broken to me. Pick
one or the other.
> + of node for these dynamic partition where systems like Nvmem can get a
> + reference to register nvmem-cells.
> +
> + The partition table should be a node named "dynamic-partitions".
> + Partitions are then defined as subnodes. Only the label is required
> + as any other data will be taken from the parser.
> +
> +maintainers:
> + - Ansuel Smith <ansuelsmth@gmail.com>
> +
> +properties:
> + compatible:
> + const: dynamic-partitions
This is useless. This tells me nothing about the what's in the
partitions.
> +
> +patternProperties:
> + "@[0-9a-f]+$":
> + $ref: "partition.yaml#"
> +
> +additionalProperties: true
> +
> +examples:
> + - |
> + partitions {
> + compatible = "qcom,smem";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> + dynamic-partitions {
> + compatible = "dynamic-partitions";
> +
> + art: art {
> + label = "0:art";
> + read-only;
> + compatible = "nvmem-cells";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + macaddr_art_0: macaddr@0 {
> + reg = <0x0 0x6>;
> + };
> +
> + macaddr_art_6: macaddr@6 {
> + reg = <0x6 0x6>;
> + };
> + };
> + };
> --
> 2.33.1
>
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] dt-bindings: mtd: partitions: Document new dynamic-partitions node
Date: Thu, 20 Jan 2022 19:49:26 -0600 [thread overview]
Message-ID: <YeoRJlTbILNtZgoW@robh.at.kernel.org> (raw)
In-Reply-To: <20220120202615.28076-2-ansuelsmth@gmail.com>
On Thu, Jan 20, 2022 at 09:26:14PM +0100, Ansuel Smith wrote:
> Document new dynamic-partitions node used to provide an of node for
> partition registred at runtime by parsers. This is required for nvmem
> system to declare and detect nvmem-cells.
So you have some discoverable way to find all the partitions and the
nvmem cells are at an unknown (to the DT) location, but still need to be
described in DT?
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../mtd/partitions/dynamic-partitions.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml b/Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml
> new file mode 100644
> index 000000000000..7528e49f2d7e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/partitions/dynamic-partitions.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/partitions/dynamic-partitions.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dynamic partitions
> +
> +description: |
> + This binding can be used on platforms which have partitions registered at
> + runtime by parsers or partition table present on the flash. Example are
> + partitions declared from smem parser or cmdlinepart. This will create an
Some information in DT and some on the cmdline seems broken to me. Pick
one or the other.
> + of node for these dynamic partition where systems like Nvmem can get a
> + reference to register nvmem-cells.
> +
> + The partition table should be a node named "dynamic-partitions".
> + Partitions are then defined as subnodes. Only the label is required
> + as any other data will be taken from the parser.
> +
> +maintainers:
> + - Ansuel Smith <ansuelsmth@gmail.com>
> +
> +properties:
> + compatible:
> + const: dynamic-partitions
This is useless. This tells me nothing about the what's in the
partitions.
> +
> +patternProperties:
> + "@[0-9a-f]+$":
> + $ref: "partition.yaml#"
> +
> +additionalProperties: true
> +
> +examples:
> + - |
> + partitions {
> + compatible = "qcom,smem";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> + dynamic-partitions {
> + compatible = "dynamic-partitions";
> +
> + art: art {
> + label = "0:art";
> + read-only;
> + compatible = "nvmem-cells";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + macaddr_art_0: macaddr@0 {
> + reg = <0x0 0x6>;
> + };
> +
> + macaddr_art_6: macaddr@6 {
> + reg = <0x6 0x6>;
> + };
> + };
> + };
> --
> 2.33.1
>
>
next prev parent reply other threads:[~2022-01-21 1:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 20:26 [RFC PATCH 0/2] Add nvmem support for dynamic partitions Ansuel Smith
2022-01-20 20:26 ` Ansuel Smith
2022-01-20 20:26 ` [RFC PATCH 1/2] dt-bindings: mtd: partitions: Document new dynamic-partitions node Ansuel Smith
2022-01-20 20:26 ` Ansuel Smith
2022-01-20 22:32 ` Rob Herring
2022-01-20 22:32 ` Rob Herring
2022-01-21 1:49 ` Rob Herring [this message]
2022-01-21 1:49 ` Rob Herring
2022-01-22 0:29 ` Ansuel Smith
2022-01-22 0:29 ` Ansuel Smith
2022-01-24 22:02 ` Rafał Miłecki
2022-01-24 22:02 ` Rafał Miłecki
2022-01-24 22:12 ` Ansuel Smith
2022-01-24 22:12 ` Ansuel Smith
2022-01-25 20:21 ` Rafał Miłecki
2022-01-25 20:21 ` Rafał Miłecki
2022-01-25 20:30 ` Ansuel Smith
2022-01-25 20:30 ` Ansuel Smith
2022-01-20 20:26 ` [RFC PATCH 2/2] mtd: core: introduce of support for dynamic partitions Ansuel Smith
2022-01-20 20:26 ` Ansuel Smith
2022-01-21 2:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YeoRJlTbILNtZgoW@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.