All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2
Date: Sun, 6 Feb 2022 15:34:46 +0100	[thread overview]
Message-ID: <Yf/chpjM6KaLCJ6h@pevik> (raw)
In-Reply-To: <87tudcw0zg.fsf@dell.be.48ers.dk>

Hi Peter,

> >>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

> s/used/uses/ in the subject naturally.

+1

>  > nfsiostat is a python3 script, so keep it if python3 is enabled and not
>  > python2:

Good catch, thanks!
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr

>  > head -n 1 target/usr/sbin/nfsiostat
>  >  #!/usr/bin/python3

>  > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>  > ---
>  >  package/nfs-utils/nfs-utils.mk | 2 +-
>  >  1 file changed, 1 insertion(+), 1 deletion(-)

>  > diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
>  > index 6a3a801359..44653e2707 100644
>  > --- a/package/nfs-utils/nfs-utils.mk
>  > +++ b/package/nfs-utils/nfs-utils.mk
>  > @@ -114,7 +114,7 @@ define NFS_UTILS_REMOVE_NFSIOSTAT
>  >  endef

>  >  # nfsiostat is interpreted python, so remove it unless it's in the target
>  > -NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON),,NFS_UTILS_REMOVE_NFSIOSTAT)
>  > +NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON3),,NFS_UTILS_REMOVE_NFSIOSTAT)

>  >  define HOST_NFS_UTILS_BUILD_CMDS
>  >  	$(MAKE) -C $(@D)/tools/rpcgen
>  > -- 
>  > 2.20.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-02-06 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 13:17 [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2 Peter Korsgaard
2022-02-06 13:58 ` Peter Korsgaard
2022-02-06 14:34   ` Petr Vorel [this message]
2022-02-06 14:56     ` Peter Korsgaard
2022-02-17 16:34   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yf/chpjM6KaLCJ6h@pevik \
    --to=petr.vorel@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=peter@korsgaard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.