* [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2
@ 2022-02-06 13:17 Peter Korsgaard
2022-02-06 13:58 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Peter Korsgaard @ 2022-02-06 13:17 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti
nfsiostat is a python3 script, so keep it if python3 is enabled and not
python2:
head -n 1 target/usr/sbin/nfsiostat
#!/usr/bin/python3
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/nfs-utils/nfs-utils.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
index 6a3a801359..44653e2707 100644
--- a/package/nfs-utils/nfs-utils.mk
+++ b/package/nfs-utils/nfs-utils.mk
@@ -114,7 +114,7 @@ define NFS_UTILS_REMOVE_NFSIOSTAT
endef
# nfsiostat is interpreted python, so remove it unless it's in the target
-NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON),,NFS_UTILS_REMOVE_NFSIOSTAT)
+NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON3),,NFS_UTILS_REMOVE_NFSIOSTAT)
define HOST_NFS_UTILS_BUILD_CMDS
$(MAKE) -C $(@D)/tools/rpcgen
--
2.20.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2
2022-02-06 13:17 [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2 Peter Korsgaard
@ 2022-02-06 13:58 ` Peter Korsgaard
2022-02-06 14:34 ` Petr Vorel
2022-02-17 16:34 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-02-06 13:58 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
s/used/uses/ in the subject naturally.
> nfsiostat is a python3 script, so keep it if python3 is enabled and not
> python2:
> head -n 1 target/usr/sbin/nfsiostat
> #!/usr/bin/python3
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/nfs-utils/nfs-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index 6a3a801359..44653e2707 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -114,7 +114,7 @@ define NFS_UTILS_REMOVE_NFSIOSTAT
> endef
> # nfsiostat is interpreted python, so remove it unless it's in the target
> -NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON),,NFS_UTILS_REMOVE_NFSIOSTAT)
> +NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON3),,NFS_UTILS_REMOVE_NFSIOSTAT)
> define HOST_NFS_UTILS_BUILD_CMDS
> $(MAKE) -C $(@D)/tools/rpcgen
> --
> 2.20.1
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2
2022-02-06 13:58 ` Peter Korsgaard
@ 2022-02-06 14:34 ` Petr Vorel
2022-02-06 14:56 ` Peter Korsgaard
2022-02-17 16:34 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Petr Vorel @ 2022-02-06 14:34 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: Giulio Benetti, buildroot
Hi Peter,
> >>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> s/used/uses/ in the subject naturally.
+1
> > nfsiostat is a python3 script, so keep it if python3 is enabled and not
> > python2:
Good catch, thanks!
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Kind regards,
Petr
> > head -n 1 target/usr/sbin/nfsiostat
> > #!/usr/bin/python3
> > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> > ---
> > package/nfs-utils/nfs-utils.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> > index 6a3a801359..44653e2707 100644
> > --- a/package/nfs-utils/nfs-utils.mk
> > +++ b/package/nfs-utils/nfs-utils.mk
> > @@ -114,7 +114,7 @@ define NFS_UTILS_REMOVE_NFSIOSTAT
> > endef
> > # nfsiostat is interpreted python, so remove it unless it's in the target
> > -NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON),,NFS_UTILS_REMOVE_NFSIOSTAT)
> > +NFS_UTILS_POST_INSTALL_TARGET_HOOKS += $(if $(BR2_PACKAGE_PYTHON3),,NFS_UTILS_REMOVE_NFSIOSTAT)
> > define HOST_NFS_UTILS_BUILD_CMDS
> > $(MAKE) -C $(@D)/tools/rpcgen
> > --
> > 2.20.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2
2022-02-06 14:34 ` Petr Vorel
@ 2022-02-06 14:56 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-02-06 14:56 UTC (permalink / raw)
To: Petr Vorel; +Cc: Giulio Benetti, buildroot
>>>>> "Petr" == Petr Vorel <petr.vorel@gmail.com> writes:
> Hi Peter,
>> >>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>> s/used/uses/ in the subject naturally.
> +1
>> > nfsiostat is a python3 script, so keep it if python3 is enabled and not
>> > python2:
> Good catch, thanks!
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Committed, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2
2022-02-06 13:58 ` Peter Korsgaard
2022-02-06 14:34 ` Petr Vorel
@ 2022-02-17 16:34 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-02-17 16:34 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> s/used/uses/ in the subject naturally.
>> nfsiostat is a python3 script, so keep it if python3 is enabled and not
>> python2:
>> head -n 1 target/usr/sbin/nfsiostat
>> #!/usr/bin/python3
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed to 2021.02.x and 2021.11.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-17 16:34 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-06 13:17 [Buildroot] [PATCH] package/nfs-utils: nfsiostat used python3, not python2 Peter Korsgaard
2022-02-06 13:58 ` Peter Korsgaard
2022-02-06 14:34 ` Petr Vorel
2022-02-06 14:56 ` Peter Korsgaard
2022-02-17 16:34 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.