Re: [PATCH v2] arm64: move efi_reboot to restart handler

From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Krzysztof Adamski <krzysztof.adamski@nokia.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Peter Collingbourne <pcc@google.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Alexander Sverdlin <alexander.sverdlin@nokia.com>,
	Matija Glavinic-Pecotic <matija.glavinic-pecotic.ext@nokia.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: move efi_reboot to restart handler
Date: Sat, 29 Jan 2022 07:38:56 +0100	[thread overview]
Message-ID: <YfThAF9U1DJx0Hja@shikoro> (raw)
In-Reply-To: <YfRu86YoiFpVsqyn@localhost.localdomain>

[-- Attachment #1.1: Type: text/plain, Size: 1402 bytes --]

Hi Krzysztof,
> I would use something like 250, or even 254, just to indicate that we
> know that most certainly nothing should be run before efi_reboot(), but
> still allow those silly people like me, to do what they want in their
> system, without the need to run the custom kernel. I think we could even
> add a proper comment, so it woudld become something like:
> 
> /**
>  * If you are running UEFI based system, you most certainly should let
>  * efi_reboot() do a reset for you. If you think you know better, we
>  * leave you a window of opportunity here by not using maximal priorty
>  * here.
>  */
>  .priority = 250,

For your patchset, this seems good enough for me because it is decoupled
from PSCI now. I still think a set of defines should be collected in
linux/reboot.h so they can be used in reboot handlers. This is a
different patch series, though.

> What is the downside of doing that? That we will run through atomic
> notfier chain instead of calling efi_reboot directly? Sure this is
> slightly more complicated but it works on all our platforms and is
> battle proven and we don't worry about that there. And the upside is
> that we give people possibility to use their beloved mechanism if they
> really like to. Because flexibility is a good thing.

I agree with the upside having more value than the downside.

Happy hacking,

   Wolfram

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel