From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Stefan Reiter <s.reiter@proxmox.com>
Cc: "Wolfgang Bumiller" <w.bumiller@proxmox.com>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: Re: [PATCH v7 4/4] qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate
Date: Mon, 31 Jan 2022 16:07:17 +0000 [thread overview]
Message-ID: <YfgJNd+qBTYUjgNu@redhat.com> (raw)
In-Reply-To: <20211021100135.4146766-5-s.reiter@proxmox.com>
On Thu, Oct 21, 2021 at 12:01:35PM +0200, Stefan Reiter wrote:
> VNC only supports 'keep' here, enforce this via a seperate
> SetPasswordActionVnc enum and mark the option 'deprecated' (as it is
> useless with only one value possible).
>
> Also add a deprecation note to docs.
IMHO we should just implement 'fail' and 'disconnect' in the VNC
server. Consistency across SPICE and VNC is more user friendly
than restricting the available options, and all three policies
are useful behaviours for VNC.
So I'm not in favour of adding this deprecation.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-01-31 16:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 10:01 [PATCH v7 0/4] VNC-related HMP/QMP fixes Stefan Reiter
2021-10-21 10:01 ` [PATCH v7 1/4] monitor/hmp: add support for flag argument with value Stefan Reiter
2021-10-26 10:07 ` Dr. David Alan Gilbert
2021-10-29 19:51 ` Eric Blake
2021-10-21 10:01 ` [PATCH v7 2/4] qapi/monitor: refactor set/expire_password with enums Stefan Reiter
2022-01-20 13:32 ` Fabian Ebner
2022-01-20 15:28 ` Markus Armbruster
2021-10-21 10:01 ` [PATCH v7 3/4] qapi/monitor: allow VNC display id in set/expire_password Stefan Reiter
2021-10-21 10:38 ` Markus Armbruster
2021-10-26 10:12 ` Dr. David Alan Gilbert
2021-10-21 10:01 ` [PATCH v7 4/4] qapi/monitor: only allow 'keep' SetPasswordAction for VNC and deprecate Stefan Reiter
2022-01-31 16:07 ` Daniel P. Berrangé [this message]
2021-10-21 10:39 ` [PATCH v7 0/4] VNC-related HMP/QMP fixes Markus Armbruster
2021-10-26 10:18 ` Dr. David Alan Gilbert
2021-10-26 11:32 ` Markus Armbruster
2021-10-27 7:27 ` Gerd Hoffmann
2021-10-27 8:44 ` Dr. David Alan Gilbert
2021-10-28 5:25 ` Markus Armbruster
2021-10-28 19:37 ` Markus Armbruster
2022-01-11 14:18 ` Fabian Ebner
2022-01-13 15:52 ` Markus Armbruster
2022-01-21 13:20 ` Fabian Ebner
2022-01-21 15:54 ` Markus Armbruster
2022-01-24 13:50 ` Markus Armbruster
2022-01-24 13:50 ` Markus Armbruster
2022-01-25 15:06 ` Daniel P. Berrangé
2022-01-31 9:45 ` Fabian Ebner
2022-01-31 16:11 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfgJNd+qBTYUjgNu@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=s.reiter@proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.