All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Javier Martinez Canillas" <javierm@redhat.com>,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Maxime Ripard" <maxime@cerno.tech>
Subject: Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays
Date: Tue, 1 Feb 2022 11:41:14 +0200	[thread overview]
Message-ID: <YfkAOiSlIMZrKXyl@smile.fi.intel.com> (raw)
In-Reply-To: <YfhVBtv1UIA7bJja@ravnborg.org>

On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:

...

> > +config TINYDRM_SSD1307
> > +	tristate "DRM support for Solomon SSD1307 OLED displays"
> Use SSD130X here - so SSD1306 users can find it.

It's better to list them all in the "help". How user would grep this?

`git grep -n -i ssd1306` ==> no match.

> > +	depends on DRM && I2C
> > +	select DRM_KMS_HELPER
> > +	select DRM_GEM_SHMEM_HELPER
> > +	select BACKLIGHT_CLASS_DEVICE
> > +	help
> > +	  DRM driver for the SSD1305, SSD1306, SSD1307 and SSD1309 Solomon
> > +	  OLED controllers that can be programmed via an I2C interface.
> > +
> > +	  If M is selected the module will be called ssd1307.

-- 
With Best Regards,
Andy Shevchenko



WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-fbdev@vger.kernel.org,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	"Noralf Trønnes" <noralf@tronnes.org>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Maxime Ripard" <maxime@cerno.tech>
Subject: Re: [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays
Date: Tue, 1 Feb 2022 11:41:14 +0200	[thread overview]
Message-ID: <YfkAOiSlIMZrKXyl@smile.fi.intel.com> (raw)
In-Reply-To: <YfhVBtv1UIA7bJja@ravnborg.org>

On Mon, Jan 31, 2022 at 10:30:46PM +0100, Sam Ravnborg wrote:
> On Mon, Jan 31, 2022 at 09:29:16PM +0100, Javier Martinez Canillas wrote:

...

> > +config TINYDRM_SSD1307
> > +	tristate "DRM support for Solomon SSD1307 OLED displays"
> Use SSD130X here - so SSD1306 users can find it.

It's better to list them all in the "help". How user would grep this?

`git grep -n -i ssd1306` ==> no match.

> > +	depends on DRM && I2C
> > +	select DRM_KMS_HELPER
> > +	select DRM_GEM_SHMEM_HELPER
> > +	select BACKLIGHT_CLASS_DEVICE
> > +	help
> > +	  DRM driver for the SSD1305, SSD1306, SSD1307 and SSD1309 Solomon
> > +	  OLED controllers that can be programmed via an I2C interface.
> > +
> > +	  If M is selected the module will be called ssd1307.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2022-02-01  9:42 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31 20:29 [PATCH 3/4] drm/tiny: Add driver for Solomon SSD1307 OLED displays Javier Martinez Canillas
2022-01-31 20:29 ` Javier Martinez Canillas
2022-01-31 21:30 ` Sam Ravnborg
2022-02-01  0:14   ` Javier Martinez Canillas
2022-02-01  0:14     ` Javier Martinez Canillas
2022-02-01  9:44     ` Andy Shevchenko
2022-02-01  9:44       ` Andy Shevchenko
2022-02-01 11:45       ` Javier Martinez Canillas
2022-02-01 11:45         ` Javier Martinez Canillas
2022-02-01 14:02         ` Andy Shevchenko
2022-02-01 14:02           ` Andy Shevchenko
2022-02-01 15:10           ` Javier Martinez Canillas
2022-02-01 15:10             ` Javier Martinez Canillas
2022-02-01  9:41   ` Andy Shevchenko [this message]
2022-02-01  9:41     ` Andy Shevchenko
2022-02-01 11:40     ` Javier Martinez Canillas
2022-02-01 11:40       ` Javier Martinez Canillas
2022-02-01  9:33 ` Thomas Zimmermann
2022-02-01  9:48   ` Andy Shevchenko
2022-02-01  9:48     ` Andy Shevchenko
2022-02-01 13:01   ` Javier Martinez Canillas
2022-02-01 14:05     ` Geert Uytterhoeven
2022-02-01 14:05       ` Geert Uytterhoeven
2022-02-01 14:36       ` Javier Martinez Canillas
2022-02-01 14:36         ` Javier Martinez Canillas
2022-02-02  8:23         ` Thomas Zimmermann
2022-02-02  8:23           ` Thomas Zimmermann
2022-02-02  8:29           ` Javier Martinez Canillas
2022-02-02  8:29             ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfkAOiSlIMZrKXyl@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=javierm@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=noralf@tronnes.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.