* Re: [LTP] [RFC] SCTP tests in LTP vs. on github.com/sctp
@ 2022-02-02 12:28 ` Marcelo Ricardo Leitner
0 siblings, 0 replies; 10+ messages in thread
From: Marcelo Ricardo Leitner @ 2022-02-02 12:28 UTC (permalink / raw)
To: Petr Vorel
Cc: Xin Long, Neil Horman, Vlad Yasevich, linux-sctp, Martin Doucha,
ltp
Hi Petr,
On Wed, Feb 02, 2022 at 12:13:25PM +0100, Petr Vorel wrote:
> Hi all,
>
> SCTP tests lksctp-tools [1] are also in LTP [2].
> IMHO it's not worth to have it on both places.
Agree. I wasn't aware of the copy in LTP, btw.
A question I have now is, is getting more exposure because it is in
LTP? As in, does it get executed periodically by bots somewhere?
>
> lksctp-tools looks like to be the official ones [3] so maybe drop it from LTP?
>
> Version in LTP was updated to 1.0.15 some time ago (upstream has 1.0.19, containing various fixes [4],
> maybe worth to be backported to lksctp-tools? Frankly speaking even being older
> version the LTP code looks to me better. One test was even rewritten to LTP new
> C API [5] in order to apply more improvements [6].
>
> BTW I'd really recommend lksctp-tools project to take new LTP C API [7] and
> rewrite tests into it. But are these tests still relevant? (is it worth of
> work?)
These are nice tips, thanks. We certainly can have a take on them.
Best regards,
Marcelo
>
> Kind regards,
> Petr
>
> [1] https://github.com/sctp/lksctp-tools
> [2] https://github.com/linux-test-project/ltp/tree/master/utils/sctp
> [3] https://github.com/sctp
> [4] https://github.com/linux-test-project/ltp/commits/master/utils/sctp
> [5] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
> [6] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
> [7] https://github.com/linux-test-project/ltp/wiki/C-Test-API
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC] SCTP tests in LTP vs. on github.com/sctp
2022-02-02 12:28 ` [LTP] " Marcelo Ricardo Leitner
@ 2022-02-02 13:32 ` Petr Vorel
-1 siblings, 0 replies; 10+ messages in thread
From: Petr Vorel @ 2022-02-02 13:32 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: linux-sctp, ltp, Cyril Hrubis, Xin Long, Vlad Yasevich,
Neil Horman, Martin Doucha
Hi Marcelo,
> Hi Petr,
> On Wed, Feb 02, 2022 at 12:13:25PM +0100, Petr Vorel wrote:
> > Hi all,
> > SCTP tests lksctp-tools [1] are also in LTP [2].
> > IMHO it's not worth to have it on both places.
> Agree. I wasn't aware of the copy in LTP, btw.
> A question I have now is, is getting more exposure because it is in
> LTP? As in, does it get executed periodically by bots somewhere?
Maybe yes, hard to tell. Not sure even how many people even run SCTP tests
included by LTP. We could ask at automated-testing [8] (embedded people + hopefully
folks from KernelCI [9]) or send the update there. We'd also put a link in
to remaining location in git commit message if agree to remove it from LTP.
> > lksctp-tools looks like to be the official ones [3] so maybe drop it from LTP?
> > Version in LTP was updated to 1.0.15 some time ago (upstream has 1.0.19, containing various fixes [4],
> > maybe worth to be backported to lksctp-tools? Frankly speaking even being older
> > version the LTP code looks to me better. One test was even rewritten to LTP new
> > C API [5] in order to apply more improvements [6].
> > BTW I'd really recommend lksctp-tools project to take new LTP C API [7] and
> > rewrite tests into it. But are these tests still relevant? (is it worth of
> > work?)
> These are nice tips, thanks. We certainly can have a take on them.
Yw.
Kind regards,
Petr
> Best regards,
> Marcelo
> > Kind regards,
> > Petr
> > [1] https://github.com/sctp/lksctp-tools
> > [2] https://github.com/linux-test-project/ltp/tree/master/utils/sctp
> > [3] https://github.com/sctp
> > [4] https://github.com/linux-test-project/ltp/commits/master/utils/sctp
> > [5] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
> > [6] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
> > [7] https://github.com/linux-test-project/ltp/wiki/C-Test-API
[8] https://lists.yoctoproject.org/g/automated-testing/
[9] https://foundation.kernelci.org/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [LTP] [RFC] SCTP tests in LTP vs. on github.com/sctp
@ 2022-02-02 13:32 ` Petr Vorel
0 siblings, 0 replies; 10+ messages in thread
From: Petr Vorel @ 2022-02-02 13:32 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: Xin Long, Neil Horman, Vlad Yasevich, linux-sctp, Martin Doucha,
ltp
Hi Marcelo,
> Hi Petr,
> On Wed, Feb 02, 2022 at 12:13:25PM +0100, Petr Vorel wrote:
> > Hi all,
> > SCTP tests lksctp-tools [1] are also in LTP [2].
> > IMHO it's not worth to have it on both places.
> Agree. I wasn't aware of the copy in LTP, btw.
> A question I have now is, is getting more exposure because it is in
> LTP? As in, does it get executed periodically by bots somewhere?
Maybe yes, hard to tell. Not sure even how many people even run SCTP tests
included by LTP. We could ask at automated-testing [8] (embedded people + hopefully
folks from KernelCI [9]) or send the update there. We'd also put a link in
to remaining location in git commit message if agree to remove it from LTP.
> > lksctp-tools looks like to be the official ones [3] so maybe drop it from LTP?
> > Version in LTP was updated to 1.0.15 some time ago (upstream has 1.0.19, containing various fixes [4],
> > maybe worth to be backported to lksctp-tools? Frankly speaking even being older
> > version the LTP code looks to me better. One test was even rewritten to LTP new
> > C API [5] in order to apply more improvements [6].
> > BTW I'd really recommend lksctp-tools project to take new LTP C API [7] and
> > rewrite tests into it. But are these tests still relevant? (is it worth of
> > work?)
> These are nice tips, thanks. We certainly can have a take on them.
Yw.
Kind regards,
Petr
> Best regards,
> Marcelo
> > Kind regards,
> > Petr
> > [1] https://github.com/sctp/lksctp-tools
> > [2] https://github.com/linux-test-project/ltp/tree/master/utils/sctp
> > [3] https://github.com/sctp
> > [4] https://github.com/linux-test-project/ltp/commits/master/utils/sctp
> > [5] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
> > [6] https://github.com/linux-test-project/ltp/commit/fcd43b3dd7a8e8fab2b03ec9fa659f21ff5cecb2
> > [7] https://github.com/linux-test-project/ltp/wiki/C-Test-API
[8] https://lists.yoctoproject.org/g/automated-testing/
[9] https://foundation.kernelci.org/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [RFC] SCTP tests in LTP vs. on github.com/sctp
2022-02-02 12:28 ` [LTP] " Marcelo Ricardo Leitner
@ 2022-02-03 11:12 ` Cyril Hrubis
-1 siblings, 0 replies; 10+ messages in thread
From: Cyril Hrubis @ 2022-02-03 11:12 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: Petr Vorel, linux-sctp, ltp, Xin Long, Vlad Yasevich, Neil Horman,
Martin Doucha
Hi!
> > SCTP tests lksctp-tools [1] are also in LTP [2].
> > IMHO it's not worth to have it on both places.
>
> Agree. I wasn't aware of the copy in LTP, btw.
>
> A question I have now is, is getting more exposure because it is in
> LTP? As in, does it get executed periodically by bots somewhere?
Generally I think that not many run the LTP network tests, but it seems
that the intel 0-day has at least a job definition for the LTP sctp
tests:
https://github.com/intel/lkp-tests/blob/3fece75132266f680047f4e1740b39c5b3faabbf/jobs/ltp-stress.yaml
Not sure how often of if they even run it though.
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [LTP] [RFC] SCTP tests in LTP vs. on github.com/sctp
@ 2022-02-03 11:12 ` Cyril Hrubis
0 siblings, 0 replies; 10+ messages in thread
From: Cyril Hrubis @ 2022-02-03 11:12 UTC (permalink / raw)
To: Marcelo Ricardo Leitner
Cc: Xin Long, Neil Horman, Vlad Yasevich, linux-sctp, Martin Doucha,
ltp
Hi!
> > SCTP tests lksctp-tools [1] are also in LTP [2].
> > IMHO it's not worth to have it on both places.
>
> Agree. I wasn't aware of the copy in LTP, btw.
>
> A question I have now is, is getting more exposure because it is in
> LTP? As in, does it get executed periodically by bots somewhere?
Generally I think that not many run the LTP network tests, but it seems
that the intel 0-day has at least a job definition for the LTP sctp
tests:
https://github.com/intel/lkp-tests/blob/3fece75132266f680047f4e1740b39c5b3faabbf/jobs/ltp-stress.yaml
Not sure how often of if they even run it though.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 10+ messages in thread