All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <dfustini@baylibre.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Keerthy <j-keerthy@ti.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Tero Kristo <kristo@kernel.org>,
	khilman@baylibre.com, s-anna@ti.com
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: fix regression from errata i940 fix
Date: Thu, 3 Feb 2022 08:53:15 +0200	[thread overview]
Message-ID: <Yft723A/i3J1ZftC@atomide.com> (raw)
In-Reply-To: <20220202212554.1316032-1-dfustini@baylibre.com>

* Drew Fustini <dfustini@baylibre.com> [220202 23:26]:
> I modified the errata fix to use timer 15 and 16 instead which resolves
> the timer conflict.

Makes sens to me, just one nit below.

> Note: I am keeping the device tree and driver change together in one
> patch as that is how the original errata fix commit was structured.

Yes.. The old dtb handling for the timer driver causes this dependency
unfortunately.

> --- a/drivers/clocksource/timer-ti-dm-systimer.c
> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
> @@ -695,9 +695,9 @@ static int __init dmtimer_percpu_quirk_init(struct device_node *np, u32 pa)
>  		return 0;
>  	}
>  
> -	if (pa == 0x48034000)		/* dra7 dmtimer3 */
> +	if (pa == 0x4882C000)           /* dra7 dmtimer15 */
>  		return dmtimer_percpu_timer_init(np, 0);
> -	else if (pa == 0x48036000)	/* dra7 dmtimer4 */
> +	else if (pa == 0x4882E000)      /* dra7 dmtimer16 */
>  		return dmtimer_percpu_timer_init(np, 1);
>  
>  	return 0;

Linux use lower case hex number typically :)

With that, please feel free to add:

Reviewed-by: Tony Lindgren <tony@atomide.com>

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Drew Fustini <dfustini@baylibre.com>
Cc: Tero Kristo <kristo@kernel.org>, Keerthy <j-keerthy@ti.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	linux-kernel@vger.kernel.org, khilman@baylibre.com,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clocksource/drivers/timer-ti-dm: fix regression from errata i940 fix
Date: Thu, 3 Feb 2022 08:53:15 +0200	[thread overview]
Message-ID: <Yft723A/i3J1ZftC@atomide.com> (raw)
In-Reply-To: <20220202212554.1316032-1-dfustini@baylibre.com>

* Drew Fustini <dfustini@baylibre.com> [220202 23:26]:
> I modified the errata fix to use timer 15 and 16 instead which resolves
> the timer conflict.

Makes sens to me, just one nit below.

> Note: I am keeping the device tree and driver change together in one
> patch as that is how the original errata fix commit was structured.

Yes.. The old dtb handling for the timer driver causes this dependency
unfortunately.

> --- a/drivers/clocksource/timer-ti-dm-systimer.c
> +++ b/drivers/clocksource/timer-ti-dm-systimer.c
> @@ -695,9 +695,9 @@ static int __init dmtimer_percpu_quirk_init(struct device_node *np, u32 pa)
>  		return 0;
>  	}
>  
> -	if (pa == 0x48034000)		/* dra7 dmtimer3 */
> +	if (pa == 0x4882C000)           /* dra7 dmtimer15 */
>  		return dmtimer_percpu_timer_init(np, 0);
> -	else if (pa == 0x48036000)	/* dra7 dmtimer4 */
> +	else if (pa == 0x4882E000)      /* dra7 dmtimer16 */
>  		return dmtimer_percpu_timer_init(np, 1);
>  
>  	return 0;

Linux use lower case hex number typically :)

With that, please feel free to add:

Reviewed-by: Tony Lindgren <tony@atomide.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-02-03  6:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 21:25 [PATCH] clocksource/drivers/timer-ti-dm: fix regression from errata i940 fix Drew Fustini
2022-02-02 21:25 ` Drew Fustini
2022-02-02 21:33 ` Suman Anna
2022-02-02 21:33   ` Suman Anna
2022-02-02 21:36   ` Drew Fustini
2022-02-02 21:36     ` Drew Fustini
2022-02-03  6:53 ` Tony Lindgren [this message]
2022-02-03  6:53   ` Tony Lindgren
2022-02-03 15:56   ` Suman Anna
2022-02-03 15:56     ` Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yft723A/i3J1ZftC@atomide.com \
    --to=tony@atomide.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dfustini@baylibre.com \
    --cc=j-keerthy@ti.com \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.