From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Joel Stanley" <joel@jms.id.au>,
"kernel test robot" <lkp@intel.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/2] pinctrl: nuvoton: npcm7xx: Use %zd printk format for ARRAY_SIZE()
Date: Thu, 3 Feb 2022 15:40:21 +0100 [thread overview]
Message-ID: <YfvpVVigOc4eEdR3@latitude> (raw)
In-Reply-To: <CAHp75VfrygdyjgQJ7iRnGL-CELCQ+6D30r5aWwitCTUJvGVf_g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Thu, Feb 03, 2022 at 04:16:56PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 3, 2022 at 3:37 PM Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> >
> > When compile-testing on 64-bit architectures, GCC complains about the
> > mismatch of types between the %d format specifier and value returned by
> > ARRAY_LENGTH(). Use %zd, which is correct everywhere.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: 3b588e43ee5c7 ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> ...
>
> > - dev_dbg(npcm->dev, "group size: %d\n", ARRAY_SIZE(npcm7xx_groups));
> > + dev_dbg(npcm->dev, "group size: %zd\n", ARRAY_SIZE(npcm7xx_groups));
>
> Dunno how it's slipped away, but the proper specifier is %zu.
Right, I should have noticed that.
> I guess that's what I also mentioned in reply to LKP's report.
True,
>> Should be %zu
Thanks,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Benjamin Fair" <benjaminfair@google.com>,
"kernel test robot" <lkp@intel.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"Tali Perry" <tali.perry1@gmail.com>,
"OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
"Tomer Maimon" <tmaimon77@gmail.com>
Subject: Re: [PATCH v2 1/2] pinctrl: nuvoton: npcm7xx: Use %zd printk format for ARRAY_SIZE()
Date: Thu, 3 Feb 2022 15:40:21 +0100 [thread overview]
Message-ID: <YfvpVVigOc4eEdR3@latitude> (raw)
In-Reply-To: <CAHp75VfrygdyjgQJ7iRnGL-CELCQ+6D30r5aWwitCTUJvGVf_g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Thu, Feb 03, 2022 at 04:16:56PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 3, 2022 at 3:37 PM Jonathan Neuschäfer
> <j.neuschaefer@gmx.net> wrote:
> >
> > When compile-testing on 64-bit architectures, GCC complains about the
> > mismatch of types between the %d format specifier and value returned by
> > ARRAY_LENGTH(). Use %zd, which is correct everywhere.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: 3b588e43ee5c7 ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> ...
>
> > - dev_dbg(npcm->dev, "group size: %d\n", ARRAY_SIZE(npcm7xx_groups));
> > + dev_dbg(npcm->dev, "group size: %zd\n", ARRAY_SIZE(npcm7xx_groups));
>
> Dunno how it's slipped away, but the proper specifier is %zu.
Right, I should have noticed that.
> I guess that's what I also mentioned in reply to LKP's report.
True,
>> Should be %zu
Thanks,
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-03 14:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 13:37 [PATCH v2 0/2] Fixing the compile-test warnings in pinctrl-npcm7xx Jonathan Neuschäfer
2022-02-03 13:37 ` Jonathan Neuschäfer
2022-02-03 13:37 ` [PATCH v2 1/2] pinctrl: nuvoton: npcm7xx: Use %zd printk format for ARRAY_SIZE() Jonathan Neuschäfer
2022-02-03 13:37 ` Jonathan Neuschäfer
2022-02-03 14:16 ` Andy Shevchenko
2022-02-03 14:16 ` Andy Shevchenko
2022-02-03 14:40 ` Jonathan Neuschäfer [this message]
2022-02-03 14:40 ` Jonathan Neuschäfer
2022-02-03 13:37 ` [PATCH v2 2/2] pinctrl: nuvoton: npcm7xx: Rename DS() macro to DSTR() Jonathan Neuschäfer
2022-02-03 13:37 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfvpVVigOc4eEdR3@latitude \
--to=j.neuschaefer@gmx.net \
--cc=andy.shevchenko@gmail.com \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.