From: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
To: Sebastian Andrzej Siewior
<bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
"Andrew Morton"
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"Johannes Weiner"
<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
"Michal Hocko" <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>,
"Peter Zijlstra" <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
"Thomas Gleixner" <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"Vladimir Davydov"
<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Waiman Long" <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3 4/5] mm/memcg: Opencode the inner part of obj_cgroup_uncharge_pages() in drain_obj_stock()
Date: Fri, 18 Feb 2022 11:07:06 -0800 [thread overview]
Message-ID: <Yg/uWoP9OMteS7ZR@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20220217094802.3644569-5-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
On Thu, Feb 17, 2022 at 10:48:01AM +0100, Sebastian Andrzej Siewior wrote:
> From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
>
> Provide the inner part of refill_stock() as __refill_stock() without
> disabling interrupts. This eases the integration of local_lock_t where
> recursive locking must be avoided.
> Open code obj_cgroup_uncharge_pages() in drain_obj_stock() and use
> __refill_stock(). The caller of drain_obj_stock() already disables
> interrupts.
>
> [bigeasy: Patch body around Johannes' diff ]
>
> Signed-off-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Reviewed-by: Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>
WARNING: multiple messages have this Message-ID (diff)
From: Roman Gushchin <guro@fb.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: cgroups@vger.kernel.org, linux-mm@kvack.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Vladimir Davydov" <vdavydov.dev@gmail.com>,
"Waiman Long" <longman@redhat.com>
Subject: Re: [PATCH v3 4/5] mm/memcg: Opencode the inner part of obj_cgroup_uncharge_pages() in drain_obj_stock()
Date: Fri, 18 Feb 2022 11:07:06 -0800 [thread overview]
Message-ID: <Yg/uWoP9OMteS7ZR@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <20220217094802.3644569-5-bigeasy@linutronix.de>
On Thu, Feb 17, 2022 at 10:48:01AM +0100, Sebastian Andrzej Siewior wrote:
> From: Johannes Weiner <hannes@cmpxchg.org>
>
> Provide the inner part of refill_stock() as __refill_stock() without
> disabling interrupts. This eases the integration of local_lock_t where
> recursive locking must be avoided.
> Open code obj_cgroup_uncharge_pages() in drain_obj_stock() and use
> __refill_stock(). The caller of drain_obj_stock() already disables
> interrupts.
>
> [bigeasy: Patch body around Johannes' diff ]
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Roman Gushchin <guro@fb.com>
next prev parent reply other threads:[~2022-02-18 19:07 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 9:47 [PATCH v3 0/5] mm/memcg: Address PREEMPT_RT problems instead of disabling it Sebastian Andrzej Siewior
2022-02-17 9:47 ` Sebastian Andrzej Siewior
[not found] ` <20220217094802.3644569-1-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-17 9:47 ` [PATCH v3 1/5] mm/memcg: Revert ("mm/memcg: optimize user context object stock access") Sebastian Andrzej Siewior
2022-02-17 9:47 ` Sebastian Andrzej Siewior
[not found] ` <20220217094802.3644569-2-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-18 16:09 ` Shakeel Butt
2022-02-18 16:09 ` Shakeel Butt
2022-02-21 14:26 ` Michal Hocko
2022-02-21 14:26 ` Michal Hocko
2022-02-17 9:47 ` [PATCH v3 2/5] mm/memcg: Disable threshold event handlers on PREEMPT_RT Sebastian Andrzej Siewior
2022-02-17 9:47 ` Sebastian Andrzej Siewior
[not found] ` <20220217094802.3644569-3-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-18 16:39 ` Shakeel Butt
2022-02-18 16:39 ` Shakeel Butt
2022-02-21 14:27 ` Michal Hocko
2022-02-21 14:27 ` Michal Hocko
2022-02-17 9:48 ` [PATCH v3 3/5] mm/memcg: Protect per-CPU counter by disabling preemption on PREEMPT_RT where needed Sebastian Andrzej Siewior
2022-02-17 9:48 ` Sebastian Andrzej Siewior
[not found] ` <20220217094802.3644569-4-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-18 17:25 ` Shakeel Butt
2022-02-18 17:25 ` Shakeel Butt
[not found] ` <CALvZod4eZWVfibhxu0P0ZQ35cB=vDbde=VNeXiBZfED=k3YPOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2022-02-21 11:31 ` Sebastian Andrzej Siewior
2022-02-21 11:31 ` Sebastian Andrzej Siewior
[not found] ` <YhN4BSQ1RLomLoyl-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-21 12:12 ` Sebastian Andrzej Siewior
2022-02-21 12:12 ` Sebastian Andrzej Siewior
2022-02-21 13:18 ` Michal Koutný
2022-02-21 13:18 ` Michal Koutný
[not found] ` <20220221131825.GA7534-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>
2022-02-21 13:58 ` Sebastian Andrzej Siewior
2022-02-21 13:58 ` Sebastian Andrzej Siewior
2022-02-17 9:48 ` [PATCH v3 4/5] mm/memcg: Opencode the inner part of obj_cgroup_uncharge_pages() in drain_obj_stock() Sebastian Andrzej Siewior
2022-02-17 9:48 ` Sebastian Andrzej Siewior
[not found] ` <20220217094802.3644569-5-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-18 18:40 ` Shakeel Butt
2022-02-18 18:40 ` Shakeel Butt
2022-02-18 19:07 ` Roman Gushchin [this message]
2022-02-18 19:07 ` Roman Gushchin
2022-02-21 14:30 ` Michal Hocko
2022-02-21 14:30 ` Michal Hocko
2022-02-17 9:48 ` [PATCH v3 5/5] mm/memcg: Protect memcg_stock with a local_lock_t Sebastian Andrzej Siewior
2022-02-17 9:48 ` Sebastian Andrzej Siewior
[not found] ` <20220217094802.3644569-6-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-21 14:46 ` Michal Hocko
2022-02-21 14:46 ` Michal Hocko
[not found] ` <YhOlxsLOOU/OVSzu-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-02-21 15:19 ` Sebastian Andrzej Siewior
2022-02-21 15:19 ` Sebastian Andrzej Siewior
[not found] ` <YhOtmPQUcqZCKodH-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-21 16:24 ` Michal Hocko
2022-02-21 16:24 ` Michal Hocko
2022-02-21 16:44 ` Sebastian Andrzej Siewior
2022-02-21 16:44 ` Sebastian Andrzej Siewior
[not found] ` <YhPBXUmIIHeXI/Gz-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2022-02-21 17:17 ` Michal Hocko
2022-02-21 17:17 ` Michal Hocko
[not found] ` <YhPJM4RjqklanVLE-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2022-02-21 17:25 ` Sebastian Andrzej Siewior
2022-02-21 17:25 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg/uWoP9OMteS7ZR@carbon.DHCP.thefacebook.com \
--to=guro-b10kyp2domg@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mkoutny-IBi9RG/b67k@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.