From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-pwm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight: pwm_bl: Avoid open coded arithmetic in memory allocation
Date: Mon, 7 Feb 2022 09:31:00 +0000 [thread overview]
Message-ID: <YgDm1FWtlneMLCTS@google.com> (raw)
In-Reply-To: <20220207080128.xmvommcddjfgz7ey@pengutronix.de>
On Mon, 07 Feb 2022, Uwe Kleine-König wrote:
> On Sat, Feb 05, 2022 at 08:40:48AM +0100, Christophe JAILLET wrote:
> > kmalloc_array()/kcalloc() should be used to avoid potential overflow when
> > a multiplication is needed to compute the size of the requested memory.
> >
> > So turn a kzalloc()+explicit size computation into an equivalent kcalloc().
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> LGTM
>
> Acked-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Thanks
> Uwe
I am totally confused!
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Thierry Reding <thierry.reding@gmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] backlight: pwm_bl: Avoid open coded arithmetic in memory allocation
Date: Mon, 7 Feb 2022 09:31:00 +0000 [thread overview]
Message-ID: <YgDm1FWtlneMLCTS@google.com> (raw)
In-Reply-To: <20220207080128.xmvommcddjfgz7ey@pengutronix.de>
On Mon, 07 Feb 2022, Uwe Kleine-König wrote:
> On Sat, Feb 05, 2022 at 08:40:48AM +0100, Christophe JAILLET wrote:
> > kmalloc_array()/kcalloc() should be used to avoid potential overflow when
> > a multiplication is needed to compute the size of the requested memory.
> >
> > So turn a kzalloc()+explicit size computation into an equivalent kcalloc().
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> LGTM
>
> Acked-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Thanks
> Uwe
I am totally confused!
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-02-07 9:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-05 7:40 [PATCH] backlight: pwm_bl: Avoid open coded arithmetic in memory allocation Christophe JAILLET
2022-02-05 7:40 ` Christophe JAILLET
2022-02-07 8:01 ` Uwe Kleine-König
2022-02-07 8:01 ` Uwe Kleine-König
2022-02-07 9:31 ` Lee Jones [this message]
2022-02-07 9:31 ` Lee Jones
2022-02-08 8:43 ` Uwe Kleine-König
2022-02-08 8:43 ` Uwe Kleine-König
2022-02-07 16:21 ` Daniel Thompson
2022-02-07 16:21 ` Daniel Thompson
2022-02-08 8:53 ` Lee Jones
2022-02-08 8:53 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgDm1FWtlneMLCTS@google.com \
--to=lee.jones@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.