From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
Simon Ser <contact@emersion.fr>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Alex Deucher <alexander.deucher@amd.com>,
Harry Wentland <harry.wentland@amd.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting
Date: Tue, 8 Feb 2022 09:52:05 +0200 [thread overview]
Message-ID: <YgIhJb3+MckKD4dC@intel.com> (raw)
In-Reply-To: <20220208073714.1540390-1-hsinyi@chromium.org>
On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote:
> +int drm_connector_init_panel_orientation_property(
> + struct drm_connector *connector)
> +{
> + struct drm_device *dev = connector->dev;
> + struct drm_property *prop;
> +
> + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE,
> + "panel orientation",
> + drm_panel_orientation_enum_list,
> + ARRAY_SIZE(drm_panel_orientation_enum_list));
> + if (!prop)
> + return -ENOMEM;
> +
> + dev->mode_config.panel_orientation_property = prop;
Leak when called multiple times. I guess you could just put
this into drm_connector_create_standard_properties() instead
and avoid that issue entirely.
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
Simon Ser <contact@emersion.fr>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Harry Wentland <harry.wentland@amd.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting
Date: Tue, 8 Feb 2022 09:52:05 +0200 [thread overview]
Message-ID: <YgIhJb3+MckKD4dC@intel.com> (raw)
In-Reply-To: <20220208073714.1540390-1-hsinyi@chromium.org>
On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote:
> +int drm_connector_init_panel_orientation_property(
> + struct drm_connector *connector)
> +{
> + struct drm_device *dev = connector->dev;
> + struct drm_property *prop;
> +
> + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE,
> + "panel orientation",
> + drm_panel_orientation_enum_list,
> + ARRAY_SIZE(drm_panel_orientation_enum_list));
> + if (!prop)
> + return -ENOMEM;
> +
> + dev->mode_config.panel_orientation_property = prop;
Leak when called multiple times. I guess you could just put
this into drm_connector_create_standard_properties() instead
and avoid that issue entirely.
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
devicetree@vger.kernel.org, Simon Ser <contact@emersion.fr>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Harry Wentland <harry.wentland@amd.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting
Date: Tue, 8 Feb 2022 09:52:05 +0200 [thread overview]
Message-ID: <YgIhJb3+MckKD4dC@intel.com> (raw)
In-Reply-To: <20220208073714.1540390-1-hsinyi@chromium.org>
On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote:
> +int drm_connector_init_panel_orientation_property(
> + struct drm_connector *connector)
> +{
> + struct drm_device *dev = connector->dev;
> + struct drm_property *prop;
> +
> + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE,
> + "panel orientation",
> + drm_panel_orientation_enum_list,
> + ARRAY_SIZE(drm_panel_orientation_enum_list));
> + if (!prop)
> + return -ENOMEM;
> +
> + dev->mode_config.panel_orientation_property = prop;
Leak when called multiple times. I guess you could just put
this into drm_connector_create_standard_properties() instead
and avoid that issue entirely.
--
Ville Syrjälä
Intel
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
devicetree@vger.kernel.org, Simon Ser <contact@emersion.fr>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Harry Wentland <harry.wentland@amd.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting
Date: Tue, 8 Feb 2022 09:52:05 +0200 [thread overview]
Message-ID: <YgIhJb3+MckKD4dC@intel.com> (raw)
In-Reply-To: <20220208073714.1540390-1-hsinyi@chromium.org>
On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote:
> +int drm_connector_init_panel_orientation_property(
> + struct drm_connector *connector)
> +{
> + struct drm_device *dev = connector->dev;
> + struct drm_property *prop;
> +
> + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE,
> + "panel orientation",
> + drm_panel_orientation_enum_list,
> + ARRAY_SIZE(drm_panel_orientation_enum_list));
> + if (!prop)
> + return -ENOMEM;
> +
> + dev->mode_config.panel_orientation_property = prop;
Leak when called multiple times. I guess you could just put
this into drm_connector_create_standard_properties() instead
and avoid that issue entirely.
--
Ville Syrjälä
Intel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
devicetree@vger.kernel.org, Simon Ser <contact@emersion.fr>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Harry Wentland <harry.wentland@amd.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting
Date: Tue, 8 Feb 2022 09:52:05 +0200 [thread overview]
Message-ID: <YgIhJb3+MckKD4dC@intel.com> (raw)
In-Reply-To: <20220208073714.1540390-1-hsinyi@chromium.org>
On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote:
> +int drm_connector_init_panel_orientation_property(
> + struct drm_connector *connector)
> +{
> + struct drm_device *dev = connector->dev;
> + struct drm_property *prop;
> +
> + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE,
> + "panel orientation",
> + drm_panel_orientation_enum_list,
> + ARRAY_SIZE(drm_panel_orientation_enum_list));
> + if (!prop)
> + return -ENOMEM;
> +
> + dev->mode_config.panel_orientation_property = prop;
Leak when called multiple times. I guess you could just put
this into drm_connector_create_standard_properties() instead
and avoid that issue entirely.
--
Ville Syrjälä
Intel
WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
amd-gfx@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting
Date: Tue, 8 Feb 2022 09:52:05 +0200 [thread overview]
Message-ID: <YgIhJb3+MckKD4dC@intel.com> (raw)
In-Reply-To: <20220208073714.1540390-1-hsinyi@chromium.org>
On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote:
> +int drm_connector_init_panel_orientation_property(
> + struct drm_connector *connector)
> +{
> + struct drm_device *dev = connector->dev;
> + struct drm_property *prop;
> +
> + prop = drm_property_create_enum(dev, DRM_MODE_PROP_IMMUTABLE,
> + "panel orientation",
> + drm_panel_orientation_enum_list,
> + ARRAY_SIZE(drm_panel_orientation_enum_list));
> + if (!prop)
> + return -ENOMEM;
> +
> + dev->mode_config.panel_orientation_property = prop;
Leak when called multiple times. I guess you could just put
this into drm_connector_create_standard_properties() instead
and avoid that issue entirely.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-02-08 7:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 7:37 [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` [Intel-gfx] " Hsin-Yi Wang
2022-02-08 7:37 ` [PATCH v7 2/3] drm/mediatek: init panel orientation property Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` [Intel-gfx] " Hsin-Yi Wang
2022-02-08 7:37 ` [PATCH v7 3/3] arm64: dts: mt8183: Add panel rotation Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` Hsin-Yi Wang
2022-02-08 7:37 ` [Intel-gfx] " Hsin-Yi Wang
2022-02-08 7:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v7,1/3] gpu: drm: separate panel orientation property creating and value setting Patchwork
2022-02-08 7:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-08 7:52 ` Ville Syrjälä [this message]
2022-02-08 7:52 ` [Intel-gfx] [PATCH v7 1/3] " Ville Syrjälä
2022-02-08 7:52 ` Ville Syrjälä
2022-02-08 7:52 ` Ville Syrjälä
2022-02-08 7:52 ` Ville Syrjälä
2022-02-08 7:52 ` Ville Syrjälä
2022-02-08 8:06 ` Hsin-Yi Wang
2022-02-08 8:06 ` Hsin-Yi Wang
2022-02-08 8:06 ` Hsin-Yi Wang
2022-02-08 8:06 ` Hsin-Yi Wang
2022-02-08 8:06 ` Hsin-Yi Wang
2022-02-08 8:06 ` Hsin-Yi Wang
2022-02-08 8:17 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v7,1/3] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgIhJb3+MckKD4dC@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chunkuang.hu@kernel.org \
--cc=contact@emersion.fr \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hsinyi@chromium.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.