From: Johan Hovold <johan@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
Date: Thu, 10 Feb 2022 12:26:07 +0100 [thread overview]
Message-ID: <YgT2TyST3OA3a4WC@hovoldconsulting.com> (raw)
In-Reply-To: <CAHp75Vd-Zszg1j6aVrX_oEJdiq4m=69JqE4RvyPMqEu30RFaTA@mail.gmail.com>
On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@gmail.com> wrote:
> >
> > From: Yang Guang <yang.guang5@zte.com.cn>
> >
> > coccinelle report:
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> > WARNING: use scnprintf or sprintf
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> sysfs_emit()
> scnprintf()
> sprintf()
>
> ...
>
> > CC: David Yang <davidcomponentone@gmail.com>
>
> > - Use the CC for patch sender
>
> This is incorrect. The submitter must have (the last) SoB tag.
> Question was about authorship just to be clear.
Please fix up the subject prefix too ("8059").
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: davidcomponentone@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
Zev Weiss <zev@bewilderbeest.net>,
Yang Guang <yang.guang5@zte.com.cn>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
Date: Thu, 10 Feb 2022 12:26:07 +0100 [thread overview]
Message-ID: <YgT2TyST3OA3a4WC@hovoldconsulting.com> (raw)
In-Reply-To: <CAHp75Vd-Zszg1j6aVrX_oEJdiq4m=69JqE4RvyPMqEu30RFaTA@mail.gmail.com>
On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@gmail.com> wrote:
> >
> > From: Yang Guang <yang.guang5@zte.com.cn>
> >
> > coccinelle report:
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> > WARNING: use scnprintf or sprintf
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> sysfs_emit()
> scnprintf()
> sprintf()
>
> ...
>
> > CC: David Yang <davidcomponentone@gmail.com>
>
> > - Use the CC for patch sender
>
> This is incorrect. The submitter must have (the last) SoB tag.
> Question was about authorship just to be clear.
Please fix up the subject prefix too ("8059").
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: davidcomponentone@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@aj.id.au>,
Zev Weiss <zev@bewilderbeest.net>,
Yang Guang <yang.guang5@zte.com.cn>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit
Date: Thu, 10 Feb 2022 12:26:07 +0100 [thread overview]
Message-ID: <YgT2TyST3OA3a4WC@hovoldconsulting.com> (raw)
In-Reply-To: <CAHp75Vd-Zszg1j6aVrX_oEJdiq4m=69JqE4RvyPMqEu30RFaTA@mail.gmail.com>
On Thu, Feb 10, 2022 at 01:13:28PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 10, 2022 at 12:54 PM <davidcomponentone@gmail.com> wrote:
> >
> > From: Yang Guang <yang.guang5@zte.com.cn>
> >
> > coccinelle report:
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:85:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:174:8-16:
> > WARNING: use scnprintf or sprintf
> > ./drivers/tty/serial/8250/8250_aspeed_vuart.c:127:8-16:
> > WARNING: use scnprintf or sprintf
> >
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> sysfs_emit()
> scnprintf()
> sprintf()
>
> ...
>
> > CC: David Yang <davidcomponentone@gmail.com>
>
> > - Use the CC for patch sender
>
> This is incorrect. The submitter must have (the last) SoB tag.
> Question was about authorship just to be clear.
Please fix up the subject prefix too ("8059").
Johan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-10 11:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 10:34 [PATCH v2] serial: 8259_aspeed_vuart: replace snprintf with sysfs_emit davidcomponentone
2022-02-10 10:34 ` davidcomponentone
2022-02-10 10:34 ` davidcomponentone
2022-02-10 11:13 ` Andy Shevchenko
2022-02-10 11:13 ` Andy Shevchenko
2022-02-10 11:13 ` Andy Shevchenko
2022-02-10 11:26 ` Johan Hovold [this message]
2022-02-10 11:26 ` Johan Hovold
2022-02-10 11:26 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgT2TyST3OA3a4WC@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.