From: Abel Vesa <abel.vesa@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Georgi Djakov <djakov@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl,icc-id property
Date: Thu, 10 Feb 2022 21:32:22 +0200 [thread overview]
Message-ID: <YgVoRols6AA5HAze@abelvesa> (raw)
In-Reply-To: <YeslLJqwhX668+oa@robh.at.kernel.org>
On 22-01-21 15:27:08, Rob Herring wrote:
> On Thu, Jan 06, 2022 at 06:41:48PM +0200, Abel Vesa wrote:
> > Add documentation for fsl,icc-id property.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >
> > Changes since v3:
> > * fixed typo in property description
> >
> > .../devicetree/bindings/interconnect/fsl,imx8m-noc.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > index b8204ed22dd5..dc7f6b6f508a 100644
> > --- a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > +++ b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > @@ -47,6 +47,11 @@ properties:
> > operating-points-v2: true
> > opp-table: true
> >
> > + fsl,icc-id:
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
> > + description:
> > + unique ID used for linking i.MX bus or ddrc node to interconnect
>
> Where does this unique ID come from and how is it used? Why aren't cells
> in 'interconnects' sufficient for this?
Sorry for the late reply.
Well, the 'inteconnects' property is documented as a pair of
interconnect nodes, specifically source and destination (endpoints).
The fsl,icc-id is used here to allow the the imx-bus and imx8m-ddrc
nodes to specify which icc node it belongs to.
Basically, the 'interconnects' property is used by an icc consumer
to specify a path towards the target, while the fsl,icc-id is used
here to specify which icc node (in this case, not an endpoint)
belongs to which imx-bus or imx8m-ddrc device.
>
> > +
> > fsl,ddrc:
> > $ref: "/schemas/types.yaml#/definitions/phandle"
> > description:
> > --
> > 2.31.1
> >
> >
WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Georgi Djakov <djakov@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl,icc-id property
Date: Thu, 10 Feb 2022 21:32:22 +0200 [thread overview]
Message-ID: <YgVoRols6AA5HAze@abelvesa> (raw)
In-Reply-To: <YeslLJqwhX668+oa@robh.at.kernel.org>
On 22-01-21 15:27:08, Rob Herring wrote:
> On Thu, Jan 06, 2022 at 06:41:48PM +0200, Abel Vesa wrote:
> > Add documentation for fsl,icc-id property.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >
> > Changes since v3:
> > * fixed typo in property description
> >
> > .../devicetree/bindings/interconnect/fsl,imx8m-noc.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > index b8204ed22dd5..dc7f6b6f508a 100644
> > --- a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > +++ b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > @@ -47,6 +47,11 @@ properties:
> > operating-points-v2: true
> > opp-table: true
> >
> > + fsl,icc-id:
> > + $ref: "/schemas/types.yaml#/definitions/uint32"
> > + description:
> > + unique ID used for linking i.MX bus or ddrc node to interconnect
>
> Where does this unique ID come from and how is it used? Why aren't cells
> in 'interconnects' sufficient for this?
Sorry for the late reply.
Well, the 'inteconnects' property is documented as a pair of
interconnect nodes, specifically source and destination (endpoints).
The fsl,icc-id is used here to allow the the imx-bus and imx8m-ddrc
nodes to specify which icc node it belongs to.
Basically, the 'interconnects' property is used by an icc consumer
to specify a path towards the target, while the fsl,icc-id is used
here to specify which icc node (in this case, not an endpoint)
belongs to which imx-bus or imx8m-ddrc device.
>
> > +
> > fsl,ddrc:
> > $ref: "/schemas/types.yaml#/definitions/phandle"
> > description:
> > --
> > 2.31.1
> >
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-10 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 16:41 [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl,icc-id property Abel Vesa
2022-01-06 16:41 ` [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl, icc-id property Abel Vesa
2022-01-06 16:41 ` [PATCH v4 2/3] interconnect: imx: Switch from imx_icc_node_adj_desc to fsl,icc-id node assignment Abel Vesa
2022-01-06 16:41 ` [PATCH v4 2/3] interconnect: imx: Switch from imx_icc_node_adj_desc to fsl, icc-id " Abel Vesa
2022-01-06 16:41 ` [PATCH v4 3/3] interconnect: imx: Remove the imx_icc_node_adj_desc Abel Vesa
2022-01-06 16:41 ` Abel Vesa
2022-01-21 21:27 ` [PATCH v4 1/3] dt-bindings: interconnect: imx8m-noc: Add fsl,icc-id property Rob Herring
2022-01-21 21:27 ` Rob Herring
2022-02-10 19:32 ` Abel Vesa [this message]
2022-02-10 19:32 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgVoRols6AA5HAze@abelvesa \
--to=abel.vesa@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.