[PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

[PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

[Sai Teja Aluvala]

setting the vddio supply for Bluetooth SoC WCN6750 node
on SC7280 crd board

Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
index cd2755c..53ea3b4 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
@@ -23,6 +23,10 @@
 	};
 };
 
+&bluetooth {
+	vddio-supply = <&vreg_l18b_1p8>;
+};
+
 ap_tp_i2c: &i2c0 {
 	status = "okay";
 	clock-frequency = <400000>;
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.

RE: [v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=612157

---Test result---

Test Summary:
CheckPatch                    PASS      0.71 seconds
GitLint                       FAIL      0.45 seconds
SubjectPrefix                 FAIL      0.25 seconds
BuildKernel                   PASS      37.92 seconds
BuildKernel32                 PASS      33.43 seconds
Incremental Build with patchesPASS      43.83 seconds
TestRunner: Setup             PASS      600.88 seconds
TestRunner: l2cap-tester      PASS      15.78 seconds
TestRunner: bnep-tester       PASS      6.85 seconds
TestRunner: mgmt-tester       PASS      124.22 seconds
TestRunner: rfcomm-tester     PASS      8.51 seconds
TestRunner: sco-tester        PASS      8.80 seconds
TestRunner: smp-tester        PASS      8.71 seconds
TestRunner: userchan-tester   PASS      7.12 seconds

Details
##############################
Test: GitLint - FAIL - 0.45 seconds
Run gitlint with rule in .gitlint
[v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD
1: T1 Title exceeds max length (81>80): "[v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD"


##############################
Test: SubjectPrefix - FAIL - 0.25 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth

Re: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1948 bytes --]

Hi Sai,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.17-rc3]
[cannot apply to next-20220209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sai-Teja-Aluvala/arm64-dts-qcom-sc7280-setting-the-vddio-supply-for-Bluetooth-node-on-CRD/20220208-193518
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-buildonly-randconfig-r005-20220208 (https://download.01.org/0day-ci/archive/20220209/202202091715.xx9Copvs-lkp(a)intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2ccfa81c35ce2a45f3e9585ae90f300841d915d5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sai-Teja-Aluvala/arm64-dts-qcom-sc7280-setting-the-vddio-supply-for-Bluetooth-node-on-CRD/20220208-193518
        git checkout 2ccfa81c35ce2a45f3e9585ae90f300841d915d5
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/qcom/sc7280-crd.dts:26.1-11 Label or path bluetooth not found
   FATAL ERROR: Syntax error parsing input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

Re: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

[Bjorn Andersson]

On Tue 08 Feb 05:13 CST 2022, Sai Teja Aluvala wrote:

> setting the vddio supply for Bluetooth SoC WCN6750 node
> on SC7280 crd board
> 

While this does better describe what the change does, as Matthias
requested on v1, it fails to provide any information about why this
done.

Is vddio simply not powered on the IDP? Or did someone forget to add it
to the idp.dtsi?

Regards,
Bjorn

> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index cd2755c..53ea3b4 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -23,6 +23,10 @@
>  	};
>  };
>  
> +&bluetooth {
> +	vddio-supply = <&vreg_l18b_1p8>;
> +};
> +
>  ap_tp_i2c: &i2c0 {
>  	status = "okay";
>  	clock-frequency = <400000>;
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
> 

RE: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

[Sai Teja Aluvala (Temp) (QUIC)]

-----Original Message-----
From: Bjorn Andersson <bjorn.andersson@linaro.org> 
Sent: Friday, February 11, 2022 6:09 AM
To: Sai Teja Aluvala (Temp) (QUIC) <quic_saluvala@quicinc.com>
Cc: marcel@holtmann.org; johan.hedberg@gmail.com; mka@chromium.org; linux-kernel@vger.kernel.org; linux-bluetooth@vger.kernel.org; Hemant Gupta (QUIC) <quic_hemantg@quicinc.com>; linux-arm-msm@vger.kernel.org; quic_bgodavar <quic_bgodavar@quicinc.com>; quic_rjliao <quic_rjliao@quicinc.com>; quic_hbandi <quic_hbandi@quicinc.com>; abhishekpandit@chromium.org; mcchou@chromium.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

On Tue 08 Feb 05:13 CST 2022, Sai Teja Aluvala wrote:

> setting the vddio supply for Bluetooth SoC WCN6750 node on SC7280 crd 
> board
> 

While this does better describe what the change does, as Matthias requested on v1, it fails to provide any information about why this done.

Is vddio simply not powered on the IDP? Or did someone forget to add it to the idp.dtsi?
[Sai]: Vddio regulator handle is different for IDP and IDP2. So in common dtsi file i.e. sc7280-idp.dtsi we haven't enabled vddio instead we have add the regulator handle in board specific dts file.
So for CRD too we are adding it in the sc7280-crd.dts file.


Regards,
Bjorn

> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts 
> b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index cd2755c..53ea3b4 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -23,6 +23,10 @@
>  	};
>  };
>  
> +&bluetooth {
> +	vddio-supply = <&vreg_l18b_1p8>;
> +};
> +
>  ap_tp_i2c: &i2c0 {
>  	status = "okay";
>  	clock-frequency = <400000>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
>