From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex Gaynor <alex.gaynor@gmail.com>, Finn Behrens <me@kloenk.de>,
Adam Bratschi-Kaye <ark.email@gmail.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Sven Van Asbroeck <thesven73@gmail.com>,
Gary Guo <gary@garyguo.net>,
Boris-Chengbiao Zhou <bobo1239@web.de>,
Boqun Feng <boqun.feng@gmail.com>,
Douglas Su <d0u9.su@outlook.com>,
Dariusz Sosnowski <dsosnowski@dsosnowski.pl>,
Antonio Terceiro <antonio.terceiro@linaro.org>,
Daniel Xu <dxu@dxuuu.xyz>, Miguel Cano <macanroj@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kbuild@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 16/20] Kbuild: add Rust support
Date: Sat, 12 Feb 2022 14:16:50 +0000 [thread overview]
Message-ID: <YgfBUhYdLXA46kOX@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220212130410.6901-17-ojeda@kernel.org>
On Sat, Feb 12, 2022 at 02:03:42PM +0100, Miguel Ojeda wrote:
> +config RUST
> + bool "Rust support"
> + depends on RUST_IS_AVAILABLE
> + depends on ARM64 || CPU_32v6 || CPU_32v6K || (PPC64 && CPU_LITTLE_ENDIAN) || X86_64 || RISCV
Please don't use CPU_32v6* here.
It probably makes more sense to add a symbol "HAVE_RUST" and have the
appropriate architecture Kconfig files select HAVE_RUST.
Does Rust support Thumb on ARMv6 and ARMv7 architectures?
> + depends on !MODVERSIONS
> + depends on !GCC_PLUGIN_RANDSTRUCT
> + select CONSTRUCTORS
> + default n
Please remove every utterance of "default n" from your patch; n is the
default default which default defaults to, so you don't need to specify
default n to make the option default to n. It will default to n purely
because n is the default when no default is specified.
> + help
> + Enables Rust support in the kernel.
> +
> + This allows other Rust-related options, like drivers written in Rust,
> + to be selected.
As Rust doesn't support all the architectures that the kernel supports,
Rust must not be used for core infrastructure.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex Gaynor <alex.gaynor@gmail.com>, Finn Behrens <me@kloenk.de>,
Adam Bratschi-Kaye <ark.email@gmail.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Sven Van Asbroeck <thesven73@gmail.com>,
Gary Guo <gary@garyguo.net>,
Boris-Chengbiao Zhou <bobo1239@web.de>,
Boqun Feng <boqun.feng@gmail.com>,
Douglas Su <d0u9.su@outlook.com>,
Dariusz Sosnowski <dsosnowski@dsosnowski.pl>,
Antonio Terceiro <antonio.terceiro@linaro.org>,
Daniel Xu <dxu@dxuuu.xyz>, Miguel Cano <macanroj@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kbuild@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 16/20] Kbuild: add Rust support
Date: Sat, 12 Feb 2022 14:16:50 +0000 [thread overview]
Message-ID: <YgfBUhYdLXA46kOX@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220212130410.6901-17-ojeda@kernel.org>
On Sat, Feb 12, 2022 at 02:03:42PM +0100, Miguel Ojeda wrote:
> +config RUST
> + bool "Rust support"
> + depends on RUST_IS_AVAILABLE
> + depends on ARM64 || CPU_32v6 || CPU_32v6K || (PPC64 && CPU_LITTLE_ENDIAN) || X86_64 || RISCV
Please don't use CPU_32v6* here.
It probably makes more sense to add a symbol "HAVE_RUST" and have the
appropriate architecture Kconfig files select HAVE_RUST.
Does Rust support Thumb on ARMv6 and ARMv7 architectures?
> + depends on !MODVERSIONS
> + depends on !GCC_PLUGIN_RANDSTRUCT
> + select CONSTRUCTORS
> + default n
Please remove every utterance of "default n" from your patch; n is the
default default which default defaults to, so you don't need to specify
default n to make the option default to n. It will default to n purely
because n is the default when no default is specified.
> + help
> + Enables Rust support in the kernel.
> +
> + This allows other Rust-related options, like drivers written in Rust,
> + to be selected.
As Rust doesn't support all the architectures that the kernel supports,
Rust must not be used for core infrastructure.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Sven Van Asbroeck <thesven73@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Miguel Cano <macanroj@gmail.com>,
Paul Mackerras <paulus@samba.org>, Gary Guo <gary@garyguo.net>,
Douglas Su <d0u9.su@outlook.com>, Borislav Petkov <bp@alien8.de>,
linux-riscv@lists.infradead.org, Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Masahiro Yamada <masahiroy@kernel.org>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Alex Gaynor <alex.gaynor@gmail.com>,
Antonio Terceiro <antonio.terceiro@linaro.org>,
Adam Bratschi-Kaye <ark.email@gmail.com>,
Albert Ou <aou@eecs.berkeley.edu>,
rust-for-linux@vger.kernel.org, linux-kbuild@vger.kernel.org,
Boqun Feng <boqun.feng@gmail.com>,
linuxppc-dev@lists.ozlabs.org, Daniel Xu <dxu@dxuuu.xyz>,
Paul Walmsley <paul.walmsley@sifive.com>,
Dariusz Sosnowski <dsosnowski@dsosnowski.pl>,
linux-arm-kernel@lists.infradead.org,
Michal Marek <michal.lkml@markovi.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Boris-Chengbiao Zhou <bobo1239@web.de>,
Palmer Dabbelt <palmer@dabbelt.com>, Finn Behrens <me@kloenk.de>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v4 16/20] Kbuild: add Rust support
Date: Sat, 12 Feb 2022 14:16:50 +0000 [thread overview]
Message-ID: <YgfBUhYdLXA46kOX@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220212130410.6901-17-ojeda@kernel.org>
On Sat, Feb 12, 2022 at 02:03:42PM +0100, Miguel Ojeda wrote:
> +config RUST
> + bool "Rust support"
> + depends on RUST_IS_AVAILABLE
> + depends on ARM64 || CPU_32v6 || CPU_32v6K || (PPC64 && CPU_LITTLE_ENDIAN) || X86_64 || RISCV
Please don't use CPU_32v6* here.
It probably makes more sense to add a symbol "HAVE_RUST" and have the
appropriate architecture Kconfig files select HAVE_RUST.
Does Rust support Thumb on ARMv6 and ARMv7 architectures?
> + depends on !MODVERSIONS
> + depends on !GCC_PLUGIN_RANDSTRUCT
> + select CONSTRUCTORS
> + default n
Please remove every utterance of "default n" from your patch; n is the
default default which default defaults to, so you don't need to specify
default n to make the option default to n. It will default to n purely
because n is the default when no default is specified.
> + help
> + Enables Rust support in the kernel.
> +
> + This allows other Rust-related options, like drivers written in Rust,
> + to be selected.
As Rust doesn't support all the architectures that the kernel supports,
Rust must not be used for core infrastructure.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Miguel Ojeda <ojeda@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Alex Gaynor <alex.gaynor@gmail.com>, Finn Behrens <me@kloenk.de>,
Adam Bratschi-Kaye <ark.email@gmail.com>,
Wedson Almeida Filho <wedsonaf@google.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Sven Van Asbroeck <thesven73@gmail.com>,
Gary Guo <gary@garyguo.net>,
Boris-Chengbiao Zhou <bobo1239@web.de>,
Boqun Feng <boqun.feng@gmail.com>,
Douglas Su <d0u9.su@outlook.com>,
Dariusz Sosnowski <dsosnowski@dsosnowski.pl>,
Antonio Terceiro <antonio.terceiro@linaro.org>,
Daniel Xu <dxu@dxuuu.xyz>, Miguel Cano <macanroj@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kbuild@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v4 16/20] Kbuild: add Rust support
Date: Sat, 12 Feb 2022 14:16:50 +0000 [thread overview]
Message-ID: <YgfBUhYdLXA46kOX@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220212130410.6901-17-ojeda@kernel.org>
On Sat, Feb 12, 2022 at 02:03:42PM +0100, Miguel Ojeda wrote:
> +config RUST
> + bool "Rust support"
> + depends on RUST_IS_AVAILABLE
> + depends on ARM64 || CPU_32v6 || CPU_32v6K || (PPC64 && CPU_LITTLE_ENDIAN) || X86_64 || RISCV
Please don't use CPU_32v6* here.
It probably makes more sense to add a symbol "HAVE_RUST" and have the
appropriate architecture Kconfig files select HAVE_RUST.
Does Rust support Thumb on ARMv6 and ARMv7 architectures?
> + depends on !MODVERSIONS
> + depends on !GCC_PLUGIN_RANDSTRUCT
> + select CONSTRUCTORS
> + default n
Please remove every utterance of "default n" from your patch; n is the
default default which default defaults to, so you don't need to specify
default n to make the option default to n. It will default to n purely
because n is the default when no default is specified.
> + help
> + Enables Rust support in the kernel.
> +
> + This allows other Rust-related options, like drivers written in Rust,
> + to be selected.
As Rust doesn't support all the architectures that the kernel supports,
Rust must not be used for core infrastructure.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-12 14:17 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 13:03 [PATCH v4 00/20] Rust support Miguel Ojeda
2022-02-12 13:03 ` Miguel Ojeda
2022-02-12 13:03 ` Miguel Ojeda
2022-02-12 13:03 ` Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 01/20] kallsyms: support "big" kernel symbols Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 02/20] kallsyms: increase maximum kernel symbol length to 512 Miguel Ojeda
2022-02-22 8:19 ` Petr Mladek
2022-02-22 12:45 ` Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 03/20] kallsyms: use the correct buffer size for symbols Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 04/20] rust: add C helpers Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 05/20] rust: add `compiler_builtins` crate Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 06/20] rust: add `alloc` crate Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 07/20] rust: add `build_error` crate Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 08/20] rust: add `macros` crate Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 09/20] rust: add `kernel` crate's `sync` module Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 10/20] rust: add `kernel` crate Miguel Ojeda
2022-02-14 5:27 ` Sergey Senozhatsky
2022-02-14 13:36 ` Miguel Ojeda
2022-02-22 9:06 ` Petr Mladek
2022-02-22 12:48 ` Miguel Ojeda
2022-02-24 12:39 ` Petr Mladek
2022-02-12 13:03 ` [PATCH v4 11/20] rust: export generated symbols Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 12/20] vsprintf: add new `%pA` format specifier Miguel Ojeda
2022-02-14 10:18 ` Andy Shevchenko
2022-02-14 10:52 ` Rasmus Villemoes
2022-02-14 11:36 ` David Laight
2022-02-14 14:04 ` Miguel Ojeda
2022-02-14 12:12 ` Miguel Ojeda
2022-02-22 9:29 ` Petr Mladek
2022-02-22 10:35 ` Rasmus Villemoes
2022-02-24 9:55 ` Petr Mladek
2022-02-14 12:27 ` Miguel Ojeda
2022-02-14 13:54 ` Andy Shevchenko
2022-02-14 14:56 ` Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 13/20] scripts: add `generate_rust_analyzer.py` Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 14/20] scripts: decode_stacktrace: demangle Rust symbols Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 15/20] docs: add Rust documentation Miguel Ojeda
2022-02-14 10:47 ` Akira Yokosawa
2022-02-14 12:44 ` Miguel Ojeda
2022-02-16 13:37 ` Akira Yokosawa
2022-02-16 14:02 ` Miguel Ojeda
2022-03-17 8:19 ` Miguel Ojeda
2022-03-17 14:50 ` Akira Yokosawa
2022-03-18 13:12 ` Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 16/20] Kbuild: add Rust support Miguel Ojeda
2022-02-12 13:03 ` Miguel Ojeda
2022-02-12 13:03 ` Miguel Ojeda
2022-02-12 13:03 ` Miguel Ojeda
2022-02-12 14:16 ` Russell King (Oracle) [this message]
2022-02-12 14:16 ` Russell King (Oracle)
2022-02-12 14:16 ` Russell King (Oracle)
2022-02-12 14:16 ` Russell King (Oracle)
2022-02-12 15:47 ` Miguel Ojeda
2022-02-12 15:47 ` Miguel Ojeda
2022-02-12 15:47 ` Miguel Ojeda
2022-02-12 15:47 ` Miguel Ojeda
2022-02-12 16:18 ` Russell King (Oracle)
2022-02-12 16:18 ` Russell King (Oracle)
2022-02-12 16:18 ` Russell King (Oracle)
2022-02-12 16:18 ` Russell King (Oracle)
2022-02-12 18:32 ` Miguel Ojeda
2022-02-12 18:32 ` Miguel Ojeda
2022-02-12 18:32 ` Miguel Ojeda
2022-02-12 18:32 ` Miguel Ojeda
2022-02-12 18:27 ` John Paul Adrian Glaubitz
2022-02-12 18:27 ` John Paul Adrian Glaubitz
2022-02-12 18:27 ` John Paul Adrian Glaubitz
2022-02-12 18:27 ` John Paul Adrian Glaubitz
2022-02-12 18:57 ` Miguel Ojeda
2022-02-12 18:57 ` Miguel Ojeda
2022-02-12 18:57 ` Miguel Ojeda
2022-02-12 18:57 ` Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 17/20] samples: add Rust examples Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 18/20] MAINTAINERS: Rust Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 19/20] [RFC] drivers: gpio: PrimeCell PL061 in Rust Miguel Ojeda
2022-02-12 13:03 ` [PATCH v4 20/20] [RFC] drivers: android: Binder IPC " Miguel Ojeda
2022-02-13 9:31 ` [PATCH v4 00/20] Rust support, nn/nn Geert Stappers
2022-02-13 9:55 ` Greg KH
2022-02-13 10:52 ` Geert Stappers
2022-02-14 14:16 ` Miguel Ojeda
2022-02-14 14:48 ` Geert Stappers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgfBUhYdLXA46kOX@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alex.gaynor@gmail.com \
--cc=antonio.terceiro@linaro.org \
--cc=aou@eecs.berkeley.edu \
--cc=ark.email@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bobo1239@web.de \
--cc=boqun.feng@gmail.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=d0u9.su@outlook.com \
--cc=dave.hansen@linux.intel.com \
--cc=dsosnowski@dsosnowski.pl \
--cc=dxu@dxuuu.xyz \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=macanroj@gmail.com \
--cc=masahiroy@kernel.org \
--cc=me@kloenk.de \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thesven73@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=wedsonaf@google.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.