From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: berrange@redhat.com, qemu-devel@nongnu.org, virtio-fs@redhat.com,
vgoyal@redhat.com
Subject: Re: [Virtio-fs] [PATCH v2] Deprecate C virtiofsd
Date: Mon, 14 Feb 2022 11:30:03 +0000 [thread overview]
Message-ID: <Ygo9O7oWsImstSJu@work-vm> (raw)
In-Reply-To: <20220210204404.GA22879@redhat.com>
* Richard W.M. Jones (rjones@redhat.com) wrote:
> On Thu, Feb 10, 2022 at 05:47:14PM +0000, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > There's a nice new Rust implementation out there; recommend people
> > do new work on that.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> > docs/about/deprecated.rst | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> > index 47a594a3b6..3c73d22729 100644
> > --- a/docs/about/deprecated.rst
> > +++ b/docs/about/deprecated.rst
> > @@ -454,3 +454,20 @@ nanoMIPS ISA
> >
> > The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain.
> > As it is hard to generate binaries for it, declare it deprecated.
> > +
> > +Tools
> > +-----
> > +
> > +virtiofsd
> > +'''''''''
> > +
> > +There is a new Rust implementation of ``virtiofsd`` at
> > +``https://gitlab.com/virtio-fs/virtiofsd``;
> > +since this is now marked stable, new development should be done on that
> > +rather than the existing C version in the QEMU tree.
> > +The C version will still accept fixes and patches that
> > +are already in development for the moment, but will eventually
> > +be deleted from this tree.
> > +New deployments should use the Rust version, and existing systems
> > +should consider moving to it. The command line and feature set
> > +is very close and moving should be simple.
>
> I'm not qualified to say if the Rust impl is complete enough
> to replace the C version, so I won't add a reviewed tag.
We believe it is a complete replacement at this point, with compatible
command line.
Dave
> However I want to say that from the point of view of downstream
> packagers of qemu -- especially Fedora -- it would be helpful if we
> could direct both upstream development effort and downstream packaging
> into just the one virtiofsd. So I agree in principle with this.
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-p2v converts physical machines to virtual machines. Boot with a
> live CD or over the network (PXE) and turn machines into KVM guests.
> http://libguestfs.org/virt-v2v
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: berrange@redhat.com, slp@redhat.com, qemu-devel@nongnu.org,
virtio-fs@redhat.com, stefanha@redhat.com, vgoyal@redhat.com
Subject: Re: [PATCH v2] Deprecate C virtiofsd
Date: Mon, 14 Feb 2022 11:30:03 +0000 [thread overview]
Message-ID: <Ygo9O7oWsImstSJu@work-vm> (raw)
In-Reply-To: <20220210204404.GA22879@redhat.com>
* Richard W.M. Jones (rjones@redhat.com) wrote:
> On Thu, Feb 10, 2022 at 05:47:14PM +0000, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > There's a nice new Rust implementation out there; recommend people
> > do new work on that.
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> > docs/about/deprecated.rst | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> > index 47a594a3b6..3c73d22729 100644
> > --- a/docs/about/deprecated.rst
> > +++ b/docs/about/deprecated.rst
> > @@ -454,3 +454,20 @@ nanoMIPS ISA
> >
> > The ``nanoMIPS`` ISA has never been upstreamed to any compiler toolchain.
> > As it is hard to generate binaries for it, declare it deprecated.
> > +
> > +Tools
> > +-----
> > +
> > +virtiofsd
> > +'''''''''
> > +
> > +There is a new Rust implementation of ``virtiofsd`` at
> > +``https://gitlab.com/virtio-fs/virtiofsd``;
> > +since this is now marked stable, new development should be done on that
> > +rather than the existing C version in the QEMU tree.
> > +The C version will still accept fixes and patches that
> > +are already in development for the moment, but will eventually
> > +be deleted from this tree.
> > +New deployments should use the Rust version, and existing systems
> > +should consider moving to it. The command line and feature set
> > +is very close and moving should be simple.
>
> I'm not qualified to say if the Rust impl is complete enough
> to replace the C version, so I won't add a reviewed tag.
We believe it is a complete replacement at this point, with compatible
command line.
Dave
> However I want to say that from the point of view of downstream
> packagers of qemu -- especially Fedora -- it would be helpful if we
> could direct both upstream development effort and downstream packaging
> into just the one virtiofsd. So I agree in principle with this.
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> virt-p2v converts physical machines to virtual machines. Boot with a
> live CD or over the network (PXE) and turn machines into KVM guests.
> http://libguestfs.org/virt-v2v
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2022-02-14 11:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 17:47 [Virtio-fs] [PATCH v2] Deprecate C virtiofsd Dr. David Alan Gilbert (git)
2022-02-10 17:47 ` Dr. David Alan Gilbert (git)
2022-02-10 17:52 ` [Virtio-fs] " Daniel P. Berrangé
2022-02-10 17:52 ` Daniel P. Berrangé
2022-02-10 20:44 ` [Virtio-fs] " Richard W.M. Jones
2022-02-10 20:44 ` Richard W.M. Jones
2022-02-14 11:30 ` Dr. David Alan Gilbert [this message]
2022-02-14 11:30 ` Dr. David Alan Gilbert
2022-02-14 14:27 ` [Virtio-fs] " Vivek Goyal
2022-02-14 14:27 ` Vivek Goyal
2022-02-14 11:12 ` [Virtio-fs] " Stefan Hajnoczi
2022-02-14 11:12 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygo9O7oWsImstSJu@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.